From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ED8CDA00E6 for ; Thu, 21 Mar 2019 13:58:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C38AA1B4E5; Thu, 21 Mar 2019 13:58:24 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50051.outbound.protection.outlook.com [40.107.5.51]) by dpdk.org (Postfix) with ESMTP id F20131B4DB for ; Thu, 21 Mar 2019 13:58:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFOUOcKdTCvnt/nEKDRSGjlyfRmDIGq0nm+bqBbsuxo=; b=bYBTQ9IOM6vXP1wqBMmKTNm51nS2xJFwiW2l+rkpoyJbGcM/nG/oT1dI/XBsrirU2UDQ/OANOYmtah92sTLC6ljx1ce1AEbLKQ9UyABjZ5DA7oLCX5HASf+8z1dqXmiSPxY6LnOOEjaKa2W9hpIWSsObF4P/6CHW/nSYtsaOLoI= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3345.eurprd05.prod.outlook.com (10.171.189.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Thu, 21 Mar 2019 12:58:21 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02%3]) with mapi id 15.20.1709.015; Thu, 21 Mar 2019 12:58:21 +0000 From: Slava Ovsiienko To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH 00/14] net/mlx5: add support for multiport IB devices Thread-Index: AQHU39+ELTMl6piUQ0SGTd54zWEtoaYWBcUA Date: Thu, 21 Mar 2019 12:58:20 +0000 Message-ID: References: <1551376985-11096-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36c689ba-3bdf-461f-bea3-08d6adfce555 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3345; x-ms-traffictypediagnostic: AM4PR05MB3345: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(396003)(136003)(346002)(13464003)(199004)(189003)(99286004)(5024004)(256004)(229853002)(8936002)(6116002)(11346002)(14444005)(446003)(7696005)(110136005)(3846002)(25786009)(53936002)(76176011)(26005)(71190400001)(71200400001)(2906002)(6506007)(68736007)(55016002)(53546011)(476003)(86362001)(6246003)(9686003)(6436002)(102836004)(6306002)(186003)(966005)(316002)(52536014)(8676002)(486006)(305945005)(7736002)(81156014)(97736004)(106356001)(81166006)(5660300002)(478600001)(2501003)(74316002)(66066001)(105586002)(33656002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3345; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Vn3tWYYrmtBnWoIWDR8v4V2swTeqi8x5XTHJAqKm2EW9BY2Alvg6ScLuaHUPWvU2GQlISjeIA8bXW2pbbu2BkxZf1p00hOprjW9D/N18w2+D0xG4S3CE9FqM30WkNb2WYHCLIdneWh2TlCLpTQXLR6bTHTSbONsyyeJ+1inKwPQFXnkseDsZ4Q+MUBqzFACy9N3s68Kpc9Dpo1vBEVs+tIokbY4VfWHyrMEztbKQMI3c8CVJK+5vJNV2jFAQ1T/qL7ft/ngOFkrV4ZttyMvA7Frv2YoXpoQviFcSLz8FQRsIAKRqI0Lo8bC8iatwfcj/enCbAcClbS7hOsNL1Iz4rnfOR0eSBVZdxdO+m5naQ2jommeZdQDXaztr7BUnx+j3VCpUSopLUpJHA7dgrXs9nMm7/H7B9hH7HXjUpP4+bZA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36c689ba-3bdf-461f-bea3-08d6adfce555 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2019 12:58:20.9849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3345 Subject: Re: [dpdk-dev] [PATCH 00/14] net/mlx5: add support for multiport IB devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321125820.4Mc6A8bSJrFP100-Hi-8f5n7iZlDjgKKSwSuEMzHtdo@z> Hi, Shahaf, My special thanks for immediate review. PSB. With best regards, Slava > -----Original Message----- > From: Shahaf Shuler > Sent: Thursday, March 21, 2019 14:14 > To: Slava Ovsiienko ; dev@dpdk.org > Subject: RE: [PATCH 00/14] net/mlx5: add support for multiport IB devices >=20 > Thursday, March 21, 2019 10:11 AM, Viacheslav Ovsiienko: > > Subject: [PATCH 00/14] net/mlx5: add support for multiport IB devices > > > > The Mellanox NICs support SR-IOV and have E-Switch feature. > > When SR-IOV is set up in switchdev mode and E-Switch is enabled we > > have so called VF representors in the system. All representors > > belonging to the same E-Switch are created on the basis of the single > > PCI function and with current implementation each representor has its > > own dedicated Infiniband device and operates within its own Infiniband > > context. It is proposed to provide representors as ports of the single > > Infiniband device and operate on the shared Infiniband context. > > > > mlx5_pci_probe() routine is planned to be extended to probe the ports > > of found Infiniband devices. All active ports, belonging to the same > > Infiniband device will use the signle shared Infiniband context of that > device: > > - QP are created within shared context, with assigning to > > specified port > > - Verb flows are also created with specifying port index > > - Protection Domain is shared by all representors > > - Global Memory Regions Cache is shared by all representors, > > local ones are not (not in this patchset) > > - Shared Asynchronous Event Handler distributes events > > among the device ports (not in this patchset) > > - UAR mapping to user space is also shared (not in patchset) > > > > Each representor has its own attach network interface device, > > interface name and index can be retrieved via IB device and port > > index, so the link control is performed via Netlink in the same way as > > in existing implementation. >=20 > Nice Work Slava, > Please see my comments. >=20 > Also - where is the support for sharing of the memory regions? It is coming soon, as separate patch/patchset. Ditto regarding UAR sharing. >=20 > > > > This patchset also superseedes http://patches.dpdk.org/patch/50486/ > > > > Signed-off-by: Viacheslav Ovsiienko > > > > Viacheslav Ovsiienko (14): > > net/mlx5: add representor recognition on kernels 5.x > > net/mlx5: introduce multiport IB device shared structure > > net/mlx5: modify get ifindex routine for multiport IB > > net/mlx5: add getting IB ports number for multiport IB > > net/mlx5: add multiport IB device support to probing > > net/mlx5: add IB shared context alloc/free functions > > net/mlx5: switch to the names in the shared IB context > > net/mlx5: switch to the shared Protection Domain > > net/mlx5: switch to the shared context IB attributes > > net/mlx5: switch to the shared IB device context > > net/mlx5: provide IB port for the object being created > > net/mlx5: update install/uninstall int handler routines > > net/mlx5: update event handler for multiport IB devices > > net/mlx5: add source vport match to the ingress rules > > > > drivers/net/mlx5/Makefile | 10 + > > drivers/net/mlx5/meson.build | 4 + > > drivers/net/mlx5/mlx5.c | 549 +++++++++++++++++++++++++++--= ---- > > ---- > > drivers/net/mlx5/mlx5.h | 38 ++- > > drivers/net/mlx5/mlx5_ethdev.c | 241 ++++++++++------ > > drivers/net/mlx5/mlx5_flow.c | 2 + > > drivers/net/mlx5/mlx5_flow_dv.c | 47 +++- > > drivers/net/mlx5/mlx5_flow_verbs.c | 7 +- > > drivers/net/mlx5/mlx5_mr.c | 4 +- > > drivers/net/mlx5/mlx5_nl.c | 101 ++++++- > > drivers/net/mlx5/mlx5_rxq.c | 41 +-- > > drivers/net/mlx5/mlx5_socket.c | 4 +- > > drivers/net/mlx5/mlx5_stats.c | 22 +- > > drivers/net/mlx5/mlx5_trigger.c | 2 +- > > drivers/net/mlx5/mlx5_txq.c | 24 +- > > 15 files changed, 795 insertions(+), 301 deletions(-) > > > > -- > > 1.8.3.1