From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6ECDDA00E6 for ; Thu, 21 Mar 2019 15:02:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 484664CA6; Thu, 21 Mar 2019 15:02:52 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id EA7294C96 for ; Thu, 21 Mar 2019 15:02:50 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 512D7308794F; Thu, 21 Mar 2019 14:02:50 +0000 (UTC) Received: from localhost (ovpn-117-166.ams2.redhat.com [10.36.117.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 548AC5D6A6; Thu, 21 Mar 2019 14:02:46 +0000 (UTC) Date: Thu, 21 Mar 2019 15:02:44 +0100 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, ktraynor@redhat.com, stephen@networkplumber.org Message-ID: <20190321140244.bti7cizxpovyr3e6@jenstp.localdomain> References: <20190321134520.18675-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Disposition: inline In-Reply-To: <20190321134520.18675-1-maxime.coquelin@redhat.com> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 21 Mar 2019 14:02:50 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC] net/virtio: remove prefix from virtqueue struct fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321140244.UY2RRZnThMaWSUJSv3f-Hoo7b-QQxkn0b6osB8O8I1M@z> On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote: >Most of 'virtqueue' struct fields are prefixed with 'vq_'. >This redundant, this patch removes them all. > >Signed-off-by: Maxime Coquelin >--- >Hi, > >Following our discussions on removing the 'vq_' prefix, I did >the patch to see how it would look like. > >It looks like it does not prevent any lines to be split but one. >But the code is more readable IMHO. > >I send this as RFC to get your feedback. Yes, I think it's more readable. One thing I had not thought about is that it makes it harder to find meaningful results from git blame output. Can we live with that? regards, Jens