From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6125DA00E6 for ; Thu, 21 Mar 2019 15:17:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D6211B500; Thu, 21 Mar 2019 15:17:31 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id EF3E64CA7 for ; Thu, 21 Mar 2019 15:17:29 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23B5730820EA; Thu, 21 Mar 2019 14:17:29 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0722D604CE; Thu, 21 Mar 2019 14:17:23 +0000 (UTC) To: Jens Freimann Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, ktraynor@redhat.com, stephen@networkplumber.org References: <20190321134520.18675-1-maxime.coquelin@redhat.com> <20190321140244.bti7cizxpovyr3e6@jenstp.localdomain> From: Maxime Coquelin Message-ID: <9915b6b7-8e59-80a2-e58d-0fddeb244786@redhat.com> Date: Thu, 21 Mar 2019 15:17:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190321140244.bti7cizxpovyr3e6@jenstp.localdomain> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 21 Mar 2019 14:17:29 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC] net/virtio: remove prefix from virtqueue struct fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321141722.itd9cG-LfY9sVs1iST4__7OqZ53PAk17iVTwLbSTV3c@z> On 3/21/19 3:02 PM, Jens Freimann wrote: > On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote: >> Most of 'virtqueue' struct fields are prefixed with 'vq_'. >> This redundant, this patch removes them all. >> >> Signed-off-by: Maxime Coquelin >> --- >> Hi, >> >> Following our discussions on removing the 'vq_' prefix, I did >> the patch to see how it would look like. >> >> It looks like it does not prevent any lines to be split but one. >> But the code is more readable IMHO. >> >> I send this as RFC to get your feedback. > > Yes, I think it's more readable.  One thing I had not thought about is > that it makes it harder to find meaningful results from git blame > output. Can we live with that? That's a valid point, and I think it might be more problematic than the conflicts for backporting, which would be trivial to solve. I don't have a strong opinion on whether we should do it or not. Thanks, Maxime > > regards, > Jens