From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A3346A00E6 for ; Thu, 21 Mar 2019 16:27:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8025E1B506; Thu, 21 Mar 2019 16:27:11 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 2B90B1B501 for ; Thu, 21 Mar 2019 16:27:10 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id p6so4423445pgh.9 for ; Thu, 21 Mar 2019 08:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CBBtLnnwEquTCiEaa5XvPBzeHzV7XV1/+RBX9XSRVCM=; b=svTOlaQs/sHX9tSXiwQ1g905e+VL07zv/6D4ftt+FWeXQYezZHbsTR0L5fQCIgZC06 TR6+zao7ltnPldlr+S4ugeEnO1HiqgWGcFmrAFDBthNp0FO5wov1s5hUlHUhoCjnNY3z EO3tbrRdyq4bgOd1ZwbhYir3Uwaa/rp6suMJB9y3ABg4LNXxXYNO96K9bbkrx+Dvos3e 9R3/Fw4chJM9x1pEYoDf5brYhtal4RQWreFxu1k15pjSsWkILQb4JNvqEHMJE6+ushuV b+rQZIVSnmnk+OyyZON3qJcyPe+IqEOzVwDpdYiz5mrup972DXsWJkutB19DCjWU4pCo Rcsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CBBtLnnwEquTCiEaa5XvPBzeHzV7XV1/+RBX9XSRVCM=; b=pc5Tg0TZ0Vdccu5VKGkkdXUpAOmmiUgtE/V8v8L6NSnV/vv6yCcy9V0juwAEtnb95K llTn606RjFmXAzdRhUPsFLCeaqxUecmJ/wDHowiUp0z7MOQeXuMFiDJqJOFf6Qf2OGKq c6xufWvm4haaPjQKWNalsOehZdZHxbSl7tE3rw543IY19+J/H3XwoUqYCQ+Saz3/96Zr ky7wWiqDu6jh1AbNUdkekWGKNpVMd6V7QuL6tpVdDAnUjf87PMU9RJ+Vwd0MnLETUVez bZnUhO8zeVB5w0Ai6DkEL/4oVM/Qgw/rzl8MDbGGK7R+0zFFIIqvPAQRA/oj3eyKLJfU +sMw== X-Gm-Message-State: APjAAAXwCi6AxXz6O1G0P85bByLHY71mZQIbvIVjnQv/Qlqj6exkELeY /QJTWSBZ6hLsngSY1ef1FBUwuw3+zYxksA== X-Google-Smtp-Source: APXvYqxln188xT8LwDJ37F7T/v+wYjORgAEHSeP0MD2LWOK4Y8XepPifE2Z9vzwn25wIZ7p/50cQNA== X-Received: by 2002:aa7:8ac8:: with SMTP id b8mr3763669pfd.87.1553182028978; Thu, 21 Mar 2019 08:27:08 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r86sm8226827pfa.82.2019.03.21.08.27.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 08:27:08 -0700 (PDT) Date: Thu, 21 Mar 2019 08:27:05 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190321082705.1ee71f1f@shemminger-XPS-13-9360> In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321152705.ER9iCtwzTgl-7-l7V6VNGROyJPWuWNLn6cYZxPwtbIk@z> On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > static void kick_tx(struct pkt_tx_queue *txq) > +{ > + struct xsk_umem_info *umem = txq->pair->umem; > + > + while (send(xsk_socket__fd(txq->pair->xsk), NULL, > + 0, MSG_DONTWAIT) < 0) { > + /* some thing unexpected */ > + if (errno != EBUSY && errno != EAGAIN) > + break; > + > + /* pull from complete qeueu to leave more space */ > + if (errno == EAGAIN) > + pull_umem_cq(umem, ETH_AF_XDP_TX_BATCH_SIZE); > + } What about EINTR?? You should retry the send then.