From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 02A46A00E6 for ; Thu, 21 Mar 2019 16:36:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F00951B51A; Thu, 21 Mar 2019 16:36:41 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 111CD4CC7 for ; Thu, 21 Mar 2019 16:36:40 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id c207so4534214pfc.7 for ; Thu, 21 Mar 2019 08:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7SWLv7xf35x7onFeukSgfYRr1GEZfz/97zjHc5Hmngk=; b=oZHGQGvUpyT7dCURbgv3jb09V8LHOfWdb9/jvOSWMu/QhHdAB2L10HQ9SW5gv6rBZ+ lF8mDiwL+V7xGGpz+HCf8qkC9+EYUBF7OIoethNQ78ljyA9ky1+1UY+yISM+qK1EJUMy ndeMWZWmzLOoGTYberTZhVIo09VCszJb4pAd5avpNOesJVTtKg+a7hWbzbdsdE9Sp6iH xPr7Wz4v5SFBlRmLHVs5RpQxJ8sYKoCMkRqiYcI8/qoEdG4ZXC8DyDYhFhHl9muHuagG J3F2Ob4LZad58k4EU3EU/q/wrG9DEB7yU6a8W5gTZAdfMI2q9zDb8dUeb1SJ+04lC21+ ak4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7SWLv7xf35x7onFeukSgfYRr1GEZfz/97zjHc5Hmngk=; b=ZazerVcJuGcbKLEL1Nf/qyFEjOKYnT7WXwPQrv/6rHs4boQc0q2A2bUjz3ZcAm/+x5 EMBKpS+jboPEBmQ6/qeMVfeANaoqhUzOecFjA+4wrCZ+O47iNZhyCn5gSi8URGkNcqDe 3dSPGc4EvK1A2R5LSynn1MtTQT4kYceu0hkGSFV1G2VPJLdTk8BXAew5dV7+7pKBX6Pf iKp2ILn/oJZzxGZhfIv4jW1yIiXom+pcJaz9QGXXJQoL69jkcIYZOiL8xJoc9Oy50f95 /y+lAdak0ln4gOGjUmQ45BIjX5bDHE6i68wzjXMOpbIX1X4ofLfi77nSKE0pAUOW2zWy P9GA== X-Gm-Message-State: APjAAAWuE2N/0CF7gATcEZ42ieGTrYzunK42aI8f2WucrnZxrpjLjxRN fRE48YLC/0FuInCfXIZ9QgOjTA== X-Google-Smtp-Source: APXvYqwLpsLXc9JC0R1RTGZI1duUE0NvJdEJx6fGo+/BnuPTRHT/j+2G8q8Mj7RfOYC7MtOKhmFq8A== X-Received: by 2002:a63:1960:: with SMTP id 32mr3875877pgz.171.1553182599243; Thu, 21 Mar 2019 08:36:39 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 7sm10493923pgj.64.2019.03.21.08.36.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 08:36:39 -0700 (PDT) Date: Thu, 21 Mar 2019 08:36:34 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190321083634.70220adb@shemminger-XPS-13-9360> In-Reply-To: <20190321091845.78495-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321153634.W800kEGJpjn9jcw9BN6yshdcdbKMDe7NppDtmc0qtAs@z> On Thu, 21 Mar 2019 17:18:41 +0800 Xiaolong Ye wrote: > + > +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); The convention in other network drivers is to use net_XXX in the vdev name. In AF_XDP that would be: RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); About naming, I would just drop AF_ from the name everywhere, the driver is about running over XDP, and the "AF_" is just a prefix for address family. Why not: net/xdp