From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const
Date: Thu, 21 Mar 2019 12:59:10 -0700 [thread overview]
Message-ID: <20190321195910.11140-1-stephen@networkplumber.org> (raw)
Message-ID: <20190321195910.NgDHd_Vt1PdZHIprQvEVeSbVUjgu5806XmPjVFExhGQ@z> (raw)
The divisor is not modified here. Doesn't really matter for optimizaton
since the function is inline already; but helps with expressing
intent.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/common/include/rte_reciprocal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/rte_reciprocal.h b/lib/librte_eal/common/include/rte_reciprocal.h
index 3492c73bafea..63e16fde0aa8 100644
--- a/lib/librte_eal/common/include/rte_reciprocal.h
+++ b/lib/librte_eal/common/include/rte_reciprocal.h
@@ -77,7 +77,7 @@ mullhi_u64(uint64_t x, uint64_t y)
}
static __rte_always_inline uint64_t
-rte_reciprocal_divide_u64(uint64_t a, struct rte_reciprocal_u64 *R)
+rte_reciprocal_divide_u64(uint64_t a, const struct rte_reciprocal_u64 *R)
{
uint64_t t = mullhi_u64(a, R->m);
--
2.17.1
next reply other threads:[~2019-03-21 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 19:59 Stephen Hemminger [this message]
2019-03-21 19:59 ` Stephen Hemminger
2019-03-22 18:09 ` Maxime Coquelin
2019-03-22 18:09 ` Maxime Coquelin
2019-04-03 16:17 ` Thomas Monjalon
2019-04-03 16:17 ` Thomas Monjalon
2019-03-27 11:14 ` Thomas Monjalon
2019-03-27 11:14 ` Thomas Monjalon
2019-04-02 15:26 ` Stephen Hemminger
2019-04-02 15:26 ` Stephen Hemminger
2019-04-02 16:05 ` Thomas Monjalon
2019-04-02 16:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321195910.11140-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).