From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, chas3@att.com, zhaohui8@huawei.com,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types
Date: Thu, 21 Mar 2019 21:28:13 +0100 [thread overview]
Message-ID: <1553200094-5487-1-git-send-email-david.marchand@redhat.com> (raw)
Message-ID: <20190321202813.COqNtJM4tGEBkSxx-xJ6SJQdkF4BJr7Z3xU6NWz9BJA@z> (raw)
From: Zhaohui <zhaohui8@huawei.com>
mode_bond_id and mode_band_id are slave ids, stored on 16bits.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: stable@dpdk.org
Signed-off-by: Zhaohui <zhaohui8@huawei.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 1e6a3fc..3943ec1 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -638,7 +638,7 @@
SM_FLAG_CLR(port, NTT);
}
-static uint8_t
+static uint16_t
max_index(uint64_t *a, int n)
{
if (n <= 0)
@@ -672,7 +672,8 @@
uint64_t agg_bandwidth[8] = {0};
uint64_t agg_count[8] = {0};
uint16_t default_slave = 0;
- uint8_t mode_count_id, mode_band_id;
+ uint16_t mode_count_id;
+ uint16_t mode_band_id;
struct rte_eth_link link_info;
slaves = internals->active_slaves;
@@ -708,13 +709,11 @@
switch (internals->mode4.agg_selection) {
case AGG_COUNT:
- mode_count_id = max_index(
- (uint64_t *)agg_count, slaves_count);
+ mode_count_id = max_index(agg_count, slaves_count);
new_agg_id = mode_count_id;
break;
case AGG_BANDWIDTH:
- mode_band_id = max_index(
- (uint64_t *)agg_bandwidth, slaves_count);
+ mode_band_id = max_index(agg_bandwidth, slaves_count);
new_agg_id = mode_band_id;
break;
case AGG_STABLE:
--
1.8.3.1
next reply other threads:[~2019-03-21 20:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 20:28 David Marchand [this message]
2019-03-21 20:28 ` David Marchand
2019-03-21 20:28 ` [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes David Marchand
2019-03-21 20:28 ` David Marchand
2019-03-22 11:18 ` Maxime Coquelin
2019-03-22 11:18 ` Maxime Coquelin
2019-03-24 13:35 ` Chas Williams
2019-03-24 13:35 ` Chas Williams
2019-03-24 17:11 ` David Marchand
2019-03-24 17:11 ` David Marchand
2019-03-24 17:24 ` Chas Williams
2019-03-24 17:24 ` Chas Williams
2019-03-24 18:01 ` David Marchand
2019-03-24 18:01 ` David Marchand
2019-09-30 13:49 ` Yigit, Ferruh
2019-03-22 11:18 ` [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types Maxime Coquelin
2019-03-22 11:18 ` Maxime Coquelin
2019-09-30 13:49 ` Yigit, Ferruh
2019-03-24 13:28 ` Chas Williams
2019-03-24 13:28 ` Chas Williams
2019-03-24 17:13 ` David Marchand
2019-03-24 17:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553200094-5487-1-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=zhaohui8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).