Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

["Zhao1, Wei" <wei.zhao1@intel.com>]

> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Wednesday, March 20, 2019 8:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect
> RSS key
> 
> On 20/03/2019 03:31, Wei Zhao wrote:
> > There need a warning info when no perfect RSS key is config,
> 
> It is mixing info and warning levels in the description and log. Better to be
> consistent and use one (I think info).
> 

Ok, we will use dev info.

> > so i40e will use default key.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
> >  		rss_conf.rss_key = (uint8_t *)rss_key_default;
> >  		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> >  							sizeof(uint32_t);
> > +		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> > +use default configuration\n");
> 
> It's an info log, so remove "Warning!" and the message can be a little clearer
> so user doesn't interpret as an instruction. Suggest "No RSS key config for
> i40e provided, using default"

Ok , change in v2 

> 
> >  	}
> >
> >  	i40e_hw_rss_hash_set(pf, &rss_conf);
> >