From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BFE0B58C4 for ; Fri, 22 Mar 2019 02:53:09 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 18:53:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,255,1549958400"; d="scan'208";a="124815679" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga007.jf.intel.com with ESMTP; 21 Mar 2019 18:53:07 -0700 Date: Fri, 22 Mar 2019 09:49:03 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322014903.GA84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083634.70220adb@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321083634.70220adb@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 01:53:10 -0000 On 03/21, Stephen Hemminger wrote: >On Thu, 21 Mar 2019 17:18:41 +0800 >Xiaolong Ye wrote: > >> + >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); > >The convention in other network drivers is to use net_XXX in the vdev name. >In AF_XDP that would be: > >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); Got it. > >About naming, I would just drop AF_ from the name everywhere, the driver >is about running over XDP, and the "AF_" is just a prefix for address family. > >Why not: > net/xdp Thanks for the advice, Actually this driver is more about AF_XDP rathan than XDP, the foundational objects it uses such as umem, umem fill ring, umem completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would rather keep the naming. Thanks, Xiaolong > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 92C54A00E6 for ; Fri, 22 Mar 2019 02:53:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A88451B54D; Fri, 22 Mar 2019 02:53:11 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BFE0B58C4 for ; Fri, 22 Mar 2019 02:53:09 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 18:53:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,255,1549958400"; d="scan'208";a="124815679" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga007.jf.intel.com with ESMTP; 21 Mar 2019 18:53:07 -0700 Date: Fri, 22 Mar 2019 09:49:03 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322014903.GA84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083634.70220adb@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190321083634.70220adb@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322014903.hfOtL-pz5AeUHCX_7kZCQPG85Wx868DOnjm1goJSt0s@z> On 03/21, Stephen Hemminger wrote: >On Thu, 21 Mar 2019 17:18:41 +0800 >Xiaolong Ye wrote: > >> + >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); > >The convention in other network drivers is to use net_XXX in the vdev name. >In AF_XDP that would be: > >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); Got it. > >About naming, I would just drop AF_ from the name everywhere, the driver >is about running over XDP, and the "AF_" is just a prefix for address family. > >Why not: > net/xdp Thanks for the advice, Actually this driver is more about AF_XDP rathan than XDP, the foundational objects it uses such as umem, umem fill ring, umem completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would rather keep the naming. Thanks, Xiaolong >