From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 46944A00E6 for <public@inbox.dpdk.org>; Fri, 22 Mar 2019 08:10:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BB611B576; Fri, 22 Mar 2019 08:10:53 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B0C801B576 for <dev@dpdk.org>; Fri, 22 Mar 2019 08:10:51 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 00:10:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="144221521" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga002.jf.intel.com with ESMTP; 22 Mar 2019 00:10:49 -0700 Date: Fri, 22 Mar 2019 15:10:32 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org, zhihong.wang@intel.com, ktraynor@redhat.com, stephen@networkplumber.org Message-ID: <20190322071032.GA29521@dpdk-tbie.sh.intel.com> References: <20190321134520.18675-1-maxime.coquelin@redhat.com> <20190321140244.bti7cizxpovyr3e6@jenstp.localdomain> <9915b6b7-8e59-80a2-e58d-0fddeb244786@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9915b6b7-8e59-80a2-e58d-0fddeb244786@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [RFC] net/virtio: remove prefix from virtqueue struct fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190322071032.zdw4oNQOq0RGebaa7y7qf1Dtqyhm26M-lrjJF2y3evw@z> On Thu, Mar 21, 2019 at 03:17:22PM +0100, Maxime Coquelin wrote: > On 3/21/19 3:02 PM, Jens Freimann wrote: > > On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote: > > > Most of 'virtqueue' struct fields are prefixed with 'vq_'. > > > This redundant, this patch removes them all. > > > > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > > --- > > > Hi, > > > > > > Following our discussions on removing the 'vq_' prefix, I did > > > the patch to see how it would look like. Thanks for the work! > > > > > > It looks like it does not prevent any lines to be split but one. > > > But the code is more readable IMHO. > > > > > > I send this as RFC to get your feedback. > > > > Yes, I think it's more readable. One thing I had not thought about is > > that it makes it harder to find meaningful results from git blame > > output. Can we live with that? > > That's a valid point, and I think it might be more problematic than the > conflicts for backporting, which would be trivial to solve. > > I don't have a strong opinion on whether we should do it or not. I also don't have a strong opinion. Thanks, Tiwei > > Thanks, > Maxime > > > > regards, > > Jens