From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id C134D4C9F for ; Fri, 22 Mar 2019 16:37:50 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id 8so1791028pfr.4 for ; Fri, 22 Mar 2019 08:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dig1Rmm81bsJKRUP7maN0BhVx/COSwAqglEaqC3K6S4=; b=tSeWRfIyzeb2oOi9AeCTj0r0sOM2TJqdAsurIaSo8KH7wbOR3T9hG/I2O3S+5vIh/p sPflGc/t8dYMyMoFythDXw4bzjl6+ynO72RF1dOwt3HeQsYPSLxgCiqWg+DOBOGgZD93 i7dUwcQnVyjfMPc+tVFQ/1Btlko/L2OqgJFQg7qEvA308sWj2a8avX3DgkD4VImtEXJp Iw79kmT4nI8dDbdWQDRY9ck3jFRTWUn/ljV1PVKn5sllx8V95pwWeH9AcvKe0GWXdsAk OQI01VGc+zA/IJayM5Rz0UjYV1tIb3z5vgSFTGOxIkrCvpMSJooEFqg3a2O6etho3v/Z x6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dig1Rmm81bsJKRUP7maN0BhVx/COSwAqglEaqC3K6S4=; b=i0FRZz3aVes3yN+ad12nPiuJ9a06B+IZNrUYVosCKlimTeOaPzelyRLndgrHyA4eni Tr3nVOF9maj8ywLOt7quqcqixwAQuIYP9feOFW+1uQsReRQnJx87XHKTE3LZ/7CDcKbC WF9Ov/fkoiqqbHgj9PChit+T7c0zlEVRyDu3fALp6r2UutkllweKpxY4H2UiVmBco06g 1S23Ok5WxKK7uUFN4s5pRj0CD6poKykSLjuiMGMU7jnfkt4O4LpOdtyqC3Y7QrRb4W8A zrF77XntmwnLZnAPaniimDczvUnPJzIPFePBIIXJL3JFY4sqhXimxyJw3TturPr5uG/Q Fohg== X-Gm-Message-State: APjAAAVTTox5EL8NhUnO7Q0/ENLaF45BkGM0oYxiRiWyuLz0jjvuQjZu ARmiujH+3cGxrA789F01qpK/0g== X-Google-Smtp-Source: APXvYqyzaZCPoVcMTeuO6o2fH2ckdPNQ2E7t83TRQArOjgVGb24v1Agrxf3Zih0WaXxDnAvKS7XaXQ== X-Received: by 2002:a62:4115:: with SMTP id o21mr8827583pfa.153.1553269069795; Fri, 22 Mar 2019 08:37:49 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u4sm9244331pgp.59.2019.03.22.08.37.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 08:37:49 -0700 (PDT) Date: Fri, 22 Mar 2019 08:37:46 -0700 From: Stephen Hemminger To: Ye Xiaolong Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322083746.12467e17@shemminger-XPS-13-9360> In-Reply-To: <20190322020157.GD84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083000.5894dbf7@shemminger-XPS-13-9360> <20190322020157.GD84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 15:37:51 -0000 On Fri, 22 Mar 2019 10:01:57 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> + if (ret < 0) > >> + return -EINVAL; > >> + > >> + return 0; > > > >You could propogate kernel errno into DPDK? > > return (ret < 0) ? -errno : 0; > > > > Sorry, could you share the advantage of doing this? > > Thanks, > Xiaolong Suppose kernel returned -ENOTSUPP or other error, it could go back to the caller rather than juse invalid. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 96DA1A00E6 for ; Fri, 22 Mar 2019 16:37:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60CE54F90; Fri, 22 Mar 2019 16:37:52 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id C134D4C9F for ; Fri, 22 Mar 2019 16:37:50 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id 8so1791028pfr.4 for ; Fri, 22 Mar 2019 08:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dig1Rmm81bsJKRUP7maN0BhVx/COSwAqglEaqC3K6S4=; b=tSeWRfIyzeb2oOi9AeCTj0r0sOM2TJqdAsurIaSo8KH7wbOR3T9hG/I2O3S+5vIh/p sPflGc/t8dYMyMoFythDXw4bzjl6+ynO72RF1dOwt3HeQsYPSLxgCiqWg+DOBOGgZD93 i7dUwcQnVyjfMPc+tVFQ/1Btlko/L2OqgJFQg7qEvA308sWj2a8avX3DgkD4VImtEXJp Iw79kmT4nI8dDbdWQDRY9ck3jFRTWUn/ljV1PVKn5sllx8V95pwWeH9AcvKe0GWXdsAk OQI01VGc+zA/IJayM5Rz0UjYV1tIb3z5vgSFTGOxIkrCvpMSJooEFqg3a2O6etho3v/Z x6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dig1Rmm81bsJKRUP7maN0BhVx/COSwAqglEaqC3K6S4=; b=i0FRZz3aVes3yN+ad12nPiuJ9a06B+IZNrUYVosCKlimTeOaPzelyRLndgrHyA4eni Tr3nVOF9maj8ywLOt7quqcqixwAQuIYP9feOFW+1uQsReRQnJx87XHKTE3LZ/7CDcKbC WF9Ov/fkoiqqbHgj9PChit+T7c0zlEVRyDu3fALp6r2UutkllweKpxY4H2UiVmBco06g 1S23Ok5WxKK7uUFN4s5pRj0CD6poKykSLjuiMGMU7jnfkt4O4LpOdtyqC3Y7QrRb4W8A zrF77XntmwnLZnAPaniimDczvUnPJzIPFePBIIXJL3JFY4sqhXimxyJw3TturPr5uG/Q Fohg== X-Gm-Message-State: APjAAAVTTox5EL8NhUnO7Q0/ENLaF45BkGM0oYxiRiWyuLz0jjvuQjZu ARmiujH+3cGxrA789F01qpK/0g== X-Google-Smtp-Source: APXvYqyzaZCPoVcMTeuO6o2fH2ckdPNQ2E7t83TRQArOjgVGb24v1Agrxf3Zih0WaXxDnAvKS7XaXQ== X-Received: by 2002:a62:4115:: with SMTP id o21mr8827583pfa.153.1553269069795; Fri, 22 Mar 2019 08:37:49 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u4sm9244331pgp.59.2019.03.22.08.37.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 08:37:49 -0700 (PDT) Date: Fri, 22 Mar 2019 08:37:46 -0700 From: Stephen Hemminger To: Ye Xiaolong Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322083746.12467e17@shemminger-XPS-13-9360> In-Reply-To: <20190322020157.GD84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083000.5894dbf7@shemminger-XPS-13-9360> <20190322020157.GD84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322153746.QYDtykRuE7uKraAA67V_wejhccqRcaM1rHELxJsjLn0@z> On Fri, 22 Mar 2019 10:01:57 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> + if (ret < 0) > >> + return -EINVAL; > >> + > >> + return 0; > > > >You could propogate kernel errno into DPDK? > > return (ret < 0) ? -errno : 0; > > > > Sorry, could you share the advantage of doing this? > > Thanks, > Xiaolong Suppose kernel returned -ENOTSUPP or other error, it could go back to the caller rather than juse invalid.