From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id A85296904 for ; Fri, 22 Mar 2019 16:38:42 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id h8so1774764pgp.6 for ; Fri, 22 Mar 2019 08:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DknWmWpb3LLJIWBMhRHDahjjSLLzungM3qlwhDlVOfg=; b=DWnbrvVhDalPYBZADUORUg11qzaltdn01K2sYaVJPU1kVfikVBNIAd/xcxcn9kISya W7uJwpcycuhzbga0qhM/Q1aHNcihCabBaKx/T+L/II5d0PvD+5i3bzIssCB9tnf1y9BF OQcdHyTXgmVX5ye4CSzPa+sle+LUvV/RhX+0vJZvlK2UsAFXZx7kqAt+3xNn55XFH+Lk XES1h54TsJYA0lNaKds0+3I6DEXQtzUoGKp4MNwqJeX873+ty/qSnnrcofb03vKeKG+I sUvGIJdZAkkmCOR8q/tjwMpkoKDxm6YzK8ShvaOpSiZqsNO5oyp6IoJ+qbgQyKsKc5JV PtvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DknWmWpb3LLJIWBMhRHDahjjSLLzungM3qlwhDlVOfg=; b=cTfNv9EnB23LXjf28+Y5TSEMDsITS5rHiaymutShXxXBqjqMBTj8EN0Y1lqE2fQ3Zo gwoXBItdRGEgfFNf4Fd8IqynqT4MRsiMemOJgCK3nuk48voCTkroTPtXn6nbsf2aO21v QQZwvrnmtT5+xOjW3/WagCUMNNYjddiNTRhcoyJP+839dG1aQczHBUvnZDWgYHgvwjca TU+LayMXRlnpqsxZp7haVZYoLEJNC+dwfv4GT3ZLz+B/zn6GmaHAiFVHq9UiLQEPl9P5 Yx+NIZMjZHTg9YHgPXnl+7SiCBXrppS0YQo2dzxWSP/punVabIB/Nicv/Hls3b4EhZoI CCYA== X-Gm-Message-State: APjAAAVbGeL36WF9V0plKQBxK7li7SPshsbctL7Y+6o4WTD6kcmNpJMa pII5nnSn/l5hFPycY0WZqqYu5A== X-Google-Smtp-Source: APXvYqxYh7Q3x2Lc6vqef7qPunJj8ypyn8Fz+c31DV9FWoXCi5eBKM/fj9ItXt28KnAJ9yqM8ZDAlQ== X-Received: by 2002:a17:902:8f81:: with SMTP id z1mr10436217plo.265.1553269121910; Fri, 22 Mar 2019 08:38:41 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z69sm4624336pfi.30.2019.03.22.08.38.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 08:38:41 -0700 (PDT) Date: Fri, 22 Mar 2019 08:38:38 -0700 From: Stephen Hemminger To: Ye Xiaolong Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322083838.1da3e00e@shemminger-XPS-13-9360> In-Reply-To: <20190322021523.GH84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321082822.2660e913@shemminger-XPS-13-9360> <20190322021523.GH84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 15:38:42 -0000 On Fri, 22 Mar 2019 10:15:23 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + if (ret != 0) { > >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed for XDP_STATISTICS.\n"); > >> + return -1; > > > >You need to use the new dynamic log types and not have a global logtype. > > You mean for all the logs in this driver, right? Is it due to the global logtype > will be deprecated? Global log types should not be used or added by any new code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 10C8AA00E6 for ; Fri, 22 Mar 2019 16:38:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB1851B6DA; Fri, 22 Mar 2019 16:38:43 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id A85296904 for ; Fri, 22 Mar 2019 16:38:42 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id h8so1774764pgp.6 for ; Fri, 22 Mar 2019 08:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DknWmWpb3LLJIWBMhRHDahjjSLLzungM3qlwhDlVOfg=; b=DWnbrvVhDalPYBZADUORUg11qzaltdn01K2sYaVJPU1kVfikVBNIAd/xcxcn9kISya W7uJwpcycuhzbga0qhM/Q1aHNcihCabBaKx/T+L/II5d0PvD+5i3bzIssCB9tnf1y9BF OQcdHyTXgmVX5ye4CSzPa+sle+LUvV/RhX+0vJZvlK2UsAFXZx7kqAt+3xNn55XFH+Lk XES1h54TsJYA0lNaKds0+3I6DEXQtzUoGKp4MNwqJeX873+ty/qSnnrcofb03vKeKG+I sUvGIJdZAkkmCOR8q/tjwMpkoKDxm6YzK8ShvaOpSiZqsNO5oyp6IoJ+qbgQyKsKc5JV PtvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DknWmWpb3LLJIWBMhRHDahjjSLLzungM3qlwhDlVOfg=; b=cTfNv9EnB23LXjf28+Y5TSEMDsITS5rHiaymutShXxXBqjqMBTj8EN0Y1lqE2fQ3Zo gwoXBItdRGEgfFNf4Fd8IqynqT4MRsiMemOJgCK3nuk48voCTkroTPtXn6nbsf2aO21v QQZwvrnmtT5+xOjW3/WagCUMNNYjddiNTRhcoyJP+839dG1aQczHBUvnZDWgYHgvwjca TU+LayMXRlnpqsxZp7haVZYoLEJNC+dwfv4GT3ZLz+B/zn6GmaHAiFVHq9UiLQEPl9P5 Yx+NIZMjZHTg9YHgPXnl+7SiCBXrppS0YQo2dzxWSP/punVabIB/Nicv/Hls3b4EhZoI CCYA== X-Gm-Message-State: APjAAAVbGeL36WF9V0plKQBxK7li7SPshsbctL7Y+6o4WTD6kcmNpJMa pII5nnSn/l5hFPycY0WZqqYu5A== X-Google-Smtp-Source: APXvYqxYh7Q3x2Lc6vqef7qPunJj8ypyn8Fz+c31DV9FWoXCi5eBKM/fj9ItXt28KnAJ9yqM8ZDAlQ== X-Received: by 2002:a17:902:8f81:: with SMTP id z1mr10436217plo.265.1553269121910; Fri, 22 Mar 2019 08:38:41 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z69sm4624336pfi.30.2019.03.22.08.38.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 08:38:41 -0700 (PDT) Date: Fri, 22 Mar 2019 08:38:38 -0700 From: Stephen Hemminger To: Ye Xiaolong Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322083838.1da3e00e@shemminger-XPS-13-9360> In-Reply-To: <20190322021523.GH84243@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321082822.2660e913@shemminger-XPS-13-9360> <20190322021523.GH84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322153838.Pg_trhmQvbZX52NyQMBL_UGR9e9ONJ9rwOyacHeM6Dw@z> On Fri, 22 Mar 2019 10:15:23 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + if (ret != 0) { > >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed for XDP_STATISTICS.\n"); > >> + return -1; > > > >You need to use the new dynamic log types and not have a global logtype. > > You mean for all the logs in this driver, right? Is it due to the global logtype > will be deprecated? Global log types should not be used or added by any new code.