From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 69E351B588 for ; Fri, 22 Mar 2019 10:32:10 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 02:32:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="216520993" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by orsmga001.jf.intel.com with SMTP; 22 Mar 2019 02:32:06 -0700 Received: by (sSMTP sendmail emulation); Fri, 22 Mar 2019 09:32:05 +0000 Date: Fri, 22 Mar 2019 09:32:05 +0000 From: Bruce Richardson To: Ye Xiaolong Cc: Stephen Hemminger , dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322093204.GA119220@bricha3-MOBL.ger.corp.intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083634.70220adb@shemminger-XPS-13-9360> <20190322014903.GA84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322014903.GA84243@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 09:32:10 -0000 On Fri, Mar 22, 2019 at 09:49:03AM +0800, Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); > > > >The convention in other network drivers is to use net_XXX in the vdev name. > >In AF_XDP that would be: > > > >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); > > Got it. > > > > >About naming, I would just drop AF_ from the name everywhere, the driver > >is about running over XDP, and the "AF_" is just a prefix for address family. > > > >Why not: > > net/xdp > > Thanks for the advice, Actually this driver is more about AF_XDP rathan than > XDP, the foundational objects it uses such as umem, umem fill ring, umem > completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would > rather keep the naming. > +1 for the naming. AF_XDP is something different from XDP itself, though the former does use the latter. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8058AA00E6 for ; Fri, 22 Mar 2019 10:32:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E8E71B589; Fri, 22 Mar 2019 10:32:12 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 69E351B588 for ; Fri, 22 Mar 2019 10:32:10 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 02:32:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="216520993" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by orsmga001.jf.intel.com with SMTP; 22 Mar 2019 02:32:06 -0700 Received: by (sSMTP sendmail emulation); Fri, 22 Mar 2019 09:32:05 +0000 Date: Fri, 22 Mar 2019 09:32:05 +0000 From: Bruce Richardson To: Ye Xiaolong Cc: Stephen Hemminger , dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322093204.GA119220@bricha3-MOBL.ger.corp.intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321083634.70220adb@shemminger-XPS-13-9360> <20190322014903.GA84243@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190322014903.GA84243@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322093205.0Ex8Aa_xSbhFo9emGMNv5v3pgN0Aui0CYmW_Ug9NtnY@z> On Fri, Mar 22, 2019 at 09:49:03AM +0800, Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); > > > >The convention in other network drivers is to use net_XXX in the vdev name. > >In AF_XDP that would be: > > > >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); > > Got it. > > > > >About naming, I would just drop AF_ from the name everywhere, the driver > >is about running over XDP, and the "AF_" is just a prefix for address family. > > > >Why not: > > net/xdp > > Thanks for the advice, Actually this driver is more about AF_XDP rathan than > XDP, the foundational objects it uses such as umem, umem fill ring, umem > completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would > rather keep the naming. > +1 for the naming. AF_XDP is something different from XDP itself, though the former does use the latter. /Bruce