Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 3/22/19 2:37 PM, David Marchand wrote:
> Add a new "show/clear fwd stats all" command to display fwd and port
> statistics on the fly.
> 
> To be able to do so, the (testpmd only) rte_port structure can't be used
> to maintain any statistics.
> Moved the stats dump parts from stop_packet_forwarding() and merge with
> fwd_port_stats_display() into fwd_stats_display().
> fwd engine statistics are then aggregated into a local per port array.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v3:
> - added description in testpmd usage
> - renamed cmd_fwdall as cmd_showfwdall
> 
> Changelog since v1:
> - removed hunk from now deleted patch 3
> 
> ---
>   app/test-pmd/cmdline.c                      |  49 ++++
>   app/test-pmd/testpmd.c                      | 425 +++++++++++++++-------------
>   app/test-pmd/testpmd.h                      |   9 +-
>   doc/guides/testpmd_app_ug/testpmd_funcs.rst |  36 +++
>   4 files changed, 310 insertions(+), 209 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>