From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3275EA00E6 for ; Fri, 22 Mar 2019 18:31:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2828C1B71D; Fri, 22 Mar 2019 18:31:23 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id F2AA01B700; Fri, 22 Mar 2019 18:31:21 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 2A39A100073; Fri, 22 Mar 2019 17:31:19 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Mar 2019 17:31:11 +0000 To: David Marchand , Maxime Coquelin CC: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> From: Andrew Rybchenko Message-ID: <217b4d41-6e00-d4b0-7b6f-782c88d33951@solarflare.com> Date: Fri, 22 Mar 2019 20:31:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24504.003 X-TM-AS-Result: No-7.399800-8.000000-10 X-TMASE-MatchedRID: cgbqQT5W8hd2LasmHuCXMSa1MaKuob8PC/ExpXrHizys/t8iuh5J8/c0 sCjJFDn3EHmuEGswNEP623tebPkTO+qVwvVx2/GPMN+B8zdlz9Ejs7F41+YP7Hv3ioAd9KrSsT6 GSFHInVWpeockmHCRimYlLqTvfoxMhlahuHmDw1Yk78SxLKShoILLh2/Jcc7eRC8FOrq2WvajxY yRBa/qJaEwgORH8p/AjaPj0W1qn0SujVRFkkVsm7fCaQzXzvcIeuGKuNTlS7FqWUXm3bYT+PKkc +j5IX7JJDC6ECQb40mpXhlhukh/87ODrZqZymTchJWt7iF0SNhL4+oDgNbuTIVyAlz5A0zC7xsm i8libwVi6nHReNJA8sM4VWYqoYnhs+fe0WifpQo= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.399800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24504.003 X-MDID: 1553275881-g8S6NhKIIJnw Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322173104.1_w-JMv90TzDOE4W49-Dvz7TSaiaTNMmu1_Ieep4n7Q@z> On 22.03.2019 20:23, David Marchand wrote: > > > On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin > > wrote: > > > > On 3/22/19 2:37 PM, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same > line gives a > > really long line and is not consistent with the rest. > > > > Before: > >    RX-packets: 3542977        TX-packets: 3542971   TX-dropped: > 6               RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts > + 61% of others] > >    TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > > > After: > >    RX-packets: 4629969        TX-packets: 4629969   TX-dropped: 0 > >    RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of > others] > >    TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of > others] > > > > Fixes: af75078fece3 ("first public release") > > Cc:stable@dpdk.org > > While the patch is good, I wonder whether we should backport it. > Indeed, it might break some scripts parsing testpmd output. > > Any thoughts? > > > It seems unlikely, this feature is disabled by default. > But yes, I would avoid backporting it. For me it looks like a bug. That's why I think it should be backported, but the fix is not 100% correct in fact. I'll reply directly to the patch.