From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E0663A00E6 for ; Fri, 22 Mar 2019 18:35:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B1E561B6F7; Fri, 22 Mar 2019 18:35:21 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 114FD1B6F1; Fri, 22 Mar 2019 18:35:20 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 702E21C00AA; Fri, 22 Mar 2019 17:35:18 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Mar 2019 17:35:11 +0000 To: David Marchand , CC: , , , , , References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> Date: Fri, 22 Mar 2019 20:35:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553261824-1881-2-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24504.003 X-TM-AS-Result: No-7.739900-8.000000-10 X-TMASE-MatchedRID: HXSqh3WYKft2LasmHuCXMSa1MaKuob8PC/ExpXrHizyzrjcceM7LC7p6 uNXZtNFnGiHcq0WQFE4tXweg2cv0t9LDec/x7CA8Z1f+XQd5zc+nEB3qaLUZrZiQXtm0V8JTU7g EPucszGcRwT4s6Iq4i3KsYzfPDOYbSLYOuP0pddeRVQzJVQpFnlo1rFkFFs1alb8qVXrNjEWIzF HbW/M9+ZWPxGVBtRjfGadTKAE6HgUPRVepDWIjx54CIKY/Hg3AtOt1ofVlaoJlgn288nW9INhLm avc54GnjaPj0W1qn0SujVRFkkVsmz1WhccJWk2nqiyj5TxNrvdaLIOQJfxrfWsbNopfemSZ84PI 9k7F1HQWps0JEhsl3fC12ZWEWRhddhIp4JLWxBn2c3zJZSYUgYVyAlz5A0zC7xsmi8libwVi6nH ReNJA8sM4VWYqoYnhs+fe0WifpQo= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.739900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24504.003 X-MDID: 1553276119-H3fxWic8V9W4 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322173504.pKFykNbiQVWY_SCq5CHGV2Azqk2rFcv6FOVAAri0QsQ@z> On 22.03.2019 16:37, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > After: > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Rami Rosen > Reviewed-by: Andrew Rybchenko > --- > Changelog since v2: > - Cc'd stable > > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 216be47..40199c1 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1459,7 +1459,7 @@ struct extmem_param { > "TX Port=%2d/Queue=%2d %s\n", > fwd_top_stats_border, fs->rx_port, fs->rx_queue, > fs->tx_port, fs->tx_queue, fwd_top_stats_border); > - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", > + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", > fs->rx_packets, fs->tx_packets, fs->fwd_dropped); > > /* if checksum mode */ In fact bad Rx checksum counters follow and I think they should be in this line. That's why there is no \n here from the very beginning. My fix for the bug (local) just add \n in else branch below. Andrew.