From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 36973A00E6 for ; Fri, 22 Mar 2019 18:37:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B8881B722; Fri, 22 Mar 2019 18:37:26 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DA06D1B70D for ; Fri, 22 Mar 2019 18:37:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 10:37:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="127776074" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga008.jf.intel.com with ESMTP; 22 Mar 2019 10:37:21 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.210]) by IRSMSX102.ger.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0415.000; Fri, 22 Mar 2019 17:37:20 +0000 From: "Ananyev, Konstantin" To: "Wiles, Keith" CC: dpdk-dev , "akhil.goyal@nxp.com" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value Thread-Index: AQHU30XE5sYvurJxuU2n/aJCf0kBGqYX6ykg Date: Fri, 22 Mar 2019 17:37:19 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258013655EDD0@irsmsx105.ger.corp.intel.com> References: <1551381661-21078-1-git-send-email-konstantin.ananyev@intel.com> <1553102679-23576-2-git-send-email-konstantin.ananyev@intel.com> <96B7DD3D-3016-4C23-9BB0-DFB1F16B07A9@intel.com> In-Reply-To: <96B7DD3D-3016-4C23-9BB0-DFB1F16B07A9@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmJlZmUwMmEtOGFiMi00NDRlLWE3MjItMjgyMzYyMmIwMjFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia1wvT1wvWFM4dDY0RWxscUpcL0k2VVlLOWhZYWNlN3hza2l5MkdFZzI1QjJMaG9qbFhnaUVzZGZKMk9zTU4wUTg4NiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322173719.XytvxFDvGCuoHFVNTibXs3MNhlCD_T9M7vwwT_DOnC0@z> > -----Original Message----- > From: Wiles, Keith > Sent: Wednesday, March 20, 2019 5:53 PM > To: Ananyev, Konstantin > Cc: dpdk-dev ; akhil.goyal@nxp.com; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw= Tx offload value >=20 >=20 >=20 > > On Mar 20, 2019, at 10:24 AM, Konstantin Ananyev wrote: > > > > Operations to set/update bit-fields often cause compilers > > to generate suboptimal code. > > To help avoid such situation for tx_offload fields: > > introduce new enum for tx_offload bit-fields lengths and offsets, > > and new function to generate raw tx_offload value. > > > > Signed-off-by: Konstantin Ananyev > > --- > > lib/librte_mbuf/rte_mbuf.h | 71 ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 64 insertions(+), 7 deletions(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index d961ccaf6..b967ad17e 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -479,6 +479,26 @@ struct rte_mbuf_sched { > > uint16_t reserved; /**< Reserved. */ > > }; /**< Hierarchical scheduler */ > > > > +/** enum for the tx_offload bit-fields lenghts and offsets. */ > > +enum { > > + RTE_MBUF_L2_LEN_BITS =3D 7, > > + RTE_MBUF_L3_LEN_BITS =3D 9, > > + RTE_MBUF_L4_LEN_BITS =3D 8, > > + RTE_MBUF_TSO_SEGSZ_BITS =3D 16, > > + RTE_MBUF_OL3_LEN_BITS =3D 9, > > + RTE_MBUF_OL2_LEN_BITS =3D 7, > > + RTE_MBUF_L2_LEN_OFS =3D 0, > > + RTE_MBUF_L3_LEN_OFS =3D RTE_MBUF_L2_LEN_OFS + RTE_MBUF_L2_LEN_BITS, > > + RTE_MBUF_L4_LEN_OFS =3D RTE_MBUF_L3_LEN_OFS + RTE_MBUF_L3_LEN_BITS, > > + RTE_MBUF_TSO_SEGSZ_OFS =3D RTE_MBUF_L4_LEN_OFS + RTE_MBUF_L4_LEN_BITS= , > > + RTE_MBUF_OL3_LEN_OFS =3D RTE_MBUF_TSO_SEGSZ_OFS + RTE_MBUF_TSO_SEGSZ_= BITS, > > + RTE_MBUF_OL2_LEN_OFS =3D RTE_MBUF_OL3_LEN_OFS + RTE_MBUF_OL3_LEN_BITS= , > > + RTE_MBUF_TXOFLD_UNUSED_OFS =3D > > + RTE_MBUF_OL2_LEN_OFS + RTE_MBUF_OL2_LEN_BITS, > > + RTE_MBUF_TXOFLD_UNUSED_BITS =3D > > + sizeof(uint64_t) * CHAR_BIT - RTE_MBUF_TXOFLD_UNUSED_OFS, > > +}; >=20 > The naming of these fields is a bit unreadable and why do we need to add = RTE_MBUF_ to everything especially adding RTE_ to everything. It is part of public API, so I think we'll have to follow DPDK naming conve= ntion here. =20 > Then we have to shorten words like OFFSET to OFS, it would be much better= for readability to use something like this >=20 > RTE_MBUF_OL3_LEN_OFS to MBUF_OL3_LEN_OFFSET, then we have OL3 or OL2, whi= ch does not jump out at me as well. > What does OL3 or OL2 mean? OffLoad-3 or OffLoad-2 this also needs to be c= learly defined to improve the readability of the macros. outer_l3_len, outer_l2_len. These enum values follows tx_offload bit-fields definitions - see below. > Also for TXOFLD needs to be clearer here to help the reader understand th= e mean of the defines. >=20 >=20 > > + > > /** > > * The generic rte_mbuf, containing a packet mbuf. > > */ > > @@ -640,19 +660,24 @@ struct rte_mbuf { > > uint64_t tx_offload; /**< combined for easy fetch */ > > __extension__ > > struct { > > - uint64_t l2_len:7; > > + uint64_t l2_len:RTE_MBUF_L2_LEN_BITS; > > /**< L2 (MAC) Header Length for non-tunneling pkt. > > * Outer_L4_len + ... + Inner_L2_len for tunneling pkt. > > */ > > - uint64_t l3_len:9; /**< L3 (IP) Header Length. */ > > - uint64_t l4_len:8; /**< L4 (TCP/UDP) Header Length. */ > > - uint64_t tso_segsz:16; /**< TCP TSO segment size */ > > + uint64_t l3_len:RTE_MBUF_L3_LEN_BITS; > > + /**< L3 (IP) Header Length. */ > > + uint64_t l4_len:RTE_MBUF_L4_LEN_BITS; > > + /**< L4 (TCP/UDP) Header Length. */ > > + uint64_t tso_segsz:RTE_MBUF_TSO_SEGSZ_BITS; > > + /**< TCP TSO segment size */ > > > > /* fields for TX offloading of tunnels */ > > - uint64_t outer_l3_len:9; /**< Outer L3 (IP) Hdr Length. */ > > - uint64_t outer_l2_len:7; /**< Outer L2 (MAC) Hdr Length. */ > > + uint64_t outer_l3_len:RTE_MBUF_OL3_LEN_BITS; > > + /**< Outer L3 (IP) Hdr Length. */ > > + uint64_t outer_l2_len:RTE_MBUF_OL2_LEN_BITS; > > + /**< Outer L2 (MAC) Hdr Length. */ > > > > - /* uint64_t unused:8; */ > > + /* uint64_t unused:RTE_MBUF_TXOFLD_UNUSED_BITS; */ > > }; > > }; > > > > @@ -2243,6 +2268,38 @@ static inline int rte_pktmbuf_chain(struct rte_m= buf *head, struct rte_mbuf *tail > > return 0; > > } > > > > +/* > > + * @warning > > + * @b EXPERIMENTAL: This API may change without prior notice. > > + * > > + * For given input values generate raw tx_offload value. > > + * @param il2 > > + * l2_len value. > > + * @param il3 > > + * l3_len value. > > + * @param il4 > > + * l4_len value. > > + * @param tso > > + * tso_segsz value. > > + * @param ol3 > > + * outer_l3_len value. > > + * @param ol2 > > + * outer_l2_len value. > > + * @return > > + * raw tx_offload value. > > + */ > > +static inline uint64_t > > +rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t= tso, > > + uint64_t ol3, uint64_t ol2) > > +{ > > + return il2 << RTE_MBUF_L2_LEN_OFS | > > + il3 << RTE_MBUF_L3_LEN_OFS | > > + il4 << RTE_MBUF_L4_LEN_OFS | > > + tso << RTE_MBUF_TSO_SEGSZ_OFS | > > + ol3 << RTE_MBUF_OL3_LEN_OFS | > > + ol2 << RTE_MBUF_OL2_LEN_OFS; > > +} > > + > > /** > > * Validate general requirements for Tx offload in mbuf. > > * > > -- > > 2.17.1 > > >=20 > Regards, > Keith