From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 655971B765 for ; Sat, 23 Mar 2019 00:24:20 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 16:24:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="133978880" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga008.fm.intel.com with ESMTP; 22 Mar 2019 16:24:18 -0700 Date: Sat, 23 Mar 2019 07:20:10 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322232010.GC15995@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321082822.2660e913@shemminger-XPS-13-9360> <20190322021523.GH84243@intel.com> <20190322083838.1da3e00e@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322083838.1da3e00e@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 23:24:20 -0000 On 03/22, Stephen Hemminger wrote: >On Fri, 22 Mar 2019 10:15:23 +0800 >Ye Xiaolong wrote: > >> On 03/21, Stephen Hemminger wrote: >> >On Thu, 21 Mar 2019 17:18:41 +0800 >> >Xiaolong Ye wrote: >> > >> >> + if (ret != 0) { >> >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed for XDP_STATISTICS.\n"); >> >> + return -1; >> > >> >You need to use the new dynamic log types and not have a global logtype. >> >> You mean for all the logs in this driver, right? Is it due to the global logtype >> will be deprecated? > >Global log types should not be used or added by any new code. Got it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 62AC8A00E6 for ; Sat, 23 Mar 2019 00:24:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 154811B76D; Sat, 23 Mar 2019 00:24:22 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 655971B765 for ; Sat, 23 Mar 2019 00:24:20 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2019 16:24:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="133978880" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga008.fm.intel.com with ESMTP; 22 Mar 2019 16:24:18 -0700 Date: Sat, 23 Mar 2019 07:20:10 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190322232010.GC15995@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190321091845.78495-1-xiaolong.ye@intel.com> <20190321091845.78495-2-xiaolong.ye@intel.com> <20190321082822.2660e913@shemminger-XPS-13-9360> <20190322021523.GH84243@intel.com> <20190322083838.1da3e00e@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190322083838.1da3e00e@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322232010.wrBFYElHz87-Oo89_XkDU22KfOFWKPLhF_oOa6Gba-0@z> On 03/22, Stephen Hemminger wrote: >On Fri, 22 Mar 2019 10:15:23 +0800 >Ye Xiaolong wrote: > >> On 03/21, Stephen Hemminger wrote: >> >On Thu, 21 Mar 2019 17:18:41 +0800 >> >Xiaolong Ye wrote: >> > >> >> + if (ret != 0) { >> >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed for XDP_STATISTICS.\n"); >> >> + return -1; >> > >> >You need to use the new dynamic log types and not have a global logtype. >> >> You mean for all the logs in this driver, right? Is it due to the global logtype >> will be deprecated? > >Global log types should not be used or added by any new code. Got it.