Re: [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx SSE vector

["Lu, Wenzhuo" <wenzhuo.lu@intel.com>]

Hi Maxime,


> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, March 22, 2019 5:59 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx SSE vector
> 


> > +
> > +static __rte_always_inline void
> > +tx_backlog_entry(struct ice_tx_entry *txep,
> Consider prefixing it with 'ice_tx_'.
Thanks. Will change it.

> > +static inline void
> > +_ice_tx_queue_release_mbufs_vec(struct ice_tx_queue *txq) {
> > +	uint16_t i;
> > +
> > +	if (!txq || !txq->sw_ring) {
> 
> if (unlikely(...)) {
> 
> > +		PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL");
> 
> s/rxq/txq/
Thanks. Will change it.

> >
> > +static inline int
> > +ice_tx_vec_dev_check_default(struct rte_eth_dev *dev) {
> > +	int i;
> > +	struct ice_tx_queue *txq;
> > +
> > +	for (i = 0; i < dev->data->nb_tx_queues; i++) {
> > +		txq = dev->data->tx_queues[i];
> > +		if (ice_tx_vec_queue_default(txq))
> > +			return -1;
> 
> return ice_tx_vec_queue_default(txq);
> 
> Applies also to rx path.
Thanks. Will change it.


> >
> > +static void __attribute__((cold))
> > +ice_tx_queue_release_mbufs_vec(struct ice_tx_queue *txq) {
> > +	_ice_tx_queue_release_mbufs_vec(txq);
> 
> As for Rx, consider putting the code firectly here as
> _ice_tx_queue_release_mbufs_vec() is called only once here.
Like RX path, to our experience, it most probably can be reused by other platform.