From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 9DE972BD3 for ; Mon, 25 Mar 2019 16:58:19 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id k3so3096372pga.6 for ; Mon, 25 Mar 2019 08:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l+KDtm71+l7tuRcknKHschk8xoH/dbo8b43SBqAtrPU=; b=VuElVgVjmSrFnz61eHXo/5siU8GeE9GCBtX4fGlntHuRY+1teZGAy//KAjUBvh05OK 0iMcKMtbs30+kDw2LElGg9IE4iNoJyY+/UWGhOEhozVTv3dTBiNizIbLn4+g4C7KeXTg fxe0M6baT54vu3Bv0FfX50NZ7AeLwerwlIKEkkDESzFhKIeTt6fFr8HNOX46N34XSInB UzsMsZ04Ymy9FuihUU2hNfoMEu9OmBJv/3ZLhcCcsmsvQwie+fm0aU/KhE3M7f8n8XMb t9nWc8217+wlNQ1Du60R/JrnpWpGDed23xDQgE3PrLOvaEhVz2zTmI16Oz71B+60QCDw hLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l+KDtm71+l7tuRcknKHschk8xoH/dbo8b43SBqAtrPU=; b=BWm+owrHKNFWtWlb2niIbP92XK9heQgLRolwzJj59/1MPeBOalrXKbKONULLpeYudN 1BmMJ9X9dciGl7s9HswG6PKau20Vpa0a7CaGEE/5uIuxR14TvT19N8XOaX6y4djjx7LO d2tnU9sQN+ZytCouxvpO8vIdBm+C8iVzhcuJXUgXwim3MGuuDZdp9r4MJDB2qjb0tcXu 8YMQyCCt08IfhbNsKcwenAqWoTnvol0m+9vuD/aj2X73Mu/ww3ejJZyVPgZFF8nvZtS9 2NZMPUcsSdjRcJj+ufiklDJ0SSC0txDFcgTDTKo4P51P7URARKHn3sQ/qnb/h4qK8cSN RqxQ== X-Gm-Message-State: APjAAAVXR/phNj33EDDZmT6q5bVVLIvU4gC+e0W8y52Ix6/K/3kPZtqz l5ylKL7rvlQMGfj4BIlja4+dVA== X-Google-Smtp-Source: APXvYqxEcBlYULrnvyxJ4+lJ/AHgate3//IC13tXJMtVyrRWX2PlW+SCpCbWpsqG5Km0giCf4jfXXQ== X-Received: by 2002:a63:f80f:: with SMTP id n15mr24027150pgh.283.1553529498800; Mon, 25 Mar 2019 08:58:18 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c2sm31325969pfm.187.2019.03.25.08.58.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 08:58:18 -0700 (PDT) Date: Mon, 25 Mar 2019 08:58:14 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, David Marchand , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Ferruh Yigit , Luca Boccassi , Bruce Richardson , Ananyev Konstantin Message-ID: <20190325085814.1cca7845@shemminger-XPS-13-9360> In-Reply-To: <20190325060400.40291-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190325060400.40291-1-xiaolong.ye@intel.com> <20190325060400.40291-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 15:58:19 -0000 On Mon, 25 Mar 2019 14:03:56 +0800 Xiaolong Ye wrote: > + > + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); > + if (unlikely(!ret)) { > + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); You defined AF_XDP_LOG to add a newline (similar to other drivers). But all the messages already have a newline. This will cause log to be double spaced. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E6FD9A05D3 for ; Mon, 25 Mar 2019 16:58:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6AFD2BF4; Mon, 25 Mar 2019 16:58:20 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 9DE972BD3 for ; Mon, 25 Mar 2019 16:58:19 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id k3so3096372pga.6 for ; Mon, 25 Mar 2019 08:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l+KDtm71+l7tuRcknKHschk8xoH/dbo8b43SBqAtrPU=; b=VuElVgVjmSrFnz61eHXo/5siU8GeE9GCBtX4fGlntHuRY+1teZGAy//KAjUBvh05OK 0iMcKMtbs30+kDw2LElGg9IE4iNoJyY+/UWGhOEhozVTv3dTBiNizIbLn4+g4C7KeXTg fxe0M6baT54vu3Bv0FfX50NZ7AeLwerwlIKEkkDESzFhKIeTt6fFr8HNOX46N34XSInB UzsMsZ04Ymy9FuihUU2hNfoMEu9OmBJv/3ZLhcCcsmsvQwie+fm0aU/KhE3M7f8n8XMb t9nWc8217+wlNQ1Du60R/JrnpWpGDed23xDQgE3PrLOvaEhVz2zTmI16Oz71B+60QCDw hLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l+KDtm71+l7tuRcknKHschk8xoH/dbo8b43SBqAtrPU=; b=BWm+owrHKNFWtWlb2niIbP92XK9heQgLRolwzJj59/1MPeBOalrXKbKONULLpeYudN 1BmMJ9X9dciGl7s9HswG6PKau20Vpa0a7CaGEE/5uIuxR14TvT19N8XOaX6y4djjx7LO d2tnU9sQN+ZytCouxvpO8vIdBm+C8iVzhcuJXUgXwim3MGuuDZdp9r4MJDB2qjb0tcXu 8YMQyCCt08IfhbNsKcwenAqWoTnvol0m+9vuD/aj2X73Mu/ww3ejJZyVPgZFF8nvZtS9 2NZMPUcsSdjRcJj+ufiklDJ0SSC0txDFcgTDTKo4P51P7URARKHn3sQ/qnb/h4qK8cSN RqxQ== X-Gm-Message-State: APjAAAVXR/phNj33EDDZmT6q5bVVLIvU4gC+e0W8y52Ix6/K/3kPZtqz l5ylKL7rvlQMGfj4BIlja4+dVA== X-Google-Smtp-Source: APXvYqxEcBlYULrnvyxJ4+lJ/AHgate3//IC13tXJMtVyrRWX2PlW+SCpCbWpsqG5Km0giCf4jfXXQ== X-Received: by 2002:a63:f80f:: with SMTP id n15mr24027150pgh.283.1553529498800; Mon, 25 Mar 2019 08:58:18 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c2sm31325969pfm.187.2019.03.25.08.58.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2019 08:58:18 -0700 (PDT) Date: Mon, 25 Mar 2019 08:58:14 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: dev@dpdk.org, David Marchand , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Ferruh Yigit , Luca Boccassi , Bruce Richardson , Ananyev Konstantin Message-ID: <20190325085814.1cca7845@shemminger-XPS-13-9360> In-Reply-To: <20190325060400.40291-2-xiaolong.ye@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190325060400.40291-1-xiaolong.ye@intel.com> <20190325060400.40291-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190325155814.ugUoaFM3r09QAn7P-D6YxOeJnnWY2QCt2QEqwScv1Lg@z> On Mon, 25 Mar 2019 14:03:56 +0800 Xiaolong Ye wrote: > + > + ret = xsk_ring_prod__reserve(fq, reserve_size, &idx); > + if (unlikely(!ret)) { > + AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n"); You defined AF_XDP_LOG to add a newline (similar to other drivers). But all the messages already have a newline. This will cause log to be double spaced.