From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 23926A05D3 for ; Tue, 26 Mar 2019 10:24:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B97A3195; Tue, 26 Mar 2019 10:24:13 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by dpdk.org (Postfix) with ESMTP id 444012C60 for ; Tue, 26 Mar 2019 10:24:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tVqoJMH7ZxAWdRfhbWqImq3Cw4x08hrd9U2QOUOaAd8=; b=YdeujIfKRjTjWqvvwgSNxpI5TOt10YBwmOXOlN+pmoV4zL8W9soG/fN8brc1LKE2OLKdrw6wjb94WZMfwkRdpKa/lW7qpMkYJSruZxDEQu6dlsoWdtRCaqDvD4dtFytLSAG3E2DA9loFIX8lZz2H9CBEO5PcvtddPUfS+ML9qBU= Received: from VI1PR05MB4224.eurprd05.prod.outlook.com (52.133.12.13) by VI1PR05MB5759.eurprd05.prod.outlook.com (20.178.122.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Tue, 26 Mar 2019 09:24:10 +0000 Received: from VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::bcb0:ed58:d76:cac]) by VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::bcb0:ed58:d76:cac%4]) with mapi id 15.20.1730.019; Tue, 26 Mar 2019 09:24:10 +0000 From: Dekel Peled To: Adrien Mazarguil CC: "dev@dpdk.org" , Ori Kam , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Shahaf Shuler , Yongseok Koh , Olga Shern Thread-Topic: [PATCH 1/3] ethdev: add actions to modify TCP header fields Thread-Index: AQHU3/FKRE77gvlxWk+bdOA5g+04ZKYdqeEg Date: Tue, 26 Mar 2019 09:24:10 +0000 Message-ID: References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com> <1553177917-43297-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1553177917-43297-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a15fb0ee-30bc-4ce7-996b-08d6b1ccce1c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB5759; x-ms-traffictypediagnostic: VI1PR05MB5759: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 09888BC01D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(396003)(39860400002)(346002)(376002)(13464003)(189003)(199004)(6506007)(5660300002)(105586002)(106356001)(26005)(107886003)(33656002)(6246003)(316002)(52536014)(54906003)(8676002)(81166006)(81156014)(8936002)(68736007)(305945005)(7736002)(7696005)(478600001)(66066001)(4326008)(102836004)(99286004)(186003)(446003)(2906002)(55016002)(86362001)(11346002)(6916009)(486006)(74316002)(53936002)(6116002)(3846002)(6436002)(97736004)(256004)(14454004)(53546011)(76176011)(476003)(9686003)(25786009)(71200400001)(71190400001)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB5759; H:VI1PR05MB4224.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6iCtJ+tbrT/alzHGds/4HVQRMdtI7bnFwvBwZcCjw8r94PcVzRvjhQwyv2kT3N9nW/g8pxGs0GvgO483LEnYoZNfx8IgNnGG12+lzhpVOsrF4OdCsYGDNPS/fGEZDzTS9ipzkAftDSGP75UsgAMEb4JNKTUPnjAjUl3O5THAkfxqh9ljzoydwM2/l2PAqwWvsXznzhKxl+K7v75ZNXvWTlt/oA7w362lG9iBqLjh6SwHW2yhxs2G8Gp2d97jBRyVt72T/+BxNY9q1I9ojprzZljImpn/1Z1mEuYBXmpwyg3+Xs0tOSsZkhvMDMQBik6WUHvJJ3x5ZkHwjjpShXqRfANP2/VWTzdFlNkZwZ1MfRzW8hhP2YYJlGsvsPljREC1Bjt0eO6UBxyQr4nbqegd1cOc0HH1I2ihbPs1oDnQQWU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a15fb0ee-30bc-4ce7-996b-08d6b1ccce1c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 09:24:10.6937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5759 Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326092410.YQ08fs7KMFdG8Tx84xbm5DvOKMapvdUlbZqx5rQ9msE@z> Hi Adrien,=20 Can you please review? I'll appreciate receiving any comments soon. Thanks, Dekel > -----Original Message----- > From: Dekel Peled > Sent: Thursday, March 21, 2019 4:19 PM > To: Adrien Mazarguil ; > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; Yongseok Koh ; > Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [PATCH 1/3] ethdev: add actions to modify TCP header fields >=20 > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP > header. > - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP > header. >=20 > Original work by Xiaoyu Min. >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 72 > ++++++++++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_flow.c | 8 +++++ > lib/librte_ethdev/rte_flow.h | 60 > +++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 0203f4f..bdb817a 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION > error will be returned. > | ``mac_addr`` | MAC address | > +--------------+---------------+ >=20 > +Action: ``INC_TCP_SEQ`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Increase sequence number in the outermost TCP header. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > + > +.. _table_rte_flow_action_inc_tcp_seq: > + > +.. table:: INC_TCP_SEQ > + > + +-----------+--------------------------------------------+ > + | Field | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to increase TCP sequence number by | > + +-----------+--------------------------------------------+ > + > +Action: ``DEC_TCP_SEQ`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Decrease sequence number in the outermost TCP header. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > + > +.. _table_rte_flow_action_dec_tcp_seq: > + > +.. table:: DEC_TCP_SEQ > + > + +-----------+--------------------------------------------+ > + | Field | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to decrease TCP sequence number by | > + +-----------+--------------------------------------------+ > + > +Action: ``INC_TCP_ACK`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Increase acknowledgment number in the outermost TCP header. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > + > +.. _table_rte_flow_action_inc_tcp_ack: > + > +.. table:: INC_TCP_ACK > + > + +-----------+--------------------------------------------------+ > + | Field | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D+ > + | ``value`` | Value to increase TCP acknowledgment number by | > + +-----------+--------------------------------------------------+ > + > +Action: ``DEC_TCP_ACK`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Decrease acknowledgment number in the outermost TCP header. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > + > +.. _table_rte_flow_action_dec_tcp_ack: > + > +.. table:: DEC_TCP_ACK > + > + +-----------+--------------------------------------------------+ > + | Field | Value | > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D+ > + | ``value`` | Value to decrease TCP acknowledgment number by | > + +-----------+--------------------------------------------------+ > + > Negative types > ~~~~~~~~~~~~~~ >=20 > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c = index > 3277be1..589d0b9 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -143,6 +143,14 @@ struct rte_flow_desc_data { > MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)), > MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct > rte_flow_action_set_mac)), > MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct > rte_flow_action_set_mac)), > + MK_FLOW_ACTION(INC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + MK_FLOW_ACTION(DEC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + MK_FLOW_ACTION(INC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > + MK_FLOW_ACTION(DEC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > }; >=20 > static int > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h = index > c0fe879..74cd03e 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1651,6 +1651,46 @@ enum rte_flow_action_type { > * See struct rte_flow_action_set_mac. > */ > RTE_FLOW_ACTION_TYPE_SET_MAC_DST, > + > + /** > + * Increase sequence number in the outermost TCP header. > + * > + * If flow pattern does not define a valid > RTE_FLOW_ITEM_TYPE_TCP, > + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error. > + * > + * See struct rte_flow_action_modify_tcp_seq > + */ > + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ, > + > + /** > + * Decrease sequence number in the outermost TCP header. > + * > + * If flow pattern does not define a valid > RTE_FLOW_ITEM_TYPE_TCP, > + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error. > + * > + * See struct rte_flow_action_modify_tcp_seq > + */ > + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ, > + > + /** > + * Increase acknowledgment number in the outermost TCP header. > + * > + * If flow pattern does not define a valid > RTE_FLOW_ITEM_TYPE_TCP, > + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error. > + * > + * See struct rte_flow_action_modify_tcp_ack > + */ > + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK, > + > + /** > + * Decrease acknowledgment number in the outermost TCP header. > + * > + * If flow pattern does not define a valid > RTE_FLOW_ITEM_TYPE_TCP, > + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error. > + * > + * See struct rte_flow_action_modify_tcp_ack > + */ > + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK, > }; >=20 > /** > @@ -2122,6 +2162,26 @@ struct rte_flow_action_set_mac { > uint8_t mac_addr[ETHER_ADDR_LEN]; > }; >=20 > +/** > + * RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > + * RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > + * > + * Increase/Decrease outermost TCP's sequence number */ struct > +rte_flow_action_modify_tcp_seq { > + rte_be32_t value; > +}; > + > +/** > + * RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > + * RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > + * > + * Increase/Decrease TCP's acknowledgment number. > + */ > +struct rte_flow_action_modify_tcp_ack { > + rte_be32_t value; > +}; > + > /* > * Definition of a single action. > * > -- > 1.8.3.1