From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4533AA05D3 for ; Tue, 26 Mar 2019 13:08:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 556762C60; Tue, 26 Mar 2019 13:08:11 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E2EC52C28 for ; Tue, 26 Mar 2019 13:08:09 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2QC08vt006381; Tue, 26 Mar 2019 05:08:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=chS0bDB0vJBZidGW+Hali/mASRB0ZoZuLZ7M9dkVmq0=; b=gxMfZvbLmPxa/+NpnoJG0xizIrCgE3627SRRfbeI+ariwGvL1NtQhch8dKMihG9qSsJX DKb1Nk1FPD5tUsgmEM3Eu3zy4xPGZzO5050aQS/wbtW8VUWeuVefY7J8EcC36wjJH2Py Z9RPqcXxQ5odcTM/ABQLl32IKMqYjZNzS+aSTQICs+UTjqExY573tNSydvzPWLPicunv ZZR4P9Nfw4zSPKg3GaMUFjFs7ICc/qp1hyKkOSxq+wSW/YP/60jRYIGeOE3a8iH93aau q37X2bjENgfOkDlO9lHJR9JGUcUL0fpeV/YLvz9ENSYqYPOf8Jr/xZgWZ6bIsn6YYG1J CQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2rfhk90c12-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2019 05:08:08 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 26 Mar 2019 05:06:18 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 26 Mar 2019 05:06:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chS0bDB0vJBZidGW+Hali/mASRB0ZoZuLZ7M9dkVmq0=; b=fi9D3I3DiKmhelBfRnxC+nrcgPJ7yyTrUE88ROEhOzr5wKFxf9d1simEdrAX/jd6FYI4jKJbLNp5OSKZ2jwj8p+ii8G5lqFSbVoh0pToxVEhZ+CtZX1HqyYvoNcJlLri5BT7SKsqpMA62fbHyjndrdvP3/9Lj+cmVFQU+PvhFEk= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB2005.namprd18.prod.outlook.com (10.171.255.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Tue, 26 Mar 2019 12:06:16 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa%2]) with mapi id 15.20.1750.014; Tue, 26 Mar 2019 12:06:16 +0000 From: Pavan Nikhilesh Bhagavatula To: "Iremonger, Bernard" , Thomas Monjalon CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "arybchenko@solarflare.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode Thread-Index: AQHU48oj9yBsSePc7kKY1138hj+IaKYdz9hg Date: Tue, 26 Mar 2019 12:06:16 +0000 Message-ID: References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190301134700.8220-1-pbhagavatula@marvell.com> <4933257.X50ECdZ2iI@xps> <8CEF83825BEC744B83065625E567D7C260D7656E@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D7656E@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [183.82.23.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fea48306-3888-4d6a-11e8-08d6b1e3733e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR1801MB2005; x-ms-traffictypediagnostic: CY4PR1801MB2005: x-microsoft-antispam-prvs: x-forefront-prvs: 09888BC01D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39860400002)(136003)(346002)(396003)(13464003)(199004)(189003)(7736002)(99286004)(305945005)(446003)(256004)(486006)(74316002)(33656002)(81166006)(105586002)(14454004)(8936002)(78486014)(52536014)(97736004)(106356001)(93886005)(8676002)(11346002)(14444005)(54906003)(110136005)(25786009)(476003)(71190400001)(186003)(6116002)(3846002)(71200400001)(478600001)(68736007)(316002)(6436002)(6506007)(53546011)(4326008)(53936002)(81156014)(102836004)(86362001)(26005)(5660300002)(7696005)(2906002)(66066001)(229853002)(6246003)(9686003)(55016002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2005; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s+nbw1aw4eXB/DwdJVw/bmTOZLpGFCF+tcbkSZxxt5FkwpR9YP2eG4NNdw84sDVQQ59juZZgW6n3TUXhvUEwbibADfZzxJT3rDaDM6TZUEUWrVquUIBx8LXKX4AKrWB+3sJWu+fd+Rs6fPGtFKGtYAImu7NbHDl+umsFC/XQuRl/iD3vE6nM9GMgFL6XcP5ggDZbi5i64WQpM2tL2Kq6FC3sYNqHfI0XTFwUnav8iplPkoqRnTXusImCQAhnq9au4+4WGRsmw2ObgmYrUPcubGkDG1IZDG7x3AxisE5fnCCm60mpdcXtH/kHs8Ld42JlwiTc/PNLBWaa9CK7/aWfc6l8md35RVHKCbZyJfD3yoGHikyY1ZcSuicW4JPh0fU0AbMWaZXBA31Xd3TnUYb6a4xsC2cZmwTkL0948qVGqj0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fea48306-3888-4d6a-11e8-08d6b1e3733e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 12:06:16.7283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2005 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-26_08:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326120616.j0DJwQZuW9qE8mbKxhErQk6WKWms2aXQTZBJuD0cCXo@z> > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, March 26, 2019 5:20 PM > To: Thomas Monjalon ; Pavan Nikhilesh > Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > arybchenko@solarflare.com; Yigit, Ferruh > Subject: [EXT] RE: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk > get for txonly mode >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Pavan, >=20 > >=20 > > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get > > for txonly mode > > > > 01/03/2019 14:47, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh > > > > > > Use mempool bulk get ops to alloc burst of packets and process them. > > > If bulk get fails fallback to rte_mbuf_raw_alloc. > > > > > > Suggested-by: Andrew Rybchenko > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > > > > v2 Changes: > > > - Use bulk ops for fetching segments. (Andrew Rybchenko) > > > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew > > > Rybchenko) > > > - Fix mbufs not being freed when there is no more mbufs available > > > for segments. (Andrew Rybchenko) > > > > > > app/test-pmd/txonly.c | 159 > > > ++++++++++++++++++++++++------------------ > > > 1 file changed, 93 insertions(+), 66 deletions(-) > > > > This is changing a lot of lines so it is difficult to know what is chan= ged > exactly. > > Please split it with a refactoring without any real change, and > > introduce the real change later. Ok will split in the next version. > > Then we'll be able to examine it and check the performance. > > > > We need to have more tests with more hardware in order to better > > understand the performance improvement. > > For info, a degradation is seen in Mellanox lab. The only real change was that we introduced mempool_bulk get to avoid multi= ple calls to mempool layer.=20 I don't see how that would degrade the performance. > > > > > +1 > Not easy to review. > Btw, unnecessary change at lines 157 and 158 in txonly.c Will remove the assignments. >=20 > Regards, >=20 > Bernard