From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F1B2DA05D3 for ; Tue, 26 Mar 2019 13:16:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9D193195; Tue, 26 Mar 2019 13:16:53 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ECE6E2C60 for ; Tue, 26 Mar 2019 13:16:51 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 05:16:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="145335881" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2019 05:16:49 -0700 Date: Tue, 26 Mar 2019 20:12:28 +0800 From: Ye Xiaolong To: Luca Boccassi Cc: dev@dpdk.org, Qi Zhang , "Karlsson, Magnus" Message-ID: <20190326121228.GA58093@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190301080947.91086-2-xiaolong.ye@intel.com> <20190302081407.GD100586@intel.com> <20190317033425.GA103486@intel.com> <1553429237.20876.3.camel@debian.org> <20190325024559.GB35864@intel.com> <20190326021812.GB48057@intel.com> <9b875fc3d5597cd8e793a8ac7b40a8b7efad6e74.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <9b875fc3d5597cd8e793a8ac7b40a8b7efad6e74.camel@debian.org> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326121228.HosNpkVxyB-gD1fU-1BOuAaNwkiamcTS9nSQXsUMTIk@z> On 03/26, Luca Boccassi wrote: >On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote: >> On 03/25, Luca Boccassi wrote: >> > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> > > On 03/24, Luca Boccassi wrote: >> > > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > > > On 03/02, Ye Xiaolong wrote: >> > > > > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += >> > > > > > > > -lrte_pmd_af_packet >> > > > > > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += >> > > > > > > > -lrte_pmd_af_xdp >> > > > > > > > -lelf -lbpf >> > > > > > > >> > > > > > > Are symbols from libelf being used by the PMD? >> > > > > > >> > > > > > Hmm, it is a leftover of RFC, libelf is no longer needed in >> > > > > > this >> > > > > > version, will >> > > > > > remove it in next version. >> > > > > > >> > > > > >> > > > > Correction, libelf is needed for libbpf, so we still need to >> > > > > keep >> > > > > it. >> > > > >> > > > If libbpf needs libelf for its internal usage, it should be >> > > > linked >> > > > against it itself. Unless symbols from libelf are used in >> > > > static >> > > > functions defined in libbpf's public headers. Is this the case? >> > > > >> > > >> > > Yes, that's the case. without the libelf, it would have build >> > > error >> > > as below, >> > > and these symbols are used in static functions of libbpf. >> > > >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_nextscn' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_rawdata' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_memory' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `gelf_getrel' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_strptr' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_end' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_getscn' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_begin' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `gelf_getsym' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_version' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `gelf_getehdr' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `elf_getdata' >> > > /usr/lib/gcc/x86_64-redhat- >> > > linux/4.8.5/../../../../lib64/libbpf.so: >> > > undefined reference to `gelf_getshdr' >> > > >> > > Thanks, >> > > Xiaolong >> > >> > Looking at that list, at least the very first symbol is not used by >> > a >> > public header, but internally in libbpf: >> > >> > $ grep -r elf_nextscn >> > libbpf.c: while ((scn = elf_nextscn(elf, scn)) != NULL) { >> > >> > https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/tools/lib/bpf/libbpf.c#n793 >> > >> > None of those symbols are used from the public headers: >> > >> > $ grep elf_ bpf.h libbpf.h btf.h >> > $ >> > >> > Therefore, this is an omission in libbpf's Makefile, as it must >> > link >> > against libelf. Please raise a ticket or send a patch upstream, and >> > remove the -lelf from DPDK's makefiles. >> >> As it may need sometime for kernel community to handle the libbpf's >> Makefile, >> We may still need the -lelf for af_xdp pmd currently, I'll remove it >> later after >> libbpf correct to link against libelf. Is it acceptable? >> >> Thanks, >> Xiaolong > >Isn't the final version not out yet anyway till May? Can the fix be >included before the release? I think so. Thanks, Xiaolong > >-- >Kind regards, >Luca Boccassi