Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, March 26, 2019 4:35 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
> 
> A log message is required when provided RSS key is not valid so that driver will
> use the default RSS key.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
> 
> ---
> 
> v2:
> update dev info message
> 
> v3:
> update log info
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 63ec813..5472312 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>  		rss_conf.rss_key = (uint8_t *)rss_key_default;
>  		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>  							sizeof(uint32_t);
> +		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
> +default\n");

s/perfect/valid to align with the title

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

>  	}
> 
>  	i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5