From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: "shahafs@mellanox.com" <shahafs@mellanox.com>,
"matan@mellanox.com" <matan@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"yskoh@mellanox.com" <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode
Date: Tue, 26 Mar 2019 13:16:34 +0000 [thread overview]
Message-ID: <37f08d959fc12d484028d5e6d73433f51abe1d1b.camel@marvell.com> (raw)
Message-ID: <20190326131634.Jl8kFmi_L0Dhv_Vq9k1V054X5Q84md6tlJXR0Y44zak@z> (raw)
In-Reply-To: <CY4PR1801MB186332CB49B59D3C5B6C4CDFDE5F0@CY4PR1801MB1863.namprd18.prod.outlook.com>
On Tue, 2019-03-26 at 12:06 +0000, Pavan Nikhilesh Bhagavatula wrote:
> > -----Original Message-----
> > From: Iremonger, Bernard <bernard.iremonger@intel.com>
> > Sent: Tuesday, March 26, 2019 5:20 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Pavan Nikhilesh
> > Bhagavatula <pbhagavatula@marvell.com>
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > arybchenko@solarflare.com; Yigit, Ferruh <ferruh.yigit@intel.com>
> > Subject: [EXT] RE: [dpdk-dev] [PATCH v2] app/testpmd: add mempool
> > bulk
> > get for txonly mode
> >
> >
> > > Then we'll be able to examine it and check the performance.
> > >
> > > We need to have more tests with more hardware in order to better
> > > understand the performance improvement.
> > > For info, a degradation is seen in Mellanox lab.
>
> The only real change was that we introduced mempool_bulk get to avoid
> multiple calls to mempool layer.
> I don't see how that would degrade the performance.
I don't think, it is CPU instruction based degradation as it gives
better performance on x86 and arm64. Adding Mellanox maintainers to
comment on, How does it impact on Mellanox NIC hardware?
next prev parent reply other threads:[~2019-03-26 13:16 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 19:42 [dpdk-dev] [PATCH] app/testpmd: use " Pavan Nikhilesh Bhagavatula
2019-03-01 7:38 ` Andrew Rybchenko
2019-03-01 8:45 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-03-01 13:47 ` [dpdk-dev] [PATCH v2] app/testpmd: add " Pavan Nikhilesh Bhagavatula
2019-03-19 16:48 ` Ferruh Yigit
2019-03-19 16:48 ` Ferruh Yigit
2019-03-20 4:53 ` Pavan Nikhilesh Bhagavatula
2019-03-20 4:53 ` Pavan Nikhilesh Bhagavatula
2019-03-26 8:43 ` Ferruh Yigit
2019-03-26 8:43 ` Ferruh Yigit
2019-03-26 11:00 ` Thomas Monjalon
2019-03-26 11:00 ` Thomas Monjalon
2019-03-26 11:50 ` Iremonger, Bernard
2019-03-26 11:50 ` Iremonger, Bernard
2019-03-26 12:06 ` Pavan Nikhilesh Bhagavatula
2019-03-26 12:06 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:16 ` Jerin Jacob Kollanukkaran [this message]
2019-03-26 13:16 ` Jerin Jacob Kollanukkaran
2019-03-26 12:26 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: optimize testpmd " Pavan Nikhilesh Bhagavatula
2019-03-26 12:26 ` Pavan Nikhilesh Bhagavatula
2019-03-26 12:27 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-26 12:27 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd " Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` Pavan Nikhilesh Bhagavatula
2019-03-26 16:13 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd " Iremonger, Bernard
2019-03-26 16:13 ` Iremonger, Bernard
2019-03-31 13:14 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` Pavan Nikhilesh Bhagavatula
2019-04-01 20:25 ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd " Ferruh Yigit
2019-04-01 20:25 ` Ferruh Yigit
2019-04-01 20:53 ` Thomas Monjalon
2019-04-01 20:53 ` Thomas Monjalon
2019-04-02 1:03 ` Jerin Jacob Kollanukkaran
2019-04-02 1:03 ` Jerin Jacob Kollanukkaran
2019-04-02 7:06 ` Thomas Monjalon
2019-04-02 7:06 ` Thomas Monjalon
2019-04-02 8:31 ` Jerin Jacob Kollanukkaran
2019-04-02 8:31 ` Jerin Jacob Kollanukkaran
2019-04-02 9:03 ` Ali Alnubani
2019-04-02 9:03 ` Ali Alnubani
2019-04-02 9:06 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:06 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for allocating segments Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:28 ` Lin, Xueqin
2019-04-09 9:28 ` Lin, Xueqin
2019-04-09 9:32 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:32 ` Pavan Nikhilesh Bhagavatula
2019-04-09 12:24 ` Yao, Lei A
2019-04-09 12:24 ` Yao, Lei A
2019-04-09 12:29 ` Ferruh Yigit
2019-04-09 12:29 ` Ferruh Yigit
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 4/4] app/testpmd: add mempool bulk get for txonly mode Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-02 15:21 ` [dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop Raslan Darawsheh
2019-04-02 15:21 ` Raslan Darawsheh
2019-04-04 16:23 ` Ferruh Yigit
2019-04-04 16:23 ` Ferruh Yigit
2019-04-05 17:37 ` Ferruh Yigit
2019-04-05 17:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f08d959fc12d484028d5e6d73433f51abe1d1b.camel@marvell.com \
--to=jerinj@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=pbhagavatula@marvell.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).