From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D111AA05D3 for ; Tue, 26 Mar 2019 16:09:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BCBAD0B2; Tue, 26 Mar 2019 16:09:09 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9FD754C88 for ; Tue, 26 Mar 2019 16:09:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 08:09:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="158543528" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2019 08:09:03 -0700 To: Olivier MATZ , ivan.boule@6wind.com, Andrew Rybchenko References: <1504862469-931-1-git-send-email-ivan.boule@6wind.com> <8695b1a0-b717-91d8-8522-9f60fe5d5932@solarflare.com> <20171212111055.wc3cyg2zzcmkmfip@platinum> Cc: Thomas Monjalon , dpdk-dev From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <8d7bcd93-15bf-8c2c-96d2-bdd21e75f899@intel.com> Date: Tue, 26 Mar 2019 15:09:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20171212111055.wc3cyg2zzcmkmfip@platinum> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add administrative information in per-port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326150902.MYD6BfmvpKDo-KtVXb_wZQGUPYVjp2I0kHUHTOEl5Cs@z> On 12/12/2017 11:10 AM, olivier.matz at 6wind.com (Olivier MATZ) wrote: > Hi Andrew, > > On Wed, Nov 15, 2017 at 12:09:24PM +0300, Andrew Rybchenko wrote: >> On 09/08/2017 12:21 PM, Ivan Boule wrote: >>> To help administrative tasks on DPDK ports, add in the data structure >>> rte_eth_dev_info the following per-port information to be supplied >>> by the dev_infos_get() function exported by a Poll Mode Driver: >>> >>> - the set of supported link modes, >>> - the set of advertised link modes, >>> - the type of port connector, >>> - autonegotiation enabled or not. >> >> Sorry for late response. I've lost it from my view until today's discussion >> of >> deprecation notice. > > Sorry also for my late answer, and thank you for your comments. > >> Just for my understanding. I always considered dev_info as place for >> more or less stable information like capabilities and physical restrictions. >> Port connector perfectly fits it, but advertised link modes and autoneg >> status are more dynamic. May be it is a better way to have dedicated API? >> Just would like to raise discussion and understand why finally one or >> another way will be chosen. > > Yes, you are right. I think we can find some exceptions: > > - nb_rx_queues/nb_tx_queues return the current number of configured queues > - the speed capabilities may depend on the SFP, which can be hot-plugged > - with a failsafe driver, the capabilities/limits depend on the list of > sub-devices > - maybe the offload capabilities on a virtio device could depend on the > peer configuration. > > But, yes, a new API is maybe better to avoid adding another exception. > Something like rte_eth_media_get() ? > > >> Also see note below about connectors. >> >>> Set new administrative fields to a default value in rte_eth_dev_info_get() >>> before invoking the dev_infos_get() function exported by a PMD, if any. >>> >>> Once this API change is accepted, the dev_infos_get() function of PMDs >>> will be updated accordingly to set these new fields, along with the >>> port_infos_display() function of the testpmd to display them. >>> >>> Signed-off-by: Ivan Boule >>> --- >>> lib/librte_ether/rte_ethdev.c | 1 + >>> lib/librte_ether/rte_ethdev.h | 112 ++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 113 insertions(+) >>> >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >>> index 0597641..4ca51e1 100644 >>> --- a/lib/librte_ether/rte_ethdev.c >>> +++ b/lib/librte_ether/rte_ethdev.c >>> @@ -1897,6 +1897,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) >>> memset(dev_info, 0, sizeof(struct rte_eth_dev_info)); >>> dev_info->rx_desc_lim = lim; >>> dev_info->tx_desc_lim = lim; >>> + dev_info->connector = RTE_ETH_CONNECTOR_OTHER; >>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >>> index 0adf327..ac49380 100644 >>> --- a/lib/librte_ether/rte_ethdev.h >>> +++ b/lib/librte_ether/rte_ethdev.h >>> @@ -935,6 +935,113 @@ struct rte_pci_device; >>> /** >>> * Ethernet device information >>> */ >>> + >>> +/* Types of port connector. */ >>> +#define RTE_ETH_CONNECTOR_TP 0x00 /**< Twisted Pair */ >>> +#define RTE_ETH_CONNECTOR_AUI 0x01 /**< Attachment Unit Interface */ >>> +#define RTE_ETH_CONNECTOR_MII 0x02 /**< Media-Independent Interface */ >>> +#define RTE_ETH_CONNECTOR_FIBRE 0x03 /**< Fiber */ >>> +#define RTE_ETH_CONNECTOR_DA 0x05 /**< Direct Attach */ >> >> I thought that examples of connectors are rather RG45, SFP, SFP+, QSFP+, >> SFP28, QSFP28. >> Media could be twisted pair, fibre, direct attach etc. > > The types of connectors are derivated from Linux ethtool. > But thinking at it, directly copying the defines would cause licensing > issues since ethtool is GPL. > > Unfortunatly, I don't know that much about the different types of > connectors and media. I found some inputs on the wikipedia page > ( https://en.wikipedia.org/wiki/Ethernet_physical_layer ), but > any additional input is welcome :) > > >>> +#define RTE_ETH_CONNECTOR_NONE 0xef >>> +#define RTE_ETH_CONNECTOR_OTHER 0xff >>> + >>> +/* Link modes. */ >>> +#define RTE_ETH_LINK_MODE_10baseT_Half_BIT 0 >>> +#define RTE_ETH_LINK_MODE_10baseT_Full_BIT 1 >>> +#define RTE_ETH_LINK_MODE_100baseT_Half_BIT 2 >>> +#define RTE_ETH_LINK_MODE_100baseT_Full_BIT 3 >>> +#define RTE_ETH_LINK_MODE_1000baseT_Half_BIT 4 >>> +#define RTE_ETH_LINK_MODE_1000baseT_Full_BIT 5 >>> +#define RTE_ETH_LINK_MODE_Autoneg_BIT 6 >>> +#define RTE_ETH_LINK_MODE_TP_BIT 7 >>> +#define RTE_ETH_LINK_MODE_AUI_BIT 8 >>> +#define RTE_ETH_LINK_MODE_MII_BIT 9 >>> +#define RTE_ETH_LINK_MODE_FIBRE_BIT 10 >>> +#define RTE_ETH_LINK_MODE_BNC_BIT 11 >>> +#define RTE_ETH_LINK_MODE_10000baseT_Full_BIT 12 >>> +#define RTE_ETH_LINK_MODE_Pause_BIT 13 >>> +#define RTE_ETH_LINK_MODE_Asym_Pause_BIT 14 >>> +#define RTE_ETH_LINK_MODE_2500baseX_Full_BIT 15 >>> +#define RTE_ETH_LINK_MODE_Backplane_BIT 16 >>> +#define RTE_ETH_LINK_MODE_1000baseKX_Full_BIT 17 >>> +#define RTE_ETH_LINK_MODE_10000baseKX4_Full_BIT 18 >>> +#define RTE_ETH_LINK_MODE_10000baseKR_Full_BIT 19 >>> +#define RTE_ETH_LINK_MODE_10000baseR_FEC_BIT 20 >>> +#define RTE_ETH_LINK_MODE_20000baseMLD2_Full_BIT 21 >>> +#define RTE_ETH_LINK_MODE_20000baseKR2_Full_BIT 22 >>> +#define RTE_ETH_LINK_MODE_40000baseKR4_Full_BIT 23 >>> +#define RTE_ETH_LINK_MODE_40000baseCR4_Full_BIT 24 >>> +#define RTE_ETH_LINK_MODE_40000baseSR4_Full_BIT 25 >>> +#define RTE_ETH_LINK_MODE_40000baseLR4_Full_BIT 26 >>> +#define RTE_ETH_LINK_MODE_56000baseKR4_Full_BIT 27 >>> +#define RTE_ETH_LINK_MODE_56000baseCR4_Full_BIT 28 >>> +#define RTE_ETH_LINK_MODE_56000baseSR4_Full_BIT 29 >>> +#define RTE_ETH_LINK_MODE_56000baseLR4_Full_BIT 30 >>> +#define RTE_ETH_LINK_MODE_25000baseCR_Full_BIT 31 >>> +#define RTE_ETH_LINK_MODE_25000baseKR_Full_BIT 32 >>> +#define RTE_ETH_LINK_MODE_25000baseSR_Full_BIT 33 >>> +#define RTE_ETH_LINK_MODE_50000baseCR2_Full_BIT 34 >>> +#define RTE_ETH_LINK_MODE_50000baseKR2_Full_BIT 35 >>> +#define RTE_ETH_LINK_MODE_100000baseKR4_Full_BIT 36 >>> +#define RTE_ETH_LINK_MODE_100000baseSR4_Full_BIT 37 >>> +#define RTE_ETH_LINK_MODE_100000baseCR4_Full_BIT 38 >>> +#define RTE_ETH_LINK_MODE_100000baseLR4_ER4_Full_BIT 39 >>> +#define RTE_ETH_LINK_MODE_50000baseSR2_Full_BIT 40 >>> +#define RTE_ETH_LINK_MODE_1000baseX_Full_BIT 41 >>> +#define RTE_ETH_LINK_MODE_10000baseCR_Full_BIT 42 >>> +#define RTE_ETH_LINK_MODE_10000baseSR_Full_BIT 43 >>> +#define RTE_ETH_LINK_MODE_10000baseLR_Full_BIT 44 >>> +#define RTE_ETH_LINK_MODE_10000baseLRM_Full_BIT 45 >>> +#define RTE_ETH_LINK_MODE_10000baseER_Full_BIT 46 >>> +#define RTE_ETH_LINK_MODE_2500baseT_Full_BIT 47 >>> +#define RTE_ETH_LINK_MODE_5000baseT_Full_BIT 48 >>> + >>> +#define RTE_ETH_LINK_MODE_BIT(link_mode_base_name) \ >>> + (RTE_ETH_LINK_MODE_ ## link_mode_base_name ## _BIT) > > So, same here, these link modes are from ethtool and should not > be used. We could try to build our own from FreeBSD's media > type: http://fxr.watson.org/fxr/source/net/if_media.h#L393 > > Thoughts? Hi Olivier, The patch is waiting for comments since end of 2017, any objection to reject it? If this is still relevant would you mind sending a up to date version of it? Thanks, ferruh