From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7D63AA05D3 for ; Wed, 27 Mar 2019 00:01:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6EB41B459; Wed, 27 Mar 2019 00:00:59 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id CB1891B458 for ; Wed, 27 Mar 2019 00:00:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 79ADC45C1; Tue, 26 Mar 2019 19:00:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 19:00:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dSZV6PTwTAnqnQF8qMLK2W/Z7gR0RFTdgOc5xscpHEA=; b=UoBtGxt0O48C DmWJRpphmPGw0jW7sikpAigkkOH7yhT6tIQwjIICp9fp42sCSkfOihaScv9sKqN5 Yfx05EcBSS4PwBjDTA59RagNh/3WF4qeT/egvkoz1mw08fzQrSv+gJVfRwsTuNaG mcuJc1SvGcGwLuYI+1Q/X5j/ZcculNY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dSZV6PTwTAnqnQF8qMLK2W/Z7gR0RFTdgOc5xscpH EA=; b=U9vuARI1srWgK491hw2/ZjTfjJR6V0cmnFmFdVco5W69JIWmUtywGWHre 7LnWsfwCplh727u+0hChWio2WQ0hu+kKHkfptHa7gXucMajpNPJSMUHglaZgmId5 m1V5pMCViEGtnBuooVuZ5dWlbEpd3PbQny/73BrYSOM6FTVrOPt4/8KHiIQk4bPP 270jphz5x6O3Rdf55onQaSRmrxWS6FMKZsxGBf7/JMDbkLUZBfB7nTPoCcSS1XJj WcbHChRyARcDhvzbagw+Z3v7Yk/bGIJd9nK/YIeM6EIURd3c9k9GYZfnLd7aJWjR 65tKBcZPzBdrQMnEHJGf8eul+yB5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedugddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepfhhrvggvuggvshhkthhophdrohhrghdpghhithhhuhgsrdgtohhmnecukfhp peejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhoh hmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 387901030F; Tue, 26 Mar 2019 19:00:54 -0400 (EDT) From: Thomas Monjalon To: Jeff Shaw Cc: Stephen Hemminger , Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Date: Wed, 27 Mar 2019 00:00:49 +0100 Message-ID: <2223434.7BpSH3hZxr@xps> In-Reply-To: <20190326223406.GA86204@ae13-28.jf.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <12533294.MXuU50Ibyh@xps> <20190326223406.GA86204@ae13-28.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326230049.Gtu4y05zycNp49KNmtUK5IxtfB0KSODkMcPfeAs4jgw@z> 26/03/2019 23:34, Jeff Shaw: > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > 26/03/2019 22:54, Jeff Shaw: > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 22:14, Jeff Shaw: > > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > > > > Even better would be to get it as a dependency outside of DPDK. > > > > > > Where this code come from? > > > > > > How other projects on Windows get it? > > > > > > > > > > It comes from FreeBSD 12.0, specifically > > > > > https://github.com/freebsd/freebsd/blob/releng/12.0/sys/sys/queue.h > > > > > > > > > > It has been modified such that only the parts used by DPDK (i.e. TAILQ) are > > > > > implemented. The other stuff has been deleted. Windows does not have sys/queue.h, > > > > > so we reproduce it here. > > > > > > > > > > Would it better to have this as a dependency outside of DPDK? I think pulling a file > > > > > from the internet and applying a patch (where we'd have to maintain a patch file > > > > > inside of DPDK's repo anyway) would be overkill when we just need a few lines of > > > > > code that will change very infrequently. > > > > > > > > We already try to get the libbsd dependency on Linux. > > > > Why not mandate libbsd for Windows? > > > > It has this header file and a lot more: > > > > https://gitlab.freedesktop.org/libbsd/libbsd/blob/master/include/bsd/sys/queue.h > > > > > > > > Relying on libbsd may avoid copying other files for Windows port. > > > > > > I like that idea, though it doesn't look like libbsd builds on Windows, do you > > > know of a Windows version or one that doesn't depend on autotools to build? > > > > It seems libbsd is not packaged for Windows. > > May be worth to ask opinions to libbsd maintainers. > > > > Please could you list which other headers are required for the Windows port? > > For helloworld the only one is sys/queue.h. > > The dpdk-draft-windows repo has at least these (non-empty) ones: > dirent.h > getopt.h > net/ethernet.h > net/socket.h > netinet/in.h > netinet/tcp.h > pthread.h > rand48.h > sched.h > sys/_iovec.h > sys/_sockaddr_storage.h > sys/_termios.h > sys/_types.h > sys/cdefs.h > sys/mman.h > sys/netbsd/queue.h > sys/queue.h > sys/sysctl.h > syslog.h > termios.h > unistd.h > > There will likely be more as more libraries are identified with dependencies on UNIX-like > headers. I would like we find a good solution for these headers. How other cross-platform projects are getting such dependencies? Is Cygwin a solution?