Re: [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices

[Slava Ovsiienko <viacheslavo@mellanox.com>]

> -----Original Message-----
> From: Shahaf Shuler
> Sent: Wednesday, March 27, 2019 8:00
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Subject: RE: [PATCH v3 00/14] net/mlx5: add support for multiport IB devices
> 
> Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko:
> > Subject: [PATCH v3 00/14] net/mlx5: add support for multiport IB
> > devices
> >
> > The Mellanox NICs support SR-IOV and have E-Switch feature.
[..]
> >
> > This patchset also superseedes http://patches.dpdk.org/patch/50486/
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, basically I am OK w/ the series, in order for me to apply:
> 1. need to rebase on top of latest master. There are some merge conflicts.
> 2. at least patch[1] seems to be taken from another branch (checkout the
> HAVE_MLX5DV_DR flag). Please handle.
> 
> [1]
> https://patches.dpdk.org/patch/51739/

Off the list:

My patchset is rebased on the top,  but there are three Ori's commits not merged
I was to told to base on:  http://patches.dpdk.org/patch/51403/

> 
> 
> >
> > ---
> > v3:
> > 	- vport_id field is added, contains associated VF vport
> > 	  index on E-Switch. representor_id field is reverted
> > 	  to keep the VF index
> > 	- some comment spellcheck
> > 	- some error logging is added for master/representor
> > 	  wrong recognition
> > 	- shared IB context alloc/free routines mutex
> > 	  protection added
> >
> > v2:
> > 	http://patches.dpdk.org/patch/51642/
> > 	- clarifying comments added
> > 	- secondary process does not probe IB device at all and
> > 	  does not create shared context
> > 	- minor bugs (like ++ in assert) fixed
> > 	- representor_id contains corresponding VF vport index,
> > 	  no corrections +1 is needed anymore. vport index is
> > 	  calculated in the only place in code and if indexing
> > 	  schema is changed it would be easy to modify
> >
> > v1:
> > 	http://patches.dpdk.org/cover/51451/
> >
> > Viacheslav Ovsiienko (13):
> >   net/mlx5: add representor recognition on kernels 5.x
> >   net/mlx5: modify get ifindex routine for multiport IB
> >   net/mlx5: add getting IB ports number for multiport IB
> >   net/mlx5: add multiport IB device support to probing
> >   net/mlx5: add IB shared context alloc/free functions
> >   net/mlx5: switch to the names in the shared IB context
> >   net/mlx5: switch to the shared Protection Domain
> >   net/mlx5: switch to the shared context IB attributes
> >   net/mlx5: switch to the shared IB device context
> >   net/mlx5: provide IB port for the object being created
> >   net/mlx5: update install/uninstall int handler routines
> >   net/mlx5: update event handler for multiport IB devices
> >   net/mlx5: add source vport match to the ingress rules
> >
> >  drivers/net/mlx5/Makefile          |  10 +
> >  drivers/net/mlx5/meson.build       |   4 +
> >  drivers/net/mlx5/mlx5.c            | 651 ++++++++++++++++++++++++++--------
> > ---
> >  drivers/net/mlx5/mlx5.h            |  45 ++-
> >  drivers/net/mlx5/mlx5_ethdev.c     | 248 +++++++++-----
> >  drivers/net/mlx5/mlx5_flow.c       |   2 +
> >  drivers/net/mlx5/mlx5_flow_dv.c    |  45 ++-
> >  drivers/net/mlx5/mlx5_flow_verbs.c |   7 +-
> >  drivers/net/mlx5/mlx5_mr.c         |   4 +-
> >  drivers/net/mlx5/mlx5_nl.c         | 108 +++++-
> >  drivers/net/mlx5/mlx5_rxq.c        |  41 +--
> >  drivers/net/mlx5/mlx5_socket.c     |   4 +-
> >  drivers/net/mlx5/mlx5_stats.c      |  22 +-
> >  drivers/net/mlx5/mlx5_trigger.c    |   2 +-
> >  drivers/net/mlx5/mlx5_txq.c        |  24 +-
> >  15 files changed, 879 insertions(+), 338 deletions(-)
> >
> > --
> > 1.8.3.1