* [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
@ 2019-03-25 14:37 Fan Zhang
2019-03-25 14:37 ` Fan Zhang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fan Zhang @ 2019-03-25 14:37 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, Fan Zhang, stable
Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
Coverity Issue: 277214
Coverity Issue: 277220
Coverity Issue: 277233
Coverity Issue: 277236
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
lib/librte_vhost/vhost_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index 9b4b850e8..0edf12d52 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
chain->para.hash_result_len,
- nb_descs, vq_size)) < 0) {
+ nb_descs, vq_size) < 0)) {
ret = VIRTIO_CRYPTO_BADMSG;
goto error_exit;
}
@@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
op->sym->m_src->data_off = 0;
if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
- op, head, desc_idx)) < 0)
+ op, head, desc_idx) < 0))
break;
}
--
2.14.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
2019-03-25 14:37 [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues Fan Zhang
@ 2019-03-25 14:37 ` Fan Zhang
2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2 siblings, 0 replies; 6+ messages in thread
From: Fan Zhang @ 2019-03-25 14:37 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, Fan Zhang, stable
Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
Coverity Issue: 277214
Coverity Issue: 277220
Coverity Issue: 277233
Coverity Issue: 277236
Cc: stable@dpdk.org
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
lib/librte_vhost/vhost_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index 9b4b850e8..0edf12d52 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
chain->para.hash_result_len,
- nb_descs, vq_size)) < 0) {
+ nb_descs, vq_size) < 0)) {
ret = VIRTIO_CRYPTO_BADMSG;
goto error_exit;
}
@@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
op->sym->m_src->data_off = 0;
if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
- op, head, desc_idx)) < 0)
+ op, head, desc_idx) < 0))
break;
}
--
2.14.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
2019-03-25 14:37 [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues Fan Zhang
2019-03-25 14:37 ` Fan Zhang
@ 2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2 siblings, 1 reply; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-27 10:18 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
>
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 9b4b850e8..0edf12d52 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
>
> if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
> chain->para.hash_result_len,
> - nb_descs, vq_size)) < 0) {
> + nb_descs, vq_size) < 0)) {
> ret = VIRTIO_CRYPTO_BADMSG;
> goto error_exit;
> }
> @@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
> op->sym->m_src->data_off = 0;
>
> if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
> - op, head, desc_idx)) < 0)
> + op, head, desc_idx) < 0))
> break;
> }
>
>
Good catch from Coverity!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
2019-03-27 10:18 ` Maxime Coquelin
@ 2019-03-27 10:18 ` Maxime Coquelin
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-27 10:18 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
>
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 9b4b850e8..0edf12d52 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
>
> if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
> chain->para.hash_result_len,
> - nb_descs, vq_size)) < 0) {
> + nb_descs, vq_size) < 0)) {
> ret = VIRTIO_CRYPTO_BADMSG;
> goto error_exit;
> }
> @@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
> op->sym->m_src->data_off = 0;
>
> if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
> - op, head, desc_idx)) < 0)
> + op, head, desc_idx) < 0))
> break;
> }
>
>
Good catch from Coverity!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
2019-03-25 14:37 [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues Fan Zhang
2019-03-25 14:37 ` Fan Zhang
2019-03-27 10:18 ` Maxime Coquelin
@ 2019-03-27 11:14 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2 siblings, 1 reply; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-27 11:14 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
>
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues
2019-03-27 11:14 ` Maxime Coquelin
@ 2019-03-27 11:14 ` Maxime Coquelin
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-27 11:14 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: stable
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
>
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-27 11:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 14:37 [dpdk-dev] [PATCH] vhost/crypto: fix coverity issues Fan Zhang
2019-03-25 14:37 ` Fan Zhang
2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 10:18 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).