* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-02-18 12:30 [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support Ferruh Yigit
@ 2019-02-18 14:24 ` Neil Horman
2019-02-18 14:26 ` Igor Ryzhov
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Neil Horman @ 2019-02-18 14:24 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, John McNamara, Marko Kovacevic
On Mon, Feb 18, 2019 at 12:30:02PM +0000, Ferruh Yigit wrote:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..0491eeea1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -75,3 +75,11 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be
> changed from 0.49.0 to 0.52.0.
> +
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the KNI,
> + but only to remove ethtool support of it that is disabled by default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` & ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model can't be extend
> + to all drivers in DPDK and it is too much effort to maintain kernel modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` & ``ixgbe`` anymore.
> --
> 2.20.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-02-18 12:30 [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support Ferruh Yigit
2019-02-18 14:24 ` Neil Horman
@ 2019-02-18 14:26 ` Igor Ryzhov
2019-02-18 14:42 ` Jerin Jacob Kollanukkaran
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Igor Ryzhov @ 2019-02-18 14:26 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman, John McNamara, Marko Kovacevic
Acked-by: Igor Ryzhov <iryzhov@nfware.com>
On Mon, Feb 18, 2019 at 3:30 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..0491eeea1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -75,3 +75,11 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
> changed from 0.49.0 to 0.52.0.
> +
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the
> KNI,
> + but only to remove ethtool support of it that is disabled by default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` &
> ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model can't be
> extend
> + to all drivers in DPDK and it is too much effort to maintain kernel
> modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` &
> ``ixgbe`` anymore.
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-02-18 12:30 [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support Ferruh Yigit
2019-02-18 14:24 ` Neil Horman
2019-02-18 14:26 ` Igor Ryzhov
@ 2019-02-18 14:42 ` Jerin Jacob Kollanukkaran
2019-02-18 18:56 ` Rami Rosen
2019-03-27 13:37 ` Thomas Monjalon
4 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-02-18 14:42 UTC (permalink / raw)
To: nhorman, john.mcnamara, marko.kovacevic, ferruh.yigit, dev
On Mon, 2019-02-18 at 12:30 +0000, Ferruh Yigit wrote:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..0491eeea1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -75,3 +75,11 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library
> version will be
> changed from 0.49.0 to 0.52.0.
> +
> +* kni: remove KNI ethtool support. To clarify, this is not to remove
> the KNI,
> + but only to remove ethtool support of it that is disabled by
> default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` &
> ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model
> can't be extend
> + to all drivers in DPDK and it is too much effort to maintain
> kernel modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` &
> ``ixgbe`` anymore.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-02-18 12:30 [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support Ferruh Yigit
` (2 preceding siblings ...)
2019-02-18 14:42 ` Jerin Jacob Kollanukkaran
@ 2019-02-18 18:56 ` Rami Rosen
2019-03-27 13:37 ` Thomas Monjalon
4 siblings, 0 replies; 7+ messages in thread
From: Rami Rosen @ 2019-02-18 18:56 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, nhorman, John McNamara, Marko Kovacevic
Acked-by: Rami Rosen <ramirose@gmail.com>
בתאריך יום ב׳, 18 בפבר׳ 2019, 14:30, מאת Ferruh Yigit <
ferruh.yigit@intel.com>:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 1b4fcb7e6..0491eeea1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -75,3 +75,11 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
> changed from 0.49.0 to 0.52.0.
> +
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the
> KNI,
> + but only to remove ethtool support of it that is disabled by default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` &
> ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model can't be
> extend
> + to all drivers in DPDK and it is too much effort to maintain kernel
> modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` &
> ``ixgbe`` anymore.
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-02-18 12:30 [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support Ferruh Yigit
` (3 preceding siblings ...)
2019-02-18 18:56 ` Rami Rosen
@ 2019-03-27 13:37 ` Thomas Monjalon
2019-03-27 13:37 ` Thomas Monjalon
4 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2019-03-27 13:37 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman, John McNamara, Marko Kovacevic
18/02/2019 13:30, Ferruh Yigit:
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the KNI,
> + but only to remove ethtool support of it that is disabled by default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` & ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model can't be extend
s/extend/extended/
> + to all drivers in DPDK and it is too much effort to maintain kernel modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` & ``ixgbe`` anymore.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support
2019-03-27 13:37 ` Thomas Monjalon
@ 2019-03-27 13:37 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2019-03-27 13:37 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman, John McNamara, Marko Kovacevic
18/02/2019 13:30, Ferruh Yigit:
> +* kni: remove KNI ethtool support. To clarify, this is not to remove the KNI,
> + but only to remove ethtool support of it that is disabled by default and
> + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option.
> + Existing KNI ethtool implementation is only supported by ``igb`` & ``ixgbe``
> + drivers, by using a copy of kernel drivers in DPDK. This model can't be extend
s/extend/extended/
> + to all drivers in DPDK and it is too much effort to maintain kernel modules in DPDK.
> + As a result users won't be able to use ``ethtool`` via ``igb`` & ``ixgbe`` anymore.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread