From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 69668A05D3 for ; Wed, 27 Mar 2019 15:51:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18FC16833; Wed, 27 Mar 2019 15:51:31 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CA0145F1B for ; Wed, 27 Mar 2019 15:51:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP; 27 Mar 2019 07:51:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="286372121" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2019 07:51:26 -0700 To: Hajkowski , david.hunt@intel.com Cc: dev@dpdk.org References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> <20190321105506.6656-4-marcinx.hajkowski@intel.com> From: "Burakov, Anatoly" Message-ID: <52dbc79d-716d-2eff-6d29-88b00bd18ec8@intel.com> Date: Wed, 27 Mar 2019 14:51:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190321105506.6656-4-marcinx.hajkowski@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] power: process incoming confirmation cmds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327145125.XVzsAXdbpZ1WXGJBwVW_8rhS2Ta_9YmKpnOjp-Ccs6s@z> On 21-Mar-19 10:55 AM, Hajkowski wrote: > From: Marcin Hajkowski > > Extend vm_power_guest to check incoming confirmations > of messages previously sent to host. > > Signed-off-by: Marcin Hajkowski > --- > examples/vm_power_manager/guest_cli/Makefile | 1 + > .../guest_cli/vm_power_cli_guest.c | 65 +++++++++++++++---- > 2 files changed, 54 insertions(+), 12 deletions(-) > > diff --git a/examples/vm_power_manager/guest_cli/Makefile b/examples/vm_power_manager/guest_cli/Makefile > index a5634eacf..51a5010ab 100644 > --- a/examples/vm_power_manager/guest_cli/Makefile > +++ b/examples/vm_power_manager/guest_cli/Makefile > @@ -18,6 +18,7 @@ SRCS-y := main.c vm_power_cli_guest.c parse.c > > CFLAGS += -O3 -I$(RTE_SDK)/lib/librte_power/ > CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -DALLOW_EXPERIMENTAL_API > > # workaround for a gcc bug with noreturn attribute > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c > index 2d9e7689a..698dd5062 100644 > --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c > +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c > @@ -132,6 +132,26 @@ struct cmd_set_cpu_freq_result { > cmdline_fixed_string_t cmd; > }; > > +static int > +check_response_cmd(unsigned int lcore_id, int *result) > +{ > + struct channel_packet pkt; > + int ret; > + > + ret = rte_power_guest_channel_receive_msg(&pkt, lcore_id); > + if (ret < 0) > + return -1; > + > + if (pkt.command != CPU_POWER_CMD_ACK && > + pkt.command != CPU_POWER_CMD_NACK) { > + RTE_LOG(DEBUG, POWER, "Not expected command has been received.\n"); > + return -1; > + } Maybe use switch? E.g. swithc (pkt.command) { case ACK: case NACK: *result = blah; break; default: log failure; fail; } > + > + *result = (pkt.command == CPU_POWER_CMD_ACK); > + return 0; > +} > + > static void > cmd_set_cpu_freq_parsed(void *parsed_result, struct cmdline *cl, > __attribute__((unused)) void *data) > @@ -139,20 +159,31 @@ cmd_set_cpu_freq_parsed(void *parsed_result, struct cmdline *cl, > int ret = -1; > struct cmd_set_cpu_freq_result *res = parsed_result; > > - if (!strcmp(res->cmd , "up")) > + if (!strcmp(res->cmd, "up")) > ret = rte_power_freq_up(res->lcore_id); > - else if (!strcmp(res->cmd , "down")) > + else if (!strcmp(res->cmd, "down")) > ret = rte_power_freq_down(res->lcore_id); > - else if (!strcmp(res->cmd , "min")) > + else if (!strcmp(res->cmd, "min")) > ret = rte_power_freq_min(res->lcore_id); > - else if (!strcmp(res->cmd , "max")) > + else if (!strcmp(res->cmd, "max")) > ret = rte_power_freq_max(res->lcore_id); > else if (!strcmp(res->cmd, "enable_turbo")) > ret = rte_power_freq_enable_turbo(res->lcore_id); > else if (!strcmp(res->cmd, "disable_turbo")) > ret = rte_power_freq_disable_turbo(res->lcore_id); > - if (ret != 1) > + > + if (ret != 1) { > cmdline_printf(cl, "Error sending message: %s\n", strerror(ret)); > + return; > + } > + int result; > + ret = check_response_cmd(res->lcore_id, &result); > + if (ret < 0) { > + RTE_LOG(DEBUG, POWER, "No confirmation for sent msg received\n"); > + } else { > + cmdline_printf(cl, "Ack for sent msg received with result: %s.\n", > + result == 1 ? "SUCCESS" : "ERROR"); Here and in other places: others can correct me if i'm wrong, but i'm pretty sure RTE_LOG(..., POWER) is reserved for logs related to power library, and are not supposed to be used in user applications. If logging in an application is required, there are USER log levels. I can see that the app in question already does that in a few places, so it's kind of consistent with how things are already, but i would question the value of consistency in cases like these. Not sure how to proceed here. > + } > } > > cmdline_parse_token_string_t cmd_set_cpu_freq = > @@ -185,16 +216,26 @@ struct cmd_send_policy_result { > }; > > static inline int > -send_policy(struct channel_packet *pkt) > +send_policy(struct channel_packet *pkt, struct cmdline *cl) > { > int ret; > > ret = rte_power_guest_channel_send_msg(pkt, 1); > - if (ret == 0) > - return 1; > - RTE_LOG(DEBUG, POWER, "Error sending message: %s\n", > - ret > 0 ? strerror(ret) : "channel not connected"); > - return -1; > + if (ret < 0) { > + RTE_LOG(DEBUG, POWER, "Error sending message: %s\n", > + ret > 0 ? strerror(ret) : "channel not connected"); > + return -1; > + } > + > + int result; > + ret = check_response_cmd(1, &result); > + if (ret < 0) { > + RTE_LOG(DEBUG, POWER, "No confirmation for sent policy received\n"); > + } else { > + cmdline_printf(cl, "Ack for sent policy received with result: %s.\n", > + result == 1 ? "SUCCESS" : "ERROR"); > + } > + return 1; > } > > static void > @@ -206,7 +247,7 @@ cmd_send_policy_parsed(void *parsed_result, struct cmdline *cl, > > if (!strcmp(res->cmd, "now")) { > printf("Sending Policy down now!\n"); > - ret = send_policy(&policy); > + ret = send_policy(&policy, cl); > } > if (ret != 1) > cmdline_printf(cl, "Error sending message: %s\n", > -- Thanks, Anatoly