From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id A2DC6A05D3
	for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 16:28:37 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 073F57CB0;
	Wed, 27 Mar 2019 16:28:37 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id C10A65F24
 for <dev@dpdk.org>; Wed, 27 Mar 2019 16:28:34 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id E90C94E93D;
 Wed, 27 Mar 2019 15:28:33 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C6901A8EA;
 Wed, 27 Mar 2019 15:28:33 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Luca Boccassi <bluca@debian.org>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Thomas Monjalon <thomas@monjalon.net>, "dev\@dpdk.org" <dev@dpdk.org>
References: <20190318162804.28974-1-jerinj@marvell.com>
 <f9211941b408b96779905fdaf7d0c0a0128d00f4.camel@debian.org>
 <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com>
Date: Wed, 27 Mar 2019 11:28:32 -0400
In-Reply-To: <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com> (Bruce
 Richardson's message of "Tue, 19 Mar 2019 09:50:29 +0000")
Message-ID: <f7tbm1wmj4v.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Wed, 27 Mar 2019 15:28:34 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190327152832.vECshVK0yRvbUZq4DtCdiOEL2fTUv-WUrQ2oy5grrzM@z>

Bruce Richardson <bruce.richardson@intel.com> writes:

> On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
>> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
>> > From: Jerin Jacob <jerinj@marvell.com>
>> > 
>> > Remove the following meson build warnings
>> > 
>> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
>> >  but uses features which were added in newer versions:
>> >  * 0.48.0: {'console arg in custom_target'}
>> > 
>> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
>> > different types (list, str) using ==.
>> > 
>> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> > ---
>> >  config/arm/meson.build | 4 ++--
>> >  meson.build            | 2 +-
>> >  2 files changed, 3 insertions(+), 3 deletions(-)
>> > 
>> > diff --git a/config/arm/meson.build b/config/arm/meson.build
>> > index 8e892fa77..170a4981a 100644
>> > --- a/config/arm/meson.build
>> > +++ b/config/arm/meson.build
>> > @@ -116,8 +116,8 @@ else
>> >  			cmd_output =
>> > cmd.stdout().to_lower().strip().split(' ')
>> >  		endif
>> >  		# Set to generic if variable is not found
>> > -		machine = get_variable('impl_' + cmd_output[0],
>> > 'generic')
>> > -		if machine == 'generic'
>> > +		machine = get_variable('impl_' + cmd_output[0],
>> > ['generic'])
>> > +		if machine[0] == 'generic'
>> >  			machine = impl_generic
>> >  			cmd_output = cmd_generic
>> >  		endif
>> > diff --git a/meson.build b/meson.build
>> > index 69833de82..f1abf1e59 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
>> >  	version: '19.05.0-rc0',
>> >  	license: 'BSD',
>> >  	default_options: ['buildtype=release',
>> > 'default_library=static'],
>> > -	meson_version: '>= 0.47.1'
>> > +	meson_version: '>= 0.48.0'
>> >  )
>> >  
>> >  # set up some global vars for compiler, platform, configuration,
>> > etc.
>> 
>> Bumping minimum dependency requirements needs an approval from the tech
>> board. Incidentally we just got it, and the bump to 0.47.1 just
>> happened.
>> 
>> You can remove this and ignore the warning about the console arg - it's
>> harmless if ran on a previous version which does not support it.
>> 
>
> +1 to this. The first fix is good though - perhaps do a V2 with just that.
>
> Sadly meson warnings for versions have too many false positives right now -
> the devs are aware of it, but don't have any good fixes for it yet, as far
> as I know. For our case, we will continue to have meson warnings, most of
> which are false positives like this one.

In this case, though, the warning isn't a false positive.  Here are the
release notes for 0.48.0 that relate to the argument in question:

https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target

I probably missed something.

<rant>
Incidentally, I've dropped my own patch related to this from a series I
was developing to run tests on travis.  I think it's a bit annoying that
we need the techboard to decide for cases like these, but I guess that's
just a fact of life.
</rant>

> Regards,
> /Bruce