From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6C697A05D3 for ; Wed, 27 Mar 2019 16:44:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 075A96CC1; Wed, 27 Mar 2019 16:44:42 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 4CAED6C9B for ; Wed, 27 Mar 2019 16:44:41 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id g3so15668126wrx.9 for ; Wed, 27 Mar 2019 08:44:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xCOzNW6okRhNHfC9zMZ0ybDCbHV1UVvOTmVwYsmlxBc=; b=JkEK8+DJILTjr07RKml5J33aghWG7c8kZExYwCg1ssmYcoN+0/U39eGZiAOV5kfKdz 7futWYaTWq8k7LGnt31kFd64O7FpDIQmKwmBQSTZ9kAGo1c4GmYL3h2jKxr3+4cQJY17 QOO9a6/iwhsNzV8KTJOsN88pIt9rCVbzXEgCdCrqCuTjVrurTjgeXC+pdq0hYGlkRW/X avQ9Ft2pJhgAd3hBxQqf/hjBEK4tqViQFJ/DCb8kRID74Bn6H5BkYRp4lfcxflkWfjVS CQ3Q9a3rsngG0CjFnxBdsIpyZXCsxWwFAA6N+xVlI2ap+UFt6JJQuW0BYsOTKwt+xryE ia5g== X-Gm-Message-State: APjAAAUXg2PRbEI09Fm0bu6Y5xgs9SMpy2bHRmqg1BT8Ipon5+9m8QcN d0ZgUxPNWufZPikYXAokvz8= X-Google-Smtp-Source: APXvYqzQsQ44BVWz/vW6bBrEGUlI6SGVLeAJJsMzlxtfqaOynTRjUm7Ad0PuFV490ZW5VmDg/i4WXw== X-Received: by 2002:adf:ef0b:: with SMTP id e11mr12777375wro.244.1553701480848; Wed, 27 Mar 2019 08:44:40 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id g84sm462752wmf.25.2019.03.27.08.44.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 08:44:39 -0700 (PDT) Message-ID: From: Luca Boccassi To: Aaron Conole , Bruce Richardson Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , "dev@dpdk.org" Date: Wed, 27 Mar 2019 15:44:39 +0000 In-Reply-To: References: <20190318162804.28974-1-jerinj@marvell.com> <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327154439.d2RZ6Khj3J8slbdxiiLmvR_pGfBWiYLtwGEo2hn4M50@z> On Wed, 2019-03-27 at 11:28 -0400, Aaron Conole wrote: > Bruce Richardson < > bruce.richardson@intel.com > > writes: >=20 > > On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote: > > > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran > > > wrote: > > > > From: Jerin Jacob < > > > > jerinj@marvell.com > > > > > > > > >=20 > > > > Remove the following meson build warnings > > > >=20 > > > > 1) WARNING: Project specifies a minimum meson_version '>=3D > > > > 0.47.1' > > > > but uses features which were added in newer versions: > > > > * 0.48.0: {'console arg in custom_target'} > > > >=20 > > > > 2) config/arm/meson.build:153: WARNING: Trying to compare > > > > values of > > > > different types (list, str) using =3D=3D. > > > >=20 > > > > Signed-off-by: Jerin Jacob < > > > > jerinj@marvell.com > > > > > > > > > --- > > > > config/arm/meson.build | 4 ++-- > > > > meson.build | 2 +- > > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > >=20 > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > > index 8e892fa77..170a4981a 100644 > > > > --- a/config/arm/meson.build > > > > +++ b/config/arm/meson.build > > > > @@ -116,8 +116,8 @@ else > > > > cmd_output =3D > > > > cmd.stdout().to_lower().strip().split(' ') > > > > endif > > > > # Set to generic if variable is not found > > > > - machine =3D get_variable('impl_' + cmd_output[0], > > > > 'generic') > > > > - if machine =3D=3D 'generic' > > > > + machine =3D get_variable('impl_' + cmd_output[0], > > > > ['generic']) > > > > + if machine[0] =3D=3D 'generic' > > > > machine =3D impl_generic > > > > cmd_output =3D cmd_generic > > > > endif > > > > diff --git a/meson.build b/meson.build > > > > index 69833de82..f1abf1e59 100644 > > > > --- a/meson.build > > > > +++ b/meson.build > > > > @@ -5,7 +5,7 @@ project('DPDK', 'C', > > > > version: '19.05.0-rc0', > > > > license: 'BSD', > > > > default_options: ['buildtype=3Drelease', > > > > 'default_library=3Dstatic'], > > > > - meson_version: '>=3D 0.47.1' > > > > + meson_version: '>=3D 0.48.0' > > > > ) > > > > =20 > > > > # set up some global vars for compiler, platform, > > > > configuration, > > > > etc. > > >=20 > > > Bumping minimum dependency requirements needs an approval from > > > the tech > > > board. Incidentally we just got it, and the bump to 0.47.1 just > > > happened. > > >=20 > > > You can remove this and ignore the warning about the console arg > > > - it's > > > harmless if ran on a previous version which does not support it. > > >=20 > >=20 > > +1 to this. The first fix is good though - perhaps do a V2 with > > just that. > >=20 > > Sadly meson warnings for versions have too many false positives > > right now - > > the devs are aware of it, but don't have any good fixes for it yet, > > as far > > as I know. For our case, we will continue to have meson warnings, > > most of > > which are false positives like this one. >=20 > In this case, though, the warning isn't a false positive. Here are > the > release notes for 0.48.0 that relate to the argument in question: >=20 > https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-not= es-for-0.48.0.md#new-kwarg-console-for-custom_target >=20 >=20 > I probably missed something. >=20 > > Incidentally, I've dropped my own patch related to this from a series > I > was developing to run tests on travis. I think it's a bit annoying > that > we need the techboard to decide for cases like these, but I guess > that's > just a fact of life. > The warning is correct, but it is harmless - simply the feature won't be available - I forget exactly what is was for, something to do with verbose console prints. Functionally speaking there's no difference. --=20 Kind regards, Luca Boccassi