From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2858D1B108; Thu, 28 Mar 2019 11:43:21 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 03:43:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="331478115" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 28 Mar 2019 03:43:16 -0700 Received: by (sSMTP sendmail emulation); Thu, 28 Mar 2019 10:43:14 +0000 Date: Thu, 28 Mar 2019 10:43:14 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: "Stojaczyk, Dariusz" , "dev@dpdk.org" , "Zhang, Qi Z" , "Burakov, Anatoly" , "stable@dpdk.org" Message-ID: <20190328104313.GA1418@bricha3-MOBL.ger.corp.intel.com> References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <2545420.xP4CxeWPSp@xps> <1752426.1oQredii45@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1752426.1oQredii45@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 10:43:21 -0000 On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote: > 27/03/2019 21:33, Stojaczyk, Dariusz: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 26/03/2019 19:43, Darek Stojaczyk: > > > > We currently initialize rte_alarms after starting > > > > to listen for IPC hotplug requests, which gives > > > > us a data race window. Upon receiving such hotplug > > > > request we always try to set an alarm and this > > > > obviously doesn't work if the alarms weren't > > > > initialized yet. > > > > > > > > To fix it, we initialize alarms before starting > > > > to listen for IPC hotplug messages. Specifically, > > > > we move rte_eal_alarm_init() right after > > > > rte_eal_intr_init() as it makes some sense to > > > > keep those two close to each other. > > > > > > I wonder which regression it will bring :) > > > The experience shows that we cannot touch this function > > > without introducing a regression. Please check twice. > > > > Hah, ok - I'll check again the possible outcomes of this. > > > > > > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > > > Cc: Qi Zhang > > > > Cc: Anatoly Burakov > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Darek Stojaczyk > > > > --- > > > > lib/librte_eal/linux/eal/eal.c | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > You probably need to update the FreeBSD version too. > > > > > > > Oh, that I cannot do. First of all, in bsd code I don't see > > rte_mp_dev_hotplug_init() called anywhere, as if bsd > > did not listen for IPC hotplug messages at all and hence did > > not have any data race in this area. Second, I would be > > afraid to touch any bsd code as I'm not running any bsd > > system. > > The problem is the consistency between OSes. > May you ask help here? Bruce is maintaining the FreeBSD side. > I don't think we support IPC or hotplug on BSD, so I don't think this patch is relevant on the BSD side. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1ED7AA067F for ; Thu, 28 Mar 2019 11:43:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DE9D1B137; Thu, 28 Mar 2019 11:43:23 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2858D1B108; Thu, 28 Mar 2019 11:43:21 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 03:43:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="331478115" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 28 Mar 2019 03:43:16 -0700 Received: by (sSMTP sendmail emulation); Thu, 28 Mar 2019 10:43:14 +0000 Date: Thu, 28 Mar 2019 10:43:14 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: "Stojaczyk, Dariusz" , "dev@dpdk.org" , "Zhang, Qi Z" , "Burakov, Anatoly" , "stable@dpdk.org" Message-ID: <20190328104313.GA1418@bricha3-MOBL.ger.corp.intel.com> References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <2545420.xP4CxeWPSp@xps> <1752426.1oQredii45@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1752426.1oQredii45@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328104314.Lx3J_Iwq8FYnJWFdeN5CHShDt-rarE7901gqhAK2KlY@z> On Wed, Mar 27, 2019 at 11:42:40PM +0100, Thomas Monjalon wrote: > 27/03/2019 21:33, Stojaczyk, Dariusz: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 26/03/2019 19:43, Darek Stojaczyk: > > > > We currently initialize rte_alarms after starting > > > > to listen for IPC hotplug requests, which gives > > > > us a data race window. Upon receiving such hotplug > > > > request we always try to set an alarm and this > > > > obviously doesn't work if the alarms weren't > > > > initialized yet. > > > > > > > > To fix it, we initialize alarms before starting > > > > to listen for IPC hotplug messages. Specifically, > > > > we move rte_eal_alarm_init() right after > > > > rte_eal_intr_init() as it makes some sense to > > > > keep those two close to each other. > > > > > > I wonder which regression it will bring :) > > > The experience shows that we cannot touch this function > > > without introducing a regression. Please check twice. > > > > Hah, ok - I'll check again the possible outcomes of this. > > > > > > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > > > Cc: Qi Zhang > > > > Cc: Anatoly Burakov > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Darek Stojaczyk > > > > --- > > > > lib/librte_eal/linux/eal/eal.c | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > You probably need to update the FreeBSD version too. > > > > > > > Oh, that I cannot do. First of all, in bsd code I don't see > > rte_mp_dev_hotplug_init() called anywhere, as if bsd > > did not listen for IPC hotplug messages at all and hence did > > not have any data race in this area. Second, I would be > > afraid to touch any bsd code as I'm not running any bsd > > system. > > The problem is the consistency between OSes. > May you ask help here? Bruce is maintaining the FreeBSD side. > I don't think we support IPC or hotplug on BSD, so I don't think this patch is relevant on the BSD side. /Bruce