DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
To: david.hunt@intel.com
Cc: dev@dpdk.org, Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Subject: [dpdk-dev] [PATCH] power: update for error handling
Date: Thu, 28 Mar 2019 16:55:07 +0100	[thread overview]
Message-ID: <20190328155507.3608-1-lukaszx.krakowiak@intel.com> (raw)
Message-ID: <20190328155507.W-QHT1pZ3BxqqSXN26YzOVgLM1d9ncVFUKf0-5mJ3uQ@z> (raw)

Update for handling negative returned status from functions
call.

Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
 examples/vm_power_manager/channel_manager.c | 4 ++--
 examples/vm_power_manager/channel_monitor.c | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
index de1a86891..09bfa5c0d 100644
--- a/examples/vm_power_manager/channel_manager.c
+++ b/examples/vm_power_manager/channel_manager.c
@@ -224,7 +224,7 @@ open_non_blocking_channel(struct channel_info *info)
 	struct timeval tv;
 
 	info->fd = socket(AF_UNIX, SOCK_STREAM, 0);
-	if (info->fd == -1) {
+	if (info->fd < 0) {
 		RTE_LOG(ERR, CHANNEL_MANAGER, "Error(%s) creating socket for '%s'\n",
 				strerror(errno),
 				info->channel_path);
@@ -285,7 +285,7 @@ open_host_channel(struct channel_info *info)
 	int flags;
 
 	info->fd = open(info->channel_path, O_RDWR | O_RSYNC);
-	if (info->fd == -1) {
+	if (info->fd < 0) {
 		RTE_LOG(ERR, CHANNEL_MANAGER, "Error(%s) opening fifo for '%s'\n",
 				strerror(errno),
 				info->channel_path);
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 1a3a0fa76..22f2eb819 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -435,7 +435,7 @@ update_policy(struct channel_packet *pkt)
 			/* Copy the contents of *pkt into the policy.pkt */
 			policies[i].pkt = *pkt;
 			get_pcpu_to_control(&policies[i]);
-			if (get_pfid(&policies[i]) == -1) {
+			if (get_pfid(&policies[i]) < 0) {
 				updated = 1;
 				break;
 			}
@@ -449,7 +449,7 @@ update_policy(struct channel_packet *pkt)
 			if (policies[i].enabled == 0) {
 				policies[i].pkt = *pkt;
 				get_pcpu_to_control(&policies[i]);
-				if (get_pfid(&policies[i]) == -1)
+				if (get_pfid(&policies[i]) < 0)
 					break;
 				core_share_status(i);
 				policies[i].enabled = 1;
@@ -756,7 +756,7 @@ read_binary_packet(struct channel_info *chan_info)
 				buffer, buffer_len);
 		if (n_bytes == buffer_len)
 			break;
-		if (n_bytes == -1) {
+		if (n_bytes < 0) {
 			err = errno;
 			RTE_LOG(DEBUG, CHANNEL_MONITOR,
 				"Received error on "
-- 
2.19.2.windows.1


             reply	other threads:[~2019-03-28 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 15:55 Lukasz Krakowiak [this message]
2019-03-28 15:55 ` Lukasz Krakowiak
2019-03-28 17:02 ` Burakov, Anatoly
2019-03-28 17:02   ` Burakov, Anatoly
2019-03-29 14:32   ` Thomas Monjalon
2019-03-29 14:32     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328155507.3608-1-lukaszx.krakowiak@intel.com \
    --to=lukaszx.krakowiak@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).