From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas
Date: Fri, 29 Mar 2019 05:22:54 +0000 [thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8462F3468@HASMSX105.ger.corp.intel.com> (raw)
Message-ID: <20190329052254.miEhVxKF_iaEsrTFr7defSmPV49UXqZQw52QzUGaKAI@z> (raw)
In-Reply-To: <1848003.AzJ49HI9Wz@xps>
This patch caused a regression. Any secondary process fails to initialize.
Please see the quick fix here: http://patchwork.dpdk.org/patch/51882/
D.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, March 28, 2019 9:45 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas
>
> 26/02/2019 18:13, Anatoly Burakov:
> > Currently, there are numerous reliability issues with fbarray,
> > such as:
> > - There is no way to prevent attaching to overlapping memory
> > areas
> > - There is no way to prevent double-detach
> > - Failed destroy leaves fbarray in an invalid state (fbarray
> > itself is valid, but its backing memory area is already
> > detached)
> >
> > In addition, on FreeBSD, doing mmap() on a file descriptor
> > does not keep the lock, so we also need to store the fd
> > in order to keep the lock.
> >
> > This patch improves upon fbarray to address both of these
> > issues by adding an internal tailq to track allocated areas
> > and their respective file descriptors.
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Applied, thanks
>
>
next prev parent reply other threads:[~2019-03-29 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 17:13 Anatoly Burakov
2019-03-28 20:44 ` Thomas Monjalon
2019-03-28 20:44 ` Thomas Monjalon
2019-03-29 5:22 ` Stojaczyk, Dariusz [this message]
2019-03-29 5:22 ` Stojaczyk, Dariusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8462F3468@HASMSX105.ger.corp.intel.com \
--to=dariusz.stojaczyk@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).