From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9D2AC2BF4
for <dev@dpdk.org>; Fri, 29 Mar 2019 14:58:52 +0100 (CET)
Received: by mail-wm1-f67.google.com with SMTP id z24so2952498wmi.5
for <dev@dpdk.org>; Fri, 29 Mar 2019 06:58:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to;
bh=mh4MLMazfj5OzkW9vITfK/LTYenrtvjMTNmHAqUMSB4=;
b=Ax02eO5m1hoVGf1eddsS7Pe5tndMCyizvmUC/ZOwS9gfTzoC/K5IWF02O8cm8r+EtQ
SCmi+manybqmCzUxRaLLUuzex30wLlOXP9rzRMGHyWs2WWKPwohkLlBMeATqFeN4KI9x
aSu8z++MngJ29PEWX/CMys4F1EvKsDT7rcysKdTLm5xpX38+KBlpz7/U3FyJ9E9HndDz
NpudGN7MDa0H7LfefsldDomEVc5XzBMze1M0BonWyGsLTyTFLmbAerceySQxmtuLzcux
3yRlrRuQpEmmHD3IqcZP8laLc7A6uQuQMQI/NlwsDC0JhAx9pmET97LVXKFA/keTu24/
WmKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to;
bh=mh4MLMazfj5OzkW9vITfK/LTYenrtvjMTNmHAqUMSB4=;
b=FTH8Sq2BinFwJuwJDiGbNiZ4AskBEV4guLWGh2SPVq/OTMJF+fKIvynRbOJK9pHybV
RELshNWc0Ds1Ni96CxK3+OcbAHc5IgEwiUPerd7d3vkwUgTLEE17tsoEhoSBxzywVrDJ
Pk5CCtrKV4P0c7tqrKyn1VD3EjC8FYDm2SLPLXioeGPe+X6yxQGneQWdyubBpHmXHRud
u+ZtUzQG1z9gDkFHqZQ1yswDYP9L+uXTWD4vcfn1p/+w1RPlB/w4dKuDaJng1tcmKcVd
MhA4InBPKLMfalVjKiBKxy35iPaIE/I/S3vY98XmMLvv+e+k0GqBM4vRRDiGfSxoh6m/
B//w==
X-Gm-Message-State: APjAAAXv/aFwXfBOg+vvnB0QR1FYIz7q3XbCOa5lskATA/7k771YDTK9
icUDKKUSi8Xx91MBjBMRC2IHbQ==
X-Google-Smtp-Source: APXvYqz+hpcdAf05CX+ob1vEUYppnIk2IxC/RBAh7XljBtU5Rj9oBvWUn/DcXJrqmB9N9mpsP9djNg==
X-Received: by 2002:a1c:c287:: with SMTP id s129mr3851671wmf.63.1553867932353;
Fri, 29 Mar 2019 06:58:52 -0700 (PDT)
Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id r63sm3229711wmr.32.2019.03.29.06.58.51
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 29 Mar 2019 06:58:51 -0700 (PDT)
Date: Fri, 29 Mar 2019 14:58:50 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, yskoh@mellanox.com,
shahafs@mellanox.com, dev@dpdk.org, orika@mellanox.com
Message-ID: <20190329135850.GH4889@6wind.com>
References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com>
<1553177917-43297-2-git-send-email-dekelp@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1553177917-43297-2-git-send-email-dekelp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP header
fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Mar 2019 13:58:52 -0000
Hi Derek,
It's been a while since I last reviewed something, sorry it took so long.
Some comments below.
On Thu, Mar 21, 2019 at 04:18:35PM +0200, Dekel Peled wrote:
> Add actions:
> - INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
> - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
> - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
> header.
> - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP
> header.
Out of curiosity, are these upcoming/existing OpenFlow actions? If so you
should consider prefixing them with "OF_", otherwise leave them as is.
> Original work by Xiaoyu Min.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/prog_guide/rte_flow.rst | 72 ++++++++++++++++++++++++++++++++++++++
> lib/librte_ethdev/rte_flow.c | 8 +++++
> lib/librte_ethdev/rte_flow.h | 60 +++++++++++++++++++++++++++++++
> 3 files changed, 140 insertions(+)
>
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index 0203f4f..bdb817a 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
> | ``mac_addr`` | MAC address |
> +--------------+---------------+
>
> +Action: ``INC_TCP_SEQ``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Increase sequence number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
I know this is already present for various SET* actions, but please do not
tie actions to the presence of specific pattern items at the API level. You
can describe that the lack of a TCP header in matched *traffic* results in
unspecified behavior though.
Then PMD documentation can describe that the lack of a TCP pattern item with
this action results in RTE_FLOW_ERROR_TYPE_ACTION as a PMD-specific
constraint.
> +
> +.. _table_rte_flow_action_inc_tcp_seq:
> +
> +.. table:: INC_TCP_SEQ
> +
> + +-----------+--------------------------------------------+
> + | Field | Value |
> + +===========+============================================+
> + | ``value`` | Value to increase TCP sequence number by |
> + +-----------+--------------------------------------------+
Nit: unnecessary empty space after "by".
> +
> +Action: ``DEC_TCP_SEQ``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Decrease sequence number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Same comment as above.
> +
> +.. _table_rte_flow_action_dec_tcp_seq:
> +
> +.. table:: DEC_TCP_SEQ
> +
> + +-----------+--------------------------------------------+
> + | Field | Value |
> + +===========+============================================+
> + | ``value`` | Value to decrease TCP sequence number by |
> + +-----------+--------------------------------------------+
> +
> +Action: ``INC_TCP_ACK``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Increase acknowledgment number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Ditto.
> +
> +.. _table_rte_flow_action_inc_tcp_ack:
> +
> +.. table:: INC_TCP_ACK
> +
> + +-----------+--------------------------------------------------+
> + | Field | Value |
> + +===========+==================================================+
> + | ``value`` | Value to increase TCP acknowledgment number by |
> + +-----------+--------------------------------------------------+
> +
> +Action: ``DEC_TCP_ACK``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Decrease acknowledgment number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Ditto.
> +
> +.. _table_rte_flow_action_dec_tcp_ack:
> +
> +.. table:: DEC_TCP_ACK
> +
> + +-----------+--------------------------------------------------+
> + | Field | Value |
> + +===========+==================================================+
> + | ``value`` | Value to decrease TCP acknowledgment number by |
> + +-----------+--------------------------------------------------+
> +
> Negative types
> ~~~~~~~~~~~~~~
>
> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
> index 3277be1..589d0b9 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -143,6 +143,14 @@ struct rte_flow_desc_data {
> MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)),
> MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)),
> MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)),
> + MK_FLOW_ACTION(INC_TCP_SEQ,
> + sizeof(struct rte_flow_action_modify_tcp_seq)),
> + MK_FLOW_ACTION(DEC_TCP_SEQ,
> + sizeof(struct rte_flow_action_modify_tcp_seq)),
> + MK_FLOW_ACTION(INC_TCP_ACK,
> + sizeof(struct rte_flow_action_modify_tcp_ack)),
> + MK_FLOW_ACTION(DEC_TCP_ACK,
> + sizeof(struct rte_flow_action_modify_tcp_ack)),
> };
>
> static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index c0fe879..74cd03e 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1651,6 +1651,46 @@ enum rte_flow_action_type {
> * See struct rte_flow_action_set_mac.
> */
> RTE_FLOW_ACTION_TYPE_SET_MAC_DST,
> +
> + /**
> + * Increase sequence number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
Ditto.
> + *
> + * See struct rte_flow_action_modify_tcp_seq
> + */
> + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ,
> +
> + /**
> + * Decrease sequence number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
Ditto.
> + *
> + * See struct rte_flow_action_modify_tcp_seq
> + */
> + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ,
> +
> + /**
> + * Increase acknowledgment number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
> + *
Ditto.
> + * See struct rte_flow_action_modify_tcp_ack
> + */
> + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK,
> +
> + /**
> + * Decrease acknowledgment number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
> + *
Ditto.
> + * See struct rte_flow_action_modify_tcp_ack
> + */
> + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK,
> };
>
> /**
> @@ -2122,6 +2162,26 @@ struct rte_flow_action_set_mac {
> uint8_t mac_addr[ETHER_ADDR_LEN];
> };
>
> +/**
Experimental tag is missing.
> + * RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ
> + * RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ
> + *
> + * Increase/Decrease outermost TCP's sequence number
Suggestion:
Increase/decrease outermost TCP sequence number.
> + */
> +struct rte_flow_action_modify_tcp_seq {
> + rte_be32_t value;
Field documentation is mandatory, e.g.:
rte_be32_t value; /**< Value to add/subtract. */
Beside, I'm not sure this value should be big endian since it's not stored
as is in the TCP header; it's used by the host system to compute a new
value.
Also what about having another field to specify what needs to be done with
this value (e.g. add/sub/set - in which case big endian makes sense) to
reduce the number of new actions? Something like:
struct rte_flow_action_mod_tcp_seq {
enum rte_flow_action_mod_tcp_seq_op {
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_ADD,
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_SUB,
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_SET,
} op; /**< Operation to perform. */
rte_be32_t value; /**< Value to use with operation. */
};
> +};
> +
> +/**
Experimental tag also missing.
> + * RTE_FLOW_ACTION_TYPE_INC_TCP_ACK
> + * RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK
> + *
> + * Increase/Decrease TCP's acknowledgment number.
Suggestion:
Increase/decrease outermost TCP acknowledgment number.
> + */
> +struct rte_flow_action_modify_tcp_ack {
> + rte_be32_t value;
Field documentation also missing.
> +};
> +
> /*
> * Definition of a single action.
> *
> --
> 1.8.3.1
>
--
Adrien Mazarguil
6WIND
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 43C86A05D3
for <public@inbox.dpdk.org>; Fri, 29 Mar 2019 14:58:53 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 090FE3256;
Fri, 29 Mar 2019 14:58:53 +0100 (CET)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9D2AC2BF4
for <dev@dpdk.org>; Fri, 29 Mar 2019 14:58:52 +0100 (CET)
Received: by mail-wm1-f67.google.com with SMTP id z24so2952498wmi.5
for <dev@dpdk.org>; Fri, 29 Mar 2019 06:58:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to;
bh=mh4MLMazfj5OzkW9vITfK/LTYenrtvjMTNmHAqUMSB4=;
b=Ax02eO5m1hoVGf1eddsS7Pe5tndMCyizvmUC/ZOwS9gfTzoC/K5IWF02O8cm8r+EtQ
SCmi+manybqmCzUxRaLLUuzex30wLlOXP9rzRMGHyWs2WWKPwohkLlBMeATqFeN4KI9x
aSu8z++MngJ29PEWX/CMys4F1EvKsDT7rcysKdTLm5xpX38+KBlpz7/U3FyJ9E9HndDz
NpudGN7MDa0H7LfefsldDomEVc5XzBMze1M0BonWyGsLTyTFLmbAerceySQxmtuLzcux
3yRlrRuQpEmmHD3IqcZP8laLc7A6uQuQMQI/NlwsDC0JhAx9pmET97LVXKFA/keTu24/
WmKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to;
bh=mh4MLMazfj5OzkW9vITfK/LTYenrtvjMTNmHAqUMSB4=;
b=FTH8Sq2BinFwJuwJDiGbNiZ4AskBEV4guLWGh2SPVq/OTMJF+fKIvynRbOJK9pHybV
RELshNWc0Ds1Ni96CxK3+OcbAHc5IgEwiUPerd7d3vkwUgTLEE17tsoEhoSBxzywVrDJ
Pk5CCtrKV4P0c7tqrKyn1VD3EjC8FYDm2SLPLXioeGPe+X6yxQGneQWdyubBpHmXHRud
u+ZtUzQG1z9gDkFHqZQ1yswDYP9L+uXTWD4vcfn1p/+w1RPlB/w4dKuDaJng1tcmKcVd
MhA4InBPKLMfalVjKiBKxy35iPaIE/I/S3vY98XmMLvv+e+k0GqBM4vRRDiGfSxoh6m/
B//w==
X-Gm-Message-State: APjAAAXv/aFwXfBOg+vvnB0QR1FYIz7q3XbCOa5lskATA/7k771YDTK9
icUDKKUSi8Xx91MBjBMRC2IHbQ==
X-Google-Smtp-Source: APXvYqz+hpcdAf05CX+ob1vEUYppnIk2IxC/RBAh7XljBtU5Rj9oBvWUn/DcXJrqmB9N9mpsP9djNg==
X-Received: by 2002:a1c:c287:: with SMTP id s129mr3851671wmf.63.1553867932353;
Fri, 29 Mar 2019 06:58:52 -0700 (PDT)
Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id r63sm3229711wmr.32.2019.03.29.06.58.51
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 29 Mar 2019 06:58:51 -0700 (PDT)
Date: Fri, 29 Mar 2019 14:58:50 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, yskoh@mellanox.com,
shahafs@mellanox.com, dev@dpdk.org, orika@mellanox.com
Message-ID: <20190329135850.GH4889@6wind.com>
References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com>
<1553177917-43297-2-git-send-email-dekelp@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <1553177917-43297-2-git-send-email-dekelp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP header
fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190329135850.tEwKqn8WRYagl0ex_gp_2b9yC3AsRAOSnX69d69yBwM@z>
Hi Derek,
It's been a while since I last reviewed something, sorry it took so long.
Some comments below.
On Thu, Mar 21, 2019 at 04:18:35PM +0200, Dekel Peled wrote:
> Add actions:
> - INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
> - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
> - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
> header.
> - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP
> header.
Out of curiosity, are these upcoming/existing OpenFlow actions? If so you
should consider prefixing them with "OF_", otherwise leave them as is.
> Original work by Xiaoyu Min.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/prog_guide/rte_flow.rst | 72 ++++++++++++++++++++++++++++++++++++++
> lib/librte_ethdev/rte_flow.c | 8 +++++
> lib/librte_ethdev/rte_flow.h | 60 +++++++++++++++++++++++++++++++
> 3 files changed, 140 insertions(+)
>
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index 0203f4f..bdb817a 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
> | ``mac_addr`` | MAC address |
> +--------------+---------------+
>
> +Action: ``INC_TCP_SEQ``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Increase sequence number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
I know this is already present for various SET* actions, but please do not
tie actions to the presence of specific pattern items at the API level. You
can describe that the lack of a TCP header in matched *traffic* results in
unspecified behavior though.
Then PMD documentation can describe that the lack of a TCP pattern item with
this action results in RTE_FLOW_ERROR_TYPE_ACTION as a PMD-specific
constraint.
> +
> +.. _table_rte_flow_action_inc_tcp_seq:
> +
> +.. table:: INC_TCP_SEQ
> +
> + +-----------+--------------------------------------------+
> + | Field | Value |
> + +===========+============================================+
> + | ``value`` | Value to increase TCP sequence number by |
> + +-----------+--------------------------------------------+
Nit: unnecessary empty space after "by".
> +
> +Action: ``DEC_TCP_SEQ``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Decrease sequence number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Same comment as above.
> +
> +.. _table_rte_flow_action_dec_tcp_seq:
> +
> +.. table:: DEC_TCP_SEQ
> +
> + +-----------+--------------------------------------------+
> + | Field | Value |
> + +===========+============================================+
> + | ``value`` | Value to decrease TCP sequence number by |
> + +-----------+--------------------------------------------+
> +
> +Action: ``INC_TCP_ACK``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Increase acknowledgment number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Ditto.
> +
> +.. _table_rte_flow_action_inc_tcp_ack:
> +
> +.. table:: INC_TCP_ACK
> +
> + +-----------+--------------------------------------------------+
> + | Field | Value |
> + +===========+==================================================+
> + | ``value`` | Value to increase TCP acknowledgment number by |
> + +-----------+--------------------------------------------------+
> +
> +Action: ``DEC_TCP_ACK``
> +^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Decrease acknowledgment number in the outermost TCP header.
> +
> +It must be used with a valid RTE_FLOW_ITEM_TYPE_TCP flow pattern item.
> +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
Ditto.
> +
> +.. _table_rte_flow_action_dec_tcp_ack:
> +
> +.. table:: DEC_TCP_ACK
> +
> + +-----------+--------------------------------------------------+
> + | Field | Value |
> + +===========+==================================================+
> + | ``value`` | Value to decrease TCP acknowledgment number by |
> + +-----------+--------------------------------------------------+
> +
> Negative types
> ~~~~~~~~~~~~~~
>
> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
> index 3277be1..589d0b9 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -143,6 +143,14 @@ struct rte_flow_desc_data {
> MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)),
> MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)),
> MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)),
> + MK_FLOW_ACTION(INC_TCP_SEQ,
> + sizeof(struct rte_flow_action_modify_tcp_seq)),
> + MK_FLOW_ACTION(DEC_TCP_SEQ,
> + sizeof(struct rte_flow_action_modify_tcp_seq)),
> + MK_FLOW_ACTION(INC_TCP_ACK,
> + sizeof(struct rte_flow_action_modify_tcp_ack)),
> + MK_FLOW_ACTION(DEC_TCP_ACK,
> + sizeof(struct rte_flow_action_modify_tcp_ack)),
> };
>
> static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index c0fe879..74cd03e 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1651,6 +1651,46 @@ enum rte_flow_action_type {
> * See struct rte_flow_action_set_mac.
> */
> RTE_FLOW_ACTION_TYPE_SET_MAC_DST,
> +
> + /**
> + * Increase sequence number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
Ditto.
> + *
> + * See struct rte_flow_action_modify_tcp_seq
> + */
> + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ,
> +
> + /**
> + * Decrease sequence number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
Ditto.
> + *
> + * See struct rte_flow_action_modify_tcp_seq
> + */
> + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ,
> +
> + /**
> + * Increase acknowledgment number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
> + *
Ditto.
> + * See struct rte_flow_action_modify_tcp_ack
> + */
> + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK,
> +
> + /**
> + * Decrease acknowledgment number in the outermost TCP header.
> + *
> + * If flow pattern does not define a valid RTE_FLOW_ITEM_TYPE_TCP,
> + * the PMD should return a RTE_FLOW_ERROR_TYPE_ACTION error.
> + *
Ditto.
> + * See struct rte_flow_action_modify_tcp_ack
> + */
> + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK,
> };
>
> /**
> @@ -2122,6 +2162,26 @@ struct rte_flow_action_set_mac {
> uint8_t mac_addr[ETHER_ADDR_LEN];
> };
>
> +/**
Experimental tag is missing.
> + * RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ
> + * RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ
> + *
> + * Increase/Decrease outermost TCP's sequence number
Suggestion:
Increase/decrease outermost TCP sequence number.
> + */
> +struct rte_flow_action_modify_tcp_seq {
> + rte_be32_t value;
Field documentation is mandatory, e.g.:
rte_be32_t value; /**< Value to add/subtract. */
Beside, I'm not sure this value should be big endian since it's not stored
as is in the TCP header; it's used by the host system to compute a new
value.
Also what about having another field to specify what needs to be done with
this value (e.g. add/sub/set - in which case big endian makes sense) to
reduce the number of new actions? Something like:
struct rte_flow_action_mod_tcp_seq {
enum rte_flow_action_mod_tcp_seq_op {
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_ADD,
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_SUB,
RTE_FLOW_ACTION_MOD_TCP_SEQ_OP_SET,
} op; /**< Operation to perform. */
rte_be32_t value; /**< Value to use with operation. */
};
> +};
> +
> +/**
Experimental tag also missing.
> + * RTE_FLOW_ACTION_TYPE_INC_TCP_ACK
> + * RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK
> + *
> + * Increase/Decrease TCP's acknowledgment number.
Suggestion:
Increase/decrease outermost TCP acknowledgment number.
> + */
> +struct rte_flow_action_modify_tcp_ack {
> + rte_be32_t value;
Field documentation also missing.
> +};
> +
> /*
> * Definition of a single action.
> *
> --
> 1.8.3.1
>
--
Adrien Mazarguil
6WIND