Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

[Akhil Goyal <akhil.goyal@nxp.com>]

On 3/20/2019 7:02 PM, Fan Zhang wrote:
> This patch changes the key pointer data types in cipher, auth,
> and aead xforms from "uint8_t *" to "const uint8_t *" for a
> more intuitive and safe sessionn creation.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v3:
> - rebased on top of latest dpdk-next-crypto
>
> v2:
> - fixed a missed memory free for ixgbe ipsec
>   drivers/common/cpt/cpt_ucode.h                  | 14 ++---
>   drivers/crypto/aesni_gcm/aesni_gcm_pmd.c        |  2 +-
>   drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c      |  2 +-
>   drivers/crypto/openssl/rte_openssl_pmd.c        |  8 +--
>   drivers/crypto/qat/qat_sym_session.c            |  8 +--
>   drivers/crypto/qat/qat_sym_session.h            |  4 +-
>   drivers/crypto/snow3g/rte_snow3g_pmd.c          | 23 ++++++--
>   drivers/crypto/snow3g/rte_snow3g_pmd_private.h  |  1 +
>   drivers/crypto/virtio/virtio_cryptodev.c        | 30 +++++++---
>   drivers/crypto/virtio/virtio_cryptodev.h        |  2 +
>   drivers/net/ixgbe/ixgbe_ipsec.c                 | 35 +++++++++---
>   drivers/net/ixgbe/ixgbe_ipsec.h                 |  3 +-
>   drivers/net/softnic/rte_eth_softnic_cli.c       | 74 ++++++++++++-------------
>   drivers/net/softnic/rte_eth_softnic_internals.h |  4 ++
>   examples/ip_pipeline/cli.c                      | 74 ++++++++++++-------------
>   examples/ip_pipeline/cryptodev.c                |  2 -
>   examples/ip_pipeline/pipeline.h                 |  6 ++
>   examples/l2fwd-crypto/main.c                    | 40 +++++--------
>   lib/librte_cryptodev/rte_crypto_sym.h           | 12 ++--
>   19 files changed, 190 insertions(+), 154 deletions(-)
>
>
I believe this patch should be applied to master.
This has changes for net and virtio pmds.

for librte_cryptodev, and l2fwd-crypto

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>