DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>,
	dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum
Date: Fri, 29 Mar 2019 15:18:52 +0100	[thread overview]
Message-ID: <20190329141852.h2kr3axi4cqdix6n@platinum> (raw)
In-Reply-To: <1553866934-21871-1-git-send-email-arybchenko@solarflare.com>

On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote:
> rte_validate_tx_offload() is used in Tx prepare callbacks
> (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency.
> Requirement that packet headers should not be fragmented is not
> documented and unclear where it comes from except
> rte_net_intel_cksum_prepare() functions which relies on it.
> 
> It could be NIC vendor specific driver or hardware limitation, but,
> if so, it should be documented and checked in corresponding Tx
> prepare callbacks.
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks!

  parent reply	other threads:[~2019-03-29 14:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  8:49 [dpdk-dev] [RFC PATCH] " Andrew Rybchenko
2019-02-13  9:50 ` Andrew Rybchenko
2019-02-13 14:48   ` Wiles, Keith
2019-02-13 23:27 ` Ananyev, Konstantin
2019-02-19  6:30 ` [dpdk-dev] [PATCH] " Andrew Rybchenko
2019-03-28 17:04   ` Andrew Rybchenko
2019-03-28 17:04     ` Andrew Rybchenko
2019-03-29 13:09     ` Olivier Matz
2019-03-29 13:09       ` Olivier Matz
2019-03-29 13:30       ` Andrew Rybchenko
2019-03-29 13:30         ` Andrew Rybchenko
2019-03-29 13:42 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2019-03-29 13:42   ` Andrew Rybchenko
2019-03-29 14:18   ` Olivier Matz [this message]
2019-03-29 14:18     ` Olivier Matz
2019-04-02 14:48     ` Thomas Monjalon
2019-04-02 14:48       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329141852.h2kr3axi4cqdix6n@platinum \
    --to=olivier.matz@6wind.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=tomaszx.kulasek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).