From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id DCD323256 for ; Fri, 29 Mar 2019 15:18:57 +0100 (CET) Received: from lfbn-1-5920-128.w90-110.abo.wanadoo.fr ([90.110.126.128] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9sNj-0002Iy-Rq; Fri, 29 Mar 2019 15:21:21 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 29 Mar 2019 15:18:52 +0100 Date: Fri, 29 Mar 2019 15:18:52 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: Tomasz Kulasek , dev@dpdk.org, Konstantin Ananyev Message-ID: <20190329141852.h2kr3axi4cqdix6n@platinum> References: <1548751746-16030-1-git-send-email-arybchenko@solarflare.com> <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 14:18:58 -0000 On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote: > rte_validate_tx_offload() is used in Tx prepare callbacks > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > Requirement that packet headers should not be fragmented is not > documented and unclear where it comes from except > rte_net_intel_cksum_prepare() functions which relies on it. > > It could be NIC vendor specific driver or hardware limitation, but, > if so, it should be documented and checked in corresponding Tx > prepare callbacks. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7E35FA05D3 for ; Fri, 29 Mar 2019 15:18:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 592483576; Fri, 29 Mar 2019 15:18:58 +0100 (CET) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id DCD323256 for ; Fri, 29 Mar 2019 15:18:57 +0100 (CET) Received: from lfbn-1-5920-128.w90-110.abo.wanadoo.fr ([90.110.126.128] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9sNj-0002Iy-Rq; Fri, 29 Mar 2019 15:21:21 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 29 Mar 2019 15:18:52 +0100 Date: Fri, 29 Mar 2019 15:18:52 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: Tomasz Kulasek , dev@dpdk.org, Konstantin Ananyev Message-ID: <20190329141852.h2kr3axi4cqdix6n@platinum> References: <1548751746-16030-1-git-send-email-arybchenko@solarflare.com> <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1553866934-21871-1-git-send-email-arybchenko@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329141852.YSA7IBaZRRi-YM87KTnED72cuyA053r2nPE4jyVOKgA@z> On Fri, Mar 29, 2019 at 01:42:14PM +0000, Andrew Rybchenko wrote: > rte_validate_tx_offload() is used in Tx prepare callbacks > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > Requirement that packet headers should not be fragmented is not > documented and unclear where it comes from except > rte_net_intel_cksum_prepare() functions which relies on it. > > It could be NIC vendor specific driver or hardware limitation, but, > if so, it should be documented and checked in corresponding Tx > prepare callbacks. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz Thanks!