From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, Ian Stokes <ian.stokes@intel.com>
Subject: [dpdk-dev] [PATCH v3 4/7] net/ixgbe: set min and max MTU for ixgbe devices
Date: Fri, 29 Mar 2019 17:52:16 +0000 [thread overview]
Message-ID: <20190329175219.23831-4-ferruh.yigit@intel.com> (raw)
Message-ID: <20190329175216.Fcuden6tFIV8poH3y6mphYcRznDs6CqX6-d3eGQDwwE@z> (raw)
In-Reply-To: <20190329175219.23831-1-ferruh.yigit@intel.com>
From: Ian Stokes <ian.stokes@intel.com>
This commit sets the min and max supported MTU values for ixgbe devices
via the ixgbe_dev_info_get() function. Min MTU supported is set to
ETHER_MIN_MTU and max mtu is calculated as the max packet length
supported minus the transport overhead. To aid in these calculations
a new MACRO 'IXGBE_ETH_OVERHEAD' has been introduced to consolidate
overhead calculation and avoid duplication.
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 97e10217d..60da3508c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3748,6 +3748,8 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->max_vmdq_pools = ETH_16_POOLS;
else
dev_info->max_vmdq_pools = ETH_64_POOLS;
+ dev_info->max_mtu = dev_info->max_rx_pktlen - IXGBE_ETH_OVERHEAD;
+ dev_info->min_mtu = ETHER_MIN_MTU;
dev_info->vmdq_queue_num = dev_info->max_rx_queues;
dev_info->rx_queue_offload_capa = ixgbe_get_rx_queue_offloads(dev);
dev_info->rx_offload_capa = (ixgbe_get_rx_port_offloads(dev) |
@@ -4939,7 +4941,7 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
uint32_t maxfrs;
struct ixgbe_hw *hw;
struct rte_eth_dev_info dev_info;
- uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;
+ uint32_t frame_size = mtu + IXGBE_ETH_OVERHEAD;
struct rte_eth_dev_data *dev_data = dev->data;
ixgbe_dev_info_get(dev, &dev_info);
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index 3fec61352..d1f61e85e 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.h
+++ b/drivers/net/ixgbe/ixgbe_ethdev.h
@@ -101,6 +101,9 @@
#define IXGBE_5TUPLE_MAX_PRI 7
#define IXGBE_5TUPLE_MIN_PRI 1
+/* The overhead from MTU to max frame size. */
+#define IXGBE_ETH_OVERHEAD (ETHER_HDR_LEN + ETHER_CRC_LEN)
+
/* bit of VXLAN tunnel type | 7 bits of zeros | 8 bits of zeros*/
#define IXGBE_FDIR_VXLAN_TUNNEL_TYPE 0x8000
/* bit of NVGRE tunnel type | 7 bits of zeros | 8 bits of zeros*/
--
2.20.1
next prev parent reply other threads:[~2019-03-29 17:52 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:01 [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 1/7] " Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-25 14:26 ` Ferruh Yigit
2019-03-25 14:26 ` Ferruh Yigit
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 2/7] net/i40e: set min and max MTU for i40e devices Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 3/7] net/i40e: set min and max MTU for i40e VF devices Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 4/7] net/ixgbe: set min and max MTU for ixgbe devices Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 5/7] net/ixgbe: set min and max MTU for ixgbe VF devices Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-25 14:25 ` Ferruh Yigit
2019-03-25 14:25 ` Ferruh Yigit
2019-03-26 13:58 ` Zhang, Qi Z
2019-03-26 13:58 ` Zhang, Qi Z
2019-03-26 14:02 ` Ananyev, Konstantin
2019-03-26 14:02 ` Ananyev, Konstantin
2019-03-26 14:09 ` Zhang, Qi Z
2019-03-26 14:09 ` Zhang, Qi Z
2019-03-26 14:18 ` Ananyev, Konstantin
2019-03-26 14:18 ` Ananyev, Konstantin
2019-03-27 1:13 ` Zhang, Qi Z
2019-03-27 1:13 ` Zhang, Qi Z
2019-03-27 7:02 ` Zhang, Qi Z
2019-03-27 7:02 ` Zhang, Qi Z
2019-03-22 13:01 ` [dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get() Ian Stokes
2019-03-22 13:01 ` Ian Stokes
2019-03-25 14:20 ` Ferruh Yigit
2019-03-25 14:20 ` Ferruh Yigit
2019-03-28 16:41 ` Ferruh Yigit
2019-03-28 16:41 ` Ferruh Yigit
2019-03-28 16:43 ` [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info Ferruh Yigit
2019-03-28 16:43 ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 1/7] " Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 2/7] net/i40e: set min and max MTU for i40e devices Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 3/7] net/i40e: set min and max MTU for i40e VF devices Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit [this message]
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 4/7] net/ixgbe: set min and max MTU for ixgbe devices Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 5/7] net/ixgbe: set min and max MTU for ixgbe VF devices Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 6/7] net/e1000: set min and max MTU for igb devices Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:52 ` [dpdk-dev] [PATCH v3 7/7] app/testpmd: verify MTU with device provided limits Ferruh Yigit
2019-03-29 17:52 ` Ferruh Yigit
2019-03-29 17:56 ` [dpdk-dev] [PATCH v3 1/7] ethdev: add min/max MTU to device info Ferruh Yigit
2019-03-29 17:56 ` Ferruh Yigit
2019-03-29 18:05 ` Ferruh Yigit
2019-03-29 18:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329175219.23831-4-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).