From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id ED894A05D3
for <public@inbox.dpdk.org>; Fri, 29 Mar 2019 19:47:03 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id DBEE94C96;
Fri, 29 Mar 2019 19:47:02 +0100 (CET)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 5580D37A2;
Fri, 29 Mar 2019 19:47:01 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
29 Mar 2019 11:47:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,285,1549958400"; d="scan'208";a="135971745"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2019 11:47:00 -0700
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Fri, 29 Mar 2019 11:47:00 -0700
Received: from fmsmsx120.amr.corp.intel.com ([169.254.15.249]) by
FMSMSX157.amr.corp.intel.com ([169.254.14.37]) with mapi id 14.03.0415.000;
Fri, 29 Mar 2019 11:46:59 -0700
From: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>, "Zhao1, Wei" <wei.zhao1@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for
x553
Thread-Index: AQHU5guQJeEWx7P5KEaP4nUX0JqDy6Yi8xhw
Date: Fri, 29 Mar 2019 18:46:59 +0000
Message-ID:
<F8A4ECA1C1D86B4081DD6BF503D1F436C746BA94@fmsmsx120.amr.corp.intel.com>
References: <1553844685-52291-1-git-send-email-wei.zhao1@intel.com>
<1553847345-54013-1-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1553847345-54013-1-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2U5YjgyYzgtYWJmMy00OWQzLTlhODUtYmE4ZDgwMzM0Y2VlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNzlcLzZoODQ3M1lGM2dqcmVDR2VGRVwvR21WWUhtTFlZTEZXWHlBWW9mcWlKS0Q4OElldmtBb3lDaVdWVW0zYlo4In0=
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.1.200.106]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for
x553
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190329184659.HMh7lIr9R2xunjYU2crY-3h9-f4RM_-W2SWCxgyzTOk@z>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Zhao
> Sent: Friday, March 29, 2019 1:16 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x5=
53
>=20
> There is need to eanble 10Mb/s link foixgbe NIC of x553.
Couple of typos, how about:
Enable 10Mb/s link for ixgbe x553.
> This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD driv=
er
> need to special check when setup link for these two types of device.
>=20
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>=20
> ---
>=20
> v2:
> delete test code and change permit link speed
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 97e1021..0aef577 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
> allowed_speeds =3D ETH_LINK_SPEED_100M |
> ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_2_5G | ETH_LINK_SPEED_5G |
> ETH_LINK_SPEED_10G;
> + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T ||
> + hw->device_id =3D=3D
> IXGBE_DEV_ID_X550EM_A_1G_T_L)
> + allowed_speeds =3D ETH_LINK_SPEED_10M |
> + ETH_LINK_SPEED_100M |
> ETH_LINK_SPEED_1G;
> break;
> default:
> allowed_speeds =3D ETH_LINK_SPEED_100M |
> ETH_LINK_SPEED_1G | @@ -2742,6 +2746,8 @@ static int
> eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
> speed |=3D IXGBE_LINK_SPEED_1GB_FULL;
> if (*link_speeds & ETH_LINK_SPEED_100M)
> speed |=3D IXGBE_LINK_SPEED_100_FULL;
> + if (*link_speeds & ETH_LINK_SPEED_10M)
> + speed |=3D IXGBE_LINK_SPEED_10_FULL;
> }
>=20
> err =3D ixgbe_setup_link(hw, speed, link_up); @@ -4061,8 +4067,12
> @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct
> rte_eth_dev *dev,
> switch (link_speed) {
> default:
> case IXGBE_LINK_SPEED_UNKNOWN:
> + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T ||
> + hw->device_id =3D=3D
> IXGBE_DEV_ID_X550EM_A_1G_T_L)
> + link.link_speed =3D ETH_SPEED_NUM_10M;
> + else
> + link.link_speed =3D ETH_SPEED_NUM_100M;
> link.link_duplex =3D ETH_LINK_FULL_DUPLEX;
> - link.link_speed =3D ETH_SPEED_NUM_100M;
> break;
>=20
> case IXGBE_LINK_SPEED_100_FULL:
> --
> 1.8.3.1