* [dpdk-dev] [PATCH] power: extend debugs on power instruction requests
@ 2019-03-28 16:11 Lukasz Krakowiak
2019-03-28 16:11 ` Lukasz Krakowiak
2019-03-29 22:35 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Lukasz Krakowiak @ 2019-03-28 16:11 UTC (permalink / raw)
To: david.hunt; +Cc: dev, Lukasz Krakowiak
Extend debugs on power instruction and cmd police destroy
requests.
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 1a3a0fa76..32865da37 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -630,6 +630,8 @@ apply_policy(struct policy *pol)
static int
process_request(struct channel_packet *pkt, struct channel_info *chan_info)
{
+ int ret;
+
if (chan_info == NULL)
return -1;
@@ -645,6 +647,9 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
else
core_num = pkt->resource_id;
+ RTE_LOG(DEBUG, CHANNEL_MONITOR, "Processing requested cmd for cpu:%d\n",
+ core_num);
+
switch (pkt->unit) {
case(CPU_POWER_SCALE_MIN):
power_manager_scale_core_min(core_num);
@@ -677,9 +682,13 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
}
if (pkt->command == PKT_POLICY_REMOVE) {
- RTE_LOG(INFO, CHANNEL_MONITOR,
- "Removing policy %s\n", pkt->vm_name);
- remove_policy(pkt);
+ ret = remove_policy(pkt);
+ if (ret == 0)
+ RTE_LOG(INFO, CHANNEL_MONITOR,
+ "Removed policy %s\n", pkt->vm_name);
+ else
+ RTE_LOG(INFO, CHANNEL_MONITOR,
+ "Policy %s does not exist\n", pkt->vm_name);
}
/*
--
2.19.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] power: extend debugs on power instruction requests
2019-03-28 16:11 [dpdk-dev] [PATCH] power: extend debugs on power instruction requests Lukasz Krakowiak
@ 2019-03-28 16:11 ` Lukasz Krakowiak
2019-03-29 22:35 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Lukasz Krakowiak @ 2019-03-28 16:11 UTC (permalink / raw)
To: david.hunt; +Cc: dev, Lukasz Krakowiak
Extend debugs on power instruction and cmd police destroy
requests.
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 1a3a0fa76..32865da37 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -630,6 +630,8 @@ apply_policy(struct policy *pol)
static int
process_request(struct channel_packet *pkt, struct channel_info *chan_info)
{
+ int ret;
+
if (chan_info == NULL)
return -1;
@@ -645,6 +647,9 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
else
core_num = pkt->resource_id;
+ RTE_LOG(DEBUG, CHANNEL_MONITOR, "Processing requested cmd for cpu:%d\n",
+ core_num);
+
switch (pkt->unit) {
case(CPU_POWER_SCALE_MIN):
power_manager_scale_core_min(core_num);
@@ -677,9 +682,13 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
}
if (pkt->command == PKT_POLICY_REMOVE) {
- RTE_LOG(INFO, CHANNEL_MONITOR,
- "Removing policy %s\n", pkt->vm_name);
- remove_policy(pkt);
+ ret = remove_policy(pkt);
+ if (ret == 0)
+ RTE_LOG(INFO, CHANNEL_MONITOR,
+ "Removed policy %s\n", pkt->vm_name);
+ else
+ RTE_LOG(INFO, CHANNEL_MONITOR,
+ "Policy %s does not exist\n", pkt->vm_name);
}
/*
--
2.19.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] power: extend debugs on power instruction requests
2019-03-28 16:11 [dpdk-dev] [PATCH] power: extend debugs on power instruction requests Lukasz Krakowiak
2019-03-28 16:11 ` Lukasz Krakowiak
@ 2019-03-29 22:35 ` Thomas Monjalon
2019-03-29 22:35 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-03-29 22:35 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev, david.hunt
28/03/2019 17:11, Lukasz Krakowiak:
> Extend debugs on power instruction and cmd police destroy
> requests.
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-29 22:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 16:11 [dpdk-dev] [PATCH] power: extend debugs on power instruction requests Lukasz Krakowiak
2019-03-28 16:11 ` Lukasz Krakowiak
2019-03-29 22:35 ` Thomas Monjalon
2019-03-29 22:35 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).