From: "Phil Yang (Arm Technology China)" <Phil.Yang@arm.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "Hunt, David" <david.hunt@intel.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread
Date: Sat, 30 Mar 2019 16:55:22 +0000 [thread overview]
Message-ID: <DB7PR08MB3385C676D53AEE20EC53F05EE95B0@DB7PR08MB3385.eurprd08.prod.outlook.com> (raw)
Message-ID: <20190330165522.gLIFjmlnseE7DegYAGQ8T1v8Y97rg93bvrRESEPXxB4@z> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com>
> -----Original Message-----
> From: Pattan, Reshma <reshma.pattan@intel.com>
> Sent: Saturday, March 30, 2019 12:40 AM
> To: Phil Yang (Arm Technology China) <Phil.Yang@arm.com>; dev@dpdk.org;
> thomas@monjalon.net
> Cc: Hunt, David <david.hunt@intel.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each worker
> thread
>
>
>
> > -----Original Message-----
> > From: Phil Yang [mailto:phil.yang@arm.com]
> >
> > The current implementation using '__sync' built-ins to synchronize
> > statistics within worker threads. '__sync' built-ins functions are
> > full barriers which will affect the performance, so add a per worker packets
> statistics.
> >
> > Enable by option --insight-worker.
> >
>
> I don't feel the need of this new option to print per core stats. Any reason
> for this?
Hi Reshma,
Thanks for your comment.
The per core stats aims at removing the '__sync' builtin full barrier in the worker thread.
It records the workload of each core (It shows the bottleneck core as well). Since the maximum core number may be more than 128, so disable the print in default and add this new option for debugging use.
Anyway, if you insist there is no need to print that info out, I can remove the option. But I think using per core stats will benefit performance.
Thanks,
Phil
>
> Thanks,
> Reshma
next prev parent reply other threads:[~2019-03-30 16:55 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 9:49 [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins Phil Yang
2019-03-28 18:42 ` Thomas Monjalon
2019-03-28 18:42 ` Thomas Monjalon
2019-03-29 1:34 ` Phil Yang (Arm Technology China)
2019-03-29 1:34 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 0/3] example and test cases optimizations Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-03-29 16:39 ` Pattan, Reshma
2019-03-29 16:39 ` Pattan, Reshma
2019-03-30 16:55 ` Phil Yang (Arm Technology China) [this message]
2019-03-30 16:55 ` Phil Yang (Arm Technology China)
2019-04-01 12:58 ` Pattan, Reshma
2019-04-01 12:58 ` Pattan, Reshma
2019-04-02 3:33 ` Phil Yang (Arm Technology China)
2019-04-02 3:33 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-02 3:43 ` Phil Yang (Arm Technology China)
2019-04-02 3:43 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 3/3] test/ring_perf: " Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 0/3] example and test cases optimizations Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-04 23:24 ` Thomas Monjalon
2019-04-04 23:24 ` Thomas Monjalon
2019-04-08 4:04 ` Phil Yang (Arm Technology China)
2019-04-08 4:04 ` Phil Yang (Arm Technology China)
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-04 15:30 ` Honnappa Nagarahalli
2019-04-04 15:30 ` Honnappa Nagarahalli
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 3/3] test/ring_perf: " Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-07-04 20:15 ` Thomas Monjalon
2019-07-05 3:19 ` Phil Yang (Arm Technology China)
2019-07-08 14:38 ` Thomas Monjalon
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-04-10 14:05 ` Hunt, David
2019-04-10 14:05 ` Hunt, David
2019-04-11 11:31 ` Phil Yang (Arm Technology China)
2019-04-11 11:31 ` Phil Yang (Arm Technology China)
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 3/3] test/ring_perf: " Phil Yang
2019-04-08 3:02 ` Phil Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB3385C676D53AEE20EC53F05EE95B0@DB7PR08MB3385.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=reshma.pattan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).