From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 57AFBA0679
for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 15:50:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2AEEE3572;
Mon, 1 Apr 2019 15:50:17 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id F1B1D34F3
for <dev@dpdk.org>; Mon, 1 Apr 2019 15:50:15 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
01 Apr 2019 06:50:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,296,1549958400"; d="scan'208";a="160288924"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103])
([10.237.220.103])
by fmsmga001.fm.intel.com with ESMTP; 01 Apr 2019 06:50:09 -0700
To: Shahaf Shuler <shahafs@mellanox.com>, wenzhuo.lu@intel.com,
jingjing.wu@intel.com, bernard.iremonger@intel.com
Cc: dev@dpdk.org, rasland@mellanox.com, thomas@monjalon.net,
ferruh.yigit@intel.com
References: <cover.1554114165.git.shahafs@mellanox.com>
<aaf5c1bd800bca00e4b3fe50fcb2f1b464fde1ee.1554114165.git.shahafs@mellanox.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <5db4de56-c5df-568a-431b-290dc60b9ec7@intel.com>
Date: Mon, 1 Apr 2019 14:50:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: <aaf5c1bd800bca00e4b3fe50fcb2f1b464fde1ee.1554114165.git.shahafs@mellanox.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no IOVA
contig mempools
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190401135008.HL0u91mYuyzc5rWu51vPoB_mvH0MzMHtnoklJQB4enk@z>
On 01-Apr-19 11:34 AM, Shahaf Shuler wrote:
> providing a command line parameter to set the mempool flags accordingly.
> This mode is relevant only when creating an empty mempool and then
> populating with memory.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> app/test-pmd/parameters.c | 5 +++++
> app/test-pmd/testpmd.c | 3 ++-
> app/test-pmd/testpmd.h | 2 ++
> doc/guides/testpmd_app_ug/run_app.rst | 5 +++++
> 4 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 7b6b60905d..ce0056b0bd 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -202,6 +202,8 @@ usage(char* progname)
> printf(" --noisy-lkup-num-writes=N: do N random writes per packet\n");
> printf(" --noisy-lkup-num-reads=N: do N random reads per packet\n");
> printf(" --noisy-lkup-num-writes=N: do N random reads and writes per packet\n");
> + printf(" --no-iova-contig: mempool memory can be IOVA non contiguous. "
> + "valid only with --mp-alloc=anon\n");
Maybe rather than spelling this out in the help message, it would be
better to enforce it at option parse time, and document it in the user
guide?
--
Thanks,
Anatoly