DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: 'Thomas Monjalon' <thomas@monjalon.net>
Cc: "'dev@dpdk.org'" <dev@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"'stable@dpdk.org'" <stable@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early
Date: Mon, 1 Apr 2019 14:22:30 +0000	[thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8462F5FF8@HASMSX105.ger.corp.intel.com> (raw)
Message-ID: <20190401142230.TxueIDzPjru-m_7J9vwjwZUb90kZ6i_YgwSVxdPrFzU@z> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A8462F2787@HASMSX105.ger.corp.intel.com>



> -----Original Message-----
> From: Stojaczyk, Dariusz
> Sent: Wednesday, March 27, 2019 9:34 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] eal: initialize alarms early
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, March 27, 2019 7:12 PM
> > To: Stojaczyk, Dariusz <dariusz.stojaczyk@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early
> >
> > 26/03/2019 19:43, Darek Stojaczyk:
> > > We currently initialize rte_alarms after starting
> > > to listen for IPC hotplug requests, which gives
> > > us a data race window. Upon receiving such hotplug
> > > request we always try to set an alarm and this
> > > obviously doesn't work if the alarms weren't
> > > initialized yet.
> > >
> > > To fix it, we initialize alarms before starting
> > > to listen for IPC hotplug messages. Specifically,
> > > we move rte_eal_alarm_init() right after
> > > rte_eal_intr_init() as it makes some sense to
> > > keep those two close to each other.
> >
> > I wonder which regression it will bring :)
> > The experience shows that we cannot touch this function
> > without introducing a regression. Please check twice.
> 
> Hah, ok - I'll check again the possible outcomes of this.
> 

Done, I can't see any case I could break.

> >
> > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> > > Cc: Qi Zhang <qi.z.zhang@intel.com>
> > > Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> > > ---
> > >  lib/librte_eal/linux/eal/eal.c | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > You probably need to update the FreeBSD version too.
> >
> 
> Oh, that I cannot do. First of all, in bsd code I don't see
> rte_mp_dev_hotplug_init() called anywhere, as if bsd
> did not listen for IPC hotplug messages at all and hence did
> not have any data race in this area. Second, I would be
> afraid to touch any bsd code as I'm not running any bsd
> system.

Basing on Anatoly's feedback, I pushed a v2 with bsd changes
included as well.

Thanks!
D.

> 
> D.


  parent reply	other threads:[~2019-04-01 14:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 18:43 Darek Stojaczyk
2019-03-26 18:43 ` Darek Stojaczyk
2019-03-27 18:11 ` Thomas Monjalon
2019-03-27 18:11   ` Thomas Monjalon
2019-03-27 20:33   ` Stojaczyk, Dariusz
2019-03-27 20:33     ` Stojaczyk, Dariusz
2019-03-27 22:42     ` Thomas Monjalon
2019-03-27 22:42       ` Thomas Monjalon
2019-03-28 10:43       ` Bruce Richardson
2019-03-28 10:43         ` Bruce Richardson
2019-03-28 10:46         ` Thomas Monjalon
2019-03-28 10:46           ` Thomas Monjalon
2019-03-28 13:14           ` Burakov, Anatoly
2019-03-28 13:14             ` Burakov, Anatoly
2019-04-01 14:22     ` Stojaczyk, Dariusz [this message]
2019-04-01 14:22       ` Stojaczyk, Dariusz
2019-04-01 14:18 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2019-04-01 14:18   ` Darek Stojaczyk
2019-04-02 13:01   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-02 13:01     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8462F5FF8@HASMSX105.ger.corp.intel.com \
    --to=dariusz.stojaczyk@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).