From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A46C6A0679 for ; Mon, 1 Apr 2019 17:44:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D34A4C8D; Mon, 1 Apr 2019 17:44:00 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 807D53798 for ; Mon, 1 Apr 2019 17:43:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 08:43:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="160323090" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by fmsmga001.fm.intel.com with ESMTP; 01 Apr 2019 08:43:55 -0700 To: David Hunt , dev@dpdk.org Cc: liang.j.ma@intel.com References: <20190329131520.10653-1-david.hunt@intel.com> <20190401153044.39273-1-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com> Date: Mon, 1 Apr 2019 16:43:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190401153044.39273-1-david.hunt@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for high frequency cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401154355.vPoricXM97FZ21MIXvQ_WOssw1hiP-2MozF1jvMka54@z> On 01-Apr-19 4:30 PM, David Hunt wrote: > This patch adds a new bit in the capabilities mask that's returned by > rte_power_get_capabilities(), allowing application to query which cores > have the higher frequencies, and can then pin the workloads accordingly. > > Returned Bits: > 0 - Turbo Boost enabled > 1 - Higher core base_frequency > > Signed-off-by: David Hunt > --- > /* Add MSR read to detect turbo status */ > > if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) < 0) > @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct pstate_power_info *pi) > > pi->non_turbo_max_ratio = max_non_turbo; > > + /*Add the compare for base frequency */ The comment here looks meaningless, and needs to be reworded to explain why this is done, not what is done. Otherwise, Reviewed-by: Anatoly Burakov -- Thanks, Anatoly