* [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
@ 2019-04-01 16:08 Bruce Richardson
2019-04-01 16:08 ` Bruce Richardson
2019-04-01 16:23 ` Luca Boccassi
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2019-04-01 16:08 UTC (permalink / raw)
To: thomas; +Cc: dev, Bruce Richardson
The test-meson-builds.sh script correctly detects the source directory and
builds the native builds successfully in a directory outside of the source
tree. However, the paths to the cross-files are not prefixed with the
source directory path, so the cross-builds all fail. Fix this by prepending
the source directory path appropriately.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
devtools/test-meson-builds.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index e3f19a01a..b3b5cfbb5 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
# compile the general v8a also for clang to increase coverage
export CC="ccache clang"
build build-arm64-host-clang $use_shared \
- --cross-file config/arm/arm64_armv8_linux_gcc
+ --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
- for f in config/arm/arm*gcc ; do
+ for f in $srcdir/config/arm/arm*gcc ; do
export CC="ccache gcc"
build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) \
$use_shared --cross-file $f
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
2019-04-01 16:08 [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir Bruce Richardson
@ 2019-04-01 16:08 ` Bruce Richardson
2019-04-01 16:23 ` Luca Boccassi
1 sibling, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2019-04-01 16:08 UTC (permalink / raw)
To: thomas; +Cc: dev, Bruce Richardson
The test-meson-builds.sh script correctly detects the source directory and
builds the native builds successfully in a directory outside of the source
tree. However, the paths to the cross-files are not prefixed with the
source directory path, so the cross-builds all fail. Fix this by prepending
the source directory path appropriately.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
devtools/test-meson-builds.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index e3f19a01a..b3b5cfbb5 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
# compile the general v8a also for clang to increase coverage
export CC="ccache clang"
build build-arm64-host-clang $use_shared \
- --cross-file config/arm/arm64_armv8_linux_gcc
+ --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
- for f in config/arm/arm*gcc ; do
+ for f in $srcdir/config/arm/arm*gcc ; do
export CC="ccache gcc"
build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) \
$use_shared --cross-file $f
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
2019-04-01 16:08 [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir Bruce Richardson
2019-04-01 16:08 ` Bruce Richardson
@ 2019-04-01 16:23 ` Luca Boccassi
2019-04-01 16:23 ` Luca Boccassi
2019-04-01 20:01 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Luca Boccassi @ 2019-04-01 16:23 UTC (permalink / raw)
To: Bruce Richardson, thomas; +Cc: dev
On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> The test-meson-builds.sh script correctly detects the source
> directory and
> builds the native builds successfully in a directory outside of the
> source
> tree. However, the paths to the cross-files are not prefixed with the
> source directory path, so the cross-builds all fail. Fix this by
> prepending
> the source directory path appropriately.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> devtools/test-meson-builds.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-
> builds.sh
> index e3f19a01a..b3b5cfbb5 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
> # compile the general v8a also for clang to increase coverage
> export CC="ccache clang"
> build build-arm64-host-clang $use_shared \
> - --cross-file config/arm/arm64_armv8_linux_gcc
> + --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
>
> - for f in config/arm/arm*gcc ; do
> + for f in $srcdir/config/arm/arm*gcc ; do
> export CC="ccache gcc"
> build build-$(basename $f | tr '_' '-' | cut -d'-' -f-
> 2) \
> $use_shared --cross-file $f
>
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
2019-04-01 16:23 ` Luca Boccassi
@ 2019-04-01 16:23 ` Luca Boccassi
2019-04-01 20:01 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Luca Boccassi @ 2019-04-01 16:23 UTC (permalink / raw)
To: Bruce Richardson, thomas; +Cc: dev
On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> The test-meson-builds.sh script correctly detects the source
> directory and
> builds the native builds successfully in a directory outside of the
> source
> tree. However, the paths to the cross-files are not prefixed with the
> source directory path, so the cross-builds all fail. Fix this by
> prepending
> the source directory path appropriately.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> devtools/test-meson-builds.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-
> builds.sh
> index e3f19a01a..b3b5cfbb5 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
> # compile the general v8a also for clang to increase coverage
> export CC="ccache clang"
> build build-arm64-host-clang $use_shared \
> - --cross-file config/arm/arm64_armv8_linux_gcc
> + --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
>
> - for f in config/arm/arm*gcc ; do
> + for f in $srcdir/config/arm/arm*gcc ; do
> export CC="ccache gcc"
> build build-$(basename $f | tr '_' '-' | cut -d'-' -f-
> 2) \
> $use_shared --cross-file $f
>
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
2019-04-01 16:23 ` Luca Boccassi
2019-04-01 16:23 ` Luca Boccassi
@ 2019-04-01 20:01 ` Thomas Monjalon
2019-04-01 20:01 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-01 20:01 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Luca Boccassi
01/04/2019 18:23, Luca Boccassi:
> On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> > The test-meson-builds.sh script correctly detects the source
> > directory and
> > builds the native builds successfully in a directory outside of the
> > source
> > tree. However, the paths to the cross-files are not prefixed with the
> > source directory path, so the cross-builds all fail. Fix this by
> > prepending
> > the source directory path appropriately.
> >
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
2019-04-01 20:01 ` Thomas Monjalon
@ 2019-04-01 20:01 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-01 20:01 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Luca Boccassi
01/04/2019 18:23, Luca Boccassi:
> On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> > The test-meson-builds.sh script correctly detects the source
> > directory and
> > builds the native builds successfully in a directory outside of the
> > source
> > tree. However, the paths to the cross-files are not prefixed with the
> > source directory path, so the cross-builds all fail. Fix this by
> > prepending
> > the source directory path appropriately.
> >
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-01 20:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 16:08 [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir Bruce Richardson
2019-04-01 16:08 ` Bruce Richardson
2019-04-01 16:23 ` Luca Boccassi
2019-04-01 16:23 ` Luca Boccassi
2019-04-01 20:01 ` Thomas Monjalon
2019-04-01 20:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).