From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir
Date: Mon, 01 Apr 2019 17:23:39 +0100 [thread overview]
Message-ID: <8977f5e0dc0fa4c5ecf9e973c6d751b797458d9f.camel@debian.org> (raw)
Message-ID: <20190401162339.kWF3hgVylxuu78m9RpnkbwLJX2BKqYsTB5Ir17DJPR4@z> (raw)
In-Reply-To: <20190401160833.38213-1-bruce.richardson@intel.com>
On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote:
> The test-meson-builds.sh script correctly detects the source
> directory and
> builds the native builds successfully in a directory outside of the
> source
> tree. However, the paths to the cross-files are not prefixed with the
> source directory path, so the cross-builds all fail. Fix this by
> prepending
> the source directory path appropriately.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> devtools/test-meson-builds.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-
> builds.sh
> index e3f19a01a..b3b5cfbb5 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then
> # compile the general v8a also for clang to increase coverage
> export CC="ccache clang"
> build build-arm64-host-clang $use_shared \
> - --cross-file config/arm/arm64_armv8_linux_gcc
> + --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc
>
> - for f in config/arm/arm*gcc ; do
> + for f in $srcdir/config/arm/arm*gcc ; do
> export CC="ccache gcc"
> build build-$(basename $f | tr '_' '-' | cut -d'-' -f-
> 2) \
> $use_shared --cross-file $f
>
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-04-01 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 16:08 Bruce Richardson
2019-04-01 16:08 ` Bruce Richardson
2019-04-01 16:23 ` Luca Boccassi [this message]
2019-04-01 16:23 ` Luca Boccassi
2019-04-01 20:01 ` Thomas Monjalon
2019-04-01 20:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8977f5e0dc0fa4c5ecf9e973c6d751b797458d9f.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).