From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 21843A0679 for ; Tue, 2 Apr 2019 02:34:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C51D64CA0; Tue, 2 Apr 2019 02:34:19 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 159BE37A8; Tue, 2 Apr 2019 02:34:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ABEB52204C; Mon, 1 Apr 2019 20:34:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 20:34:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+mSAxefn9TGh6CrjwOIyLEHM+9kZXppXzDertqXWbi8=; b=Tv12x0JCHvMw fy3yI6o5KFYei/qjNiGeex1Kjcf2eOBBbA+8HZwZLB56bGfWP1xjaxX7JkYWKcdL mAlPi2kXTpvEau9t4kGT8/avsVjhEZAxBq3FkDVAIgH75s9CTz+WdU8pD9GpuDIC 4Ptht7lnQ/oEENWLAq82PUsMvGgXF3o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+mSAxefn9TGh6CrjwOIyLEHM+9kZXppXzDertqXWb i8=; b=Y5Ft+voLbjCJCXwfyxe9ml1ylCRO8qKHx1HSbFE/gncckbizd4EcqSYe7 LkP8+XeIC+iKEc5/3p2HagG6GyhnFqFb3+y184t/VpXFFtVWm/RPU5A9rNJrAzjz 5QvtD/47+NmXM6HsO5fP5cckmW6mzc0zY9LFFdjooJOV726q02yQNSpx1Cp58weM d5WKyinmGuwxoVXNt937EHE6h6JH5bd0njaQmPBT7N+EghASV2Ah0iylv1THMCJP 7gMSoUio8nMYY3ARSoYN9hThaypuvT63OMplsjlZK3Bv16EdT00SpOg4UCL/H0B8 QV10oizRVqtKkEiHsmHb7NWyB/gfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleehgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 51AD21030F; Mon, 1 Apr 2019 20:34:16 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, "Laatz, Kevin" , stable@dpdk.org Date: Tue, 02 Apr 2019 02:34:15 +0200 Message-ID: <8225282.udm7ztb7Ro@xps> In-Reply-To: References: <20190328153045.8178-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402003415._JYsHO_a7u07uuy4iUU4NIReHZmdHQlvs_HbjNHbAZo@z> 01/04/2019 19:17, Laatz, Kevin: > On 28/03/2019 15:30, Bruce Richardson wrote: > > If we have two NIC ports which have a different set of NIC stats we can > > end up having two different stats registered with xstats with the same > > name. [Since the stats are updated in bulk as a contiguous set, the > > second driver re-using the registration of the first is not possible.] > > > > This causes issues with the invalid stat for one driver being found due to > > a lookup by name which is unnecessary. Instead of getting stat names > > involved do the lookup by ID instead. > > > > CC: stable@dpdk.org > > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > > > > Signed-off-by: Bruce Richardson > > --- > > Looks good to me! Thanks. > > Acked-by: Kevin Laatz Applied, thanks